pool/plasma5-workspace
SHA256
12
0
Fork 1
Code Issues Pull Requests Activity

Accepting request 500172 from home:wolfi323:test

Browse Source 
- Add xembedsniproxy-fix-using-XTest.patch to fix clicking on system tray icons of certain applications, mainly GTK3 and Java (boo#1026999, kde#362941, kde#375017)

OBS-URL: https://build.opensuse.org/request/show/500172
OBS-URL: https://build.opensuse.org/package/show/KDE:Frameworks5/plasma5-workspace?expand=0&rev=322
This commit is contained in:
Fabian Vogt
2017-06-02 18:35:51 +00:00
committed by Git OBS Bridge
parent def0758cc3
commit 4f1370eb73
3 changed files with 45 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plasma5-workspace.changes
View File

@@ -1,3 +1,10 @@
-------------------------------------------------------------------
Wed May 31 13:18:59 UTC 2017 - wbauer@tmo.at
- Add xembedsniproxy-fix-using-XTest.patch to fix clicking on
system tray icons of certain applications, mainly GTK3 and Java
(boo#1026999, kde#362941, kde#375017)
-------------------------------------------------------------------
Tue May 30 17:21:05 UTC 2017 - fabian@ritter-vogt.de

2
plasma5-workspace.spec
View File

@@ -39,6 +39,7 @@ Patch1: 0001-Ignore-default-sddm-face-icons.patch
# PATCHES 100-200 and above are from upstream 5.10 branch
# PATCH-FIX-UPSTREAM
Patch100: 0001-dont-crash-if-we-don-t-have-a-launcherTasksModel.patch
Patch101: xembedsniproxy-fix-using-XTest.patch
# PATCHES 201-300 and above are from upstream master/5.11 branch
BuildRequires: breeze5-icons
BuildRequires: fdupes
@@ -212,6 +213,7 @@ workspace. Development files.
%patch0 -p1
%patch1 -p1
%patch100 -p1
%patch101 -p1
%build
%cmake_kf5 -d build -- -DKDE4_COMMON_PAM_SERVICE=xdm -DKDE_DEFAULT_HOME=.kde4 -DCMAKE_INSTALL_LOCALEDIR=%{_kf5_localedir}

36
xembedsniproxy-fix-using-XTest.patch Normal file
View File

@@ -0,0 +1,36 @@
From 7df184afa19f148c1cd09ae9588645bb2b4556fc Mon Sep 17 00:00:00 2001
From: Wolfgang Bauer <wbauer@tmo.at>
Date: Wed, 31 May 2017 13:36:59 +0200
Subject: [xembedsniproxy] Fix check whether to use XTest
Because of C++'s operator precedence, '!' logically negated
all_event_masks only instead of the whole expression.
This resulted in the condition always being false and XTest never being
used.
Adding a pair of brackets fixes it.
BUG: 362941
BUG: 375017
FIXED-IN: 5.10.1
Differential Revision: https://phabricator.kde.org/D6048
---
xembed-sni-proxy/sniproxy.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xembed-sni-proxy/sniproxy.cpp b/xembed-sni-proxy/sniproxy.cpp
index ff93ed4..5974baf 100644
--- a/xembed-sni-proxy/sniproxy.cpp
+++ b/xembed-sni-proxy/sniproxy.cpp
@@ -209,7 +209,7 @@ SNIProxy::SNIProxy(xcb_window_t wid, QObject* parent):
//if the client does supports that we send directly, otherwise we'll use xtest
auto waCookie = xcb_get_window_attributes(c, wid);
auto windowAttributes = xcb_get_window_attributes_reply(c, waCookie, nullptr);
- if (! windowAttributes->all_event_masks & XCB_EVENT_MASK_BUTTON_PRESS) {
+ if (! (windowAttributes->all_event_masks & XCB_EVENT_MASK_BUTTON_PRESS)) {
m_injectMode = XTest;
}
--
cgit v0.11.2