* No tests for :undolist and "U" command.
* When starting a job that reads from a buffer and reaching the end,
the job hangs.
* It is not possible to close the "in" part of a channel.
* QuickFixCmdPre and QuickFixCmdPost autocommands are not always triggered.
* Get warning for deleting autocommand group when the autocommand using
the group is scheduled for deletion. (Pavol Juhas)
* MS-Windows: some files remain after testing.
* Default interface versions for MS-Windows are outdated.
* When using "is" the mode isn't always updated.
* In a timer callback the timer itself can't be found or stopped. (Thinca)
* Marks, writefile and nested function tests are old style.
* Default value for 'langremap' is wrong.
* Several tests are old style.
* Old charsearch test still listed in Makefile.
* Crash when doing tabnext in a BufUnload autocmd. (Dominique Pelle)
* Accessing freed memory when a timer does not repeat.
* Appveyor 64 bit build still using Python 3.4
* Crash when autocommand moves to another tab. (Dominique Pelle)
* Crash when deleting an augroup and listing an autocommand.
(Dominique Pelle)
* No error when deleting an augroup while it's the current one.
* Insufficient testing for Normal mode commands.
* Channel sort test is flaky.
* Normal mode tests fail on MS-Windows.
* When 'incsearch' is not set CTRL-T and CTRL-G are not inserted as before.
* No way for a system wide vimrc to stop loading defaults.vim.
(Christian Hesse)
* Redraw problem when using 'incsearch'.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=380
* The field names used by getbufinfo(), gettabinfo() and getwininfo()
are not consistent.
* Tab page tests are old style.
* Test files have inconsistant modelines.
* Startup test fails on Solaris.
* There is no equivalent of 'smartcase' for a tag search.
* ":oldfiles" output is a very long list.
* The default ttimeoutlen is very long.
* Crash when using funcref() with invalid name. (Dominique Pelle)
* Can't build with +eval but without +quickfix. (John Marriott)
* submatch() does not check for a valid argument.
* The 'langnoremap' option leads to double negatives. And it does not
work for the last character of a mapping.
* Can't use "." and "$" with ":tab".
* With SGR mouse reporting (suckless terminal) the mouse release and scroll
up/down is confused.
* Warning for missing declaration of skip_vimgrep_pat(). (John Marriott)
* Tests using the sleep time can be flaky.
* Timer test sometimes fails.
* Timer test sometimes fails.
* Warning for assigning negative value to unsigned. (Danek Duvall)
* Adding pattern to ":oldfiles" is not a generic solution.
* Filter test fails.
* Oldfiles test fails.
* Tiny build fails. (Tony Mechelynck)
* When cancelling the :ptjump prompt a preview window is opened for a
following command.
* Missing colon in error message.
* Some error message cannot be translated.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=378
* When using matchaddpos() a character after the end of the
line can be highlighted.
* Can't build with +timers when +digraph is not included.
* Recursive call to substitute gets stuck in sandbox.
* printf() gives an error when the argument for %s is not a string.
* printf() does not support binary format.
* Sourcing a script where a character has 0x80 as a second byte
does not work.
* Buffer overflow when using latin1 character with feedkeys().
* Compiler warnings with older compiler and 64 bit numbers.
* Crash when placing a sign in a deleted buffer.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=377
* The qf_init_ext() function is too big.
* Compiler warning for initializing a struct.
* There is still code and help for unsupported systems.
* There is no way to get a list of the error lists.
* When using ":vimgrep" may end up with duplicate buffers.
* No proper testing of trunc_string().
* Coverage report is messed up by the unittests.
* Can't run scripttests in the top directory.
* Wrong part of #ifdef removed.
* eval.c is too big.
* Build fails.
* eval.c is too big.
* eval.c is too big.
* Non-Unix builds fail.
* Wrong file name.
* qf_init_ext() is too big.
* Using dummy variable to compute struct member offset.
* eval.c is still too big.
* Coverity warns for possible buffer overflow.
* Compiler warns for uninitialzed variable. (John Marriott)
* getcompletion() not well tested.
* Compiler warning for char/char_u conversion.
* Not all arguments of trunc_string() are tested.
Memory access error when running the message tests.
* spell.c is too big.
* Missing change to include file.
* The return value of type() is difficult to use.
* substitute() does not support a Funcref argument.
* rgb.txt is read for every color name.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=376
* Looking up a buffer by number is slow if there are many.
* Netbeans file authentication not tested.
* GTK: display updating is not done properly and can be slow.
* setbufvar() causes a screen redraw.
* filter() and map() either require a string or defining a function.
* Memory leak when using a function callback.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=374
* Memory access error when reading viminfo. (Dominique Pelle)
* "gd" hangs in some situations. (Eric Biggers)
* Not all quickfix tests are also done with the location lists.
* Background is not drawn properly when 'termguicolors' is set.
* Coverity warns for unreachable code.
* Win32: Cannot compile with XPM feature using VC2015
* The Man plugin doesn't work that well.
* File list does not include new XPM libraries.
* Viminfo continuation line with wrong length isn't skipped. (Marius Gedminas)
* Using Ctrl-A with double-byte encoding may result in garbled text.
* Minor problems with the quickfix code.
* Quickfix long lines test not executed for buffer.
* Ruby test is old style.
* Cscope interface does not support finding assignments.
* Not all parts of the quickfix code are tested.
* No test for what 7.4.1948 fixes.
* Using 32-bit Perl with 64-bit time_t causes memory corruption. (Christian Brabandt)
* When using CTRL-W f and pressing "q" at the ATTENTION dialog the newly opened window is not closed.
* Perl interface has obsolete workaround.
* Perl interface preprocessor statements not nicely indented.
* Crash when running test_channel.vim on Windows.
* Unicode standard 9 was released.
* When 'insertmode' is reset while doing completion the popup menu remains even though Vim is in Normal mode.
* Two test files for increment/decrement.
* Running Win32 Vim in mintty does not work.
* The quickfix init function is too big.
* When using a job in raw mode to append to a buffer garbage characters are added.
* Coverity reports a resource leak.
* Falling back from NFA to old regexp engine does not work properly. (fritzophrenic)
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=373
* Updating marks in a quickfix list is very slow when the list is long.
* When waiting for a character is interrupted by receiving channel
data and the first character of a mapping was typed, the mapping
times out.
* When receiving channel data 'updatetime' is not respected.
* Wrong computation of remaining wait time in RealWaitForChar()
* When umask is set to 0177 Vim can't create temp files.
* GUI: When channel data is received the cursor blinking is interrupted.
* Channel reading very long lines is slow.
* balloon eval only gets the window number, not the ID.
* Cannot easily get the window ID for a buffer.
* Cannot get the window ID for a mouse click.
* Cannot use a window ID where a window number is expected.
* Invoking mark_adjust() when adding a new line below the last line
is pointless.
* Various typos, long lines and style mistakes.
* User commands don't support modifiers.
* GTK 3: cursor blinking doesn't work well.
* Using CTRL-] in the help on "{address}." doesn't work.
* Win32: the "Disabled" menu items would appear enabled.
* No test for collapsing buffers for a channel. Some text is lost.
* When writing viminfo merging current history with history in viminfo
may drop recent history entries.
* Some compilers can't handle a double semicolon.
* Collapsing channel buffers and searching for NL does not work properly.
* Warnings from 64 bit compiler.
* Netbeans uses uninitialzed pointer and freed memory.
* Doubled semicolons.
* Tests using external command to delete directory.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=372
* Python: encoding error with Python 2.
* Memory leaks in test49.
* Invalid memory access when exiting with EXITFREE defined.
* Memory leak in test_matchstrpos.
* Setting really_exiting causes memory leaks to be reported.
* Appending to the quickfix list while the quickfix window is open
is very slow.
* When a callback adds a timer the GUI doesn't use it until later.
* Comparing functions and partials doesn't work well.
* Typing "k" at the hit-enter prompt has no effect.
* Whether a job has exited isn't detected until a character is typed.
After calling exit_cb the cursor is in the wrong place.
* Channel test is flaky.
* Appending to a long quickfix list is slow.
* Check for line break at end of line wrong.
* Cppcheck found 2 incorrect printf formats.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=367
* Tests involving Python are flaky.
* Ubsan detects a multiplication overflow.
* Getting an item from a NULL dict crashes.
* Can't build with Strawberry Perl 5.24 (obsoletes perl-5.24.patch)
* Still trying to read from channel that is going to be closed.
* GUI freezes when using a job.
* test_syn_attr fails when using the GUI.
* Unix: Cannot run all tests with the GUI.
* Crash when job and channel are in the same dict while using partials.
* When setting 'termguicolors' the Ignore highlighting doesn't work.
* Valgrind reports memory leak for job that is not freed.
* When a channel appends to a buffer that is 'nomodifiable' there
is an error but appending is done anyway.
* When a channel writes to a buffer it doesn't find a buffer by
the short name but re-uses it anyway.
* Cannot use a function reference for "exit_cb".
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=364
* non-antialiased misnamed.
* When timer_stop() is called with a string there is no proper
error message.
* Memory leak in debug commands.
* Cannot use an Ex command for 'keywordprg'.
* Possible crash when conceal is active.
* When splitting and closing a window the status height changes.
* When using a partial on a dictionary it always gets bound to that
dictionary.
* The BufUnload event is triggered twice, when :bunload is used with
`bufhidden` set to `unload` or `delete`.
* Functions specifically for testing do not sort together.
* Cannot get the items stored in a partial.
* When using packages an "after" directory cannot be used.
* The code to reallocate the buffer used for quickfix is repeated.
* get() works for Partial but not for Funcref.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=362
* The screen is not updated if a callback is invoked when closing
a channel.
* Help completion adds @en to all matches except the first one.
* Compiler warnings when sprintf() is a macro.
* Removing language from help tags too often.
* Redirecting stdout of a channel to "null" doesn't work.
* When a job is no longer referenced and does not have an exit
callback the process may hang around in defunc state.
* When job writes to buffer nothing is written.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=358
* 'guicolors' is a confusing option name.
* Quickfix doesn't handle long lines well, they are split.
* GTK3 doesn't handle menu separaters properly.
* Can't use Vim as MANPAGER.
* Running tests in shadow dir fails.
* 'termguicolors' option missing from the options window.
* Test_out_close_cb sometimes fails.
* Using wrong feature name to check for 'termguicolors'.
* Using wrong short option name for 'termguicolors'.
* Sending DETACH after a channel was closed isn't useful.
* Netbeans channel gets garbage collected.
* Memory access error when running test_quickfix.
* A channel may be garbage collected while it's still being used by a job.
* Looping over a null list throws an error.
- Refresh vim-7.4-filetype_mine.patch
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=356
* Cannot use ch_read() in the close callback.
* Leading white space in a job command matters.
* Channel could be garbage collected too early.
* Color name decoding is implemented several times.
* Some character classes may differ between systems.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=355
* When using the term truecolor feature, the t_8f and t_8b termcap
options are not set by default.
* Using negative index in strcharpart().
* Warnings reported by cppcheck.
* synIDattr() does not respect 'guicolors'.
* strcharpart() does not work properly with some multi-byte characters.
* The old regexp engine doesn't handle character classes correctly.
* Compiled-in colors do not match rgb.txt.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=354
* When using complete() it may set 'modified' even though nothing
was inserted.
* When using feedkeys() in a timer the inserted characters are not
used right away.
* Undo options are not together in the options window.
* Arguments of setqflist() are not checked properly.
* No "closed", "errors" and "encoding" attribute on Python output.
* Cannot use true color in the terminal.
* Newly added features can escape the sandbox.
* When using the term truecolor feature, the t_8f and t_8b termcap
options are not set by default.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=352
* When a buffer gets updated while in command line mode, the screen
may be messed up.
* Crash when 'tagstack' is off. (Dominique Pelle)
* When adding to the quickfix list the current position is reset.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=350
* Cannot detect a crash in tests when caused by garbagecollect().
* The help for functions require a space after the "(".
* The Perl interface cannot use 'print' operator for writing
directly in standard IO.
* It is not easy to get a character out of a string.
* Python: turns partial into simple funcref.
* Folds may close when using autocomplete.
* Test fails when not using utf-8.
* It is not possible to only see part of the message history.
It is not possible to clear messages.
* Count for ":messages" depends on number of lines.
* syn-cchar defined with matchadd() does not appear if there are no
other syntax definitions which matches buffer text.
* Not testing utf-8 characters.
* strgetchar() does not work correctly.
* Clang warns for uninitialzed variable. (Michael Jarvis)
* Python: Converting a sequence may leak memory.
* Memory leak in Perl.
* Coverity: missing check for NULL pointer.
* "gD" does not find match in first column of first line.
* When using GTK 3.20 there are a few warnings.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=349
* Crash when calling garbagecollect() after starting a job.
* When using try/catch in 'tabline' it is still considered an error
and the tabline will be disabled.
* Tabline test fails in GUI.
* Compiler errors for non-ANSI compilers.
* ANSI compiler complains about string length.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=348
* Leaking memory when opening a channel fails.
* Coverity: not using return value of set_ref_in_item().
* Leaking memory when there is a cycle involving a job and a partial.
* Tests fail without the job feature.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=347
* When using try/catch in 'statusline' it is still considered an
error and the status line will be disabled.
* For plugins in packages, plugin authors need to take care of all
dependencies.
* GTK GUI doesn't work on Wayland.
* Non-GUI specific settings in the gvimrc_example file.
* Double free when a partial is in a cycle with a list or dict.
* 'autochdir' doesn't work for the first file.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=346
* feedkeys('i', 'x') gets stuck, waits for a character to be typed.
* Building the Perl interface gives compiler warnings.
* ":syn reset" clears the effect ":syn iskeyword". (James McCoy)
* When using :stopinsert in a silent mapping the "INSERT" message
isn't cleared.
* Display problems when the 'ambiwidth' and 'emoji' options are not
set properly or the terminal doesn't behave as expected.
* :packadd does not work the same when used early or late.
* Using freed memory when parsing 'printoptions' fails.
* Using freed memory with "wincmd p". (Dominique Pelle)
* Cannot use empty dictionary key, even though it can be useful.
* New regexp engine does not work properly with EBCDIC.
* Not all output of an external command is read.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=345
* When reading JSON from a channel all readahead is used.
* channel_get_all() does multiple allocations.
* When writing buffer lines to a pipe Vim may block.
* Completion doesn't work well for a variable containing "#".
* When help exists in multiple languages, adding @ab while "ab"
is the default help language is unnecessary.
* The Dvorak support is a bit difficult to install.
* The justify plugin has to be copied or sourced to be used.
* The editexisting plugin has to be copied or sourced to be used.
* The swapmous plugin has to be copied or sourced to be used.
* The shellmenu plugin has to be copied or sourced to be used.
* A reference to the removed file_select plugin remains.
* Coverity: copying value of v_lock without initializing it.
* Coverity warns for not checking name length (false positive).
* Coverity warns for fixed size buffer length (false positive).
* Coverity: no check for NULL.
* README text is slightly outdated.
* There is no easy way to get all the information about a match.
* When running tests $HOME/.viminfo is written.
* The channel close_cb option does not work.
* MzScheme does not support partial.
* Ruby interface has inconsistent coding style.
* Can't compile with the conceal feature but without multi-byte.
* When switching to a new buffer and an autocommand applies syntax
highlighting an ml_get error may occur.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=343
* When 'F' is in 'shortmess' the prompt for the encryption key
isn't displayed.
* When binding a function to a dict the reference count is wrong.
* Invoking garbage collection may cause a double free.
* Crash when an autocommand changes a quickfix list.
* Handling emoji characters as full width has problems with
backwards compatibility.
* Terminating file name has side effects.
* Using string() on a partial that exists in the dictionary it binds
results in an error.
* When a dict contains a partial it can't be redefined as a function.
* Using Python vim.bindeval() on a partial doesn't work.
* Using freed memory after setqflist() and ":caddbuffer".
* Compiler has a problem copying a string into di_key[].
* The matchit plugin needs to be copied to be used.
* Quickfix test fails.
* Old style test for fnamemodify().
* Users who loaded matchit.vim manually have to change their startup.
* Crash when using expand('%:S') in a buffer without a name.
* remote_expr() hangs.
* Crash when using partial with a timer.
* On Unix in a terminal: channel messages are not handled right away.
* A plugin does not know when VimEnter autocommands were already triggered.
* has('patch-7.4.1') doesn't work.
* No test for special characters in channel eval command.
* No test for an invalid Ex command on a channel.
* Crash in :cgetexpr.
* Crash when calling job_start() with a NULL string.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=340
* Quickfix code using memory after being freed.
* Using channel timeout instead of request timeout.
* Timers don't work on Unix.
* Not checking for failed open().
* Memory leak when out of memory.
* When starting the GUI fails a swap file is left behind.
* Timer with an ":echo" command messes up display.
* Although emoji characters are ambiguous width, best is to treat
them as full width.
* Catching exception that won't be thrown.
* Having type() handle a Funcref that is or isn't a partial differently
causes problems for existing scripts.
* Comparing a function that exists on two dicts is not backwards compatible.
* string() doesn't handle a partial.
* Contents file is only for Amiga distro.
* Compiler warnings for non-virtual destructor.
* The versplit feature makes the code uneccessary complicated.
* Can't build with small features.
* Still can't build with small features.
* Still quickfix test in old style.
* Build fails with tiny features.
* Malformed channel request causes a hang.
* When a JSON message is split it isn't decoded.
* Starting job with output to buffer changes options in the current buffer.
* When 'fileformats' is set in the vimrc it applies to new buffers
but not the initial buffer.
* Emoji characters are not considered as a kind of word character.
* Channel test doesn't work with Python 2.6.
* Channel demo doesn't work with Python 2.6.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=337
* Crash when using function reference.
* Using ":call dict.func()" where the function is a partial
does not work.
* Get E923 when using function(dict.func, [], dict).
* Warning for unitinialized variable.
* Partial is not recognized everywhere.
* Nesting partials doesn't work.
* Compiler warnings with 64 bit compiler.
* Old style test for quickfix.
* Combining dict and args with partial doesn't always work.
* Warning for shadowed variable.
* The quickfix title is truncated.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=335
* Passing cookie to a callback is clumsy.
* Dict options with a dash are more difficult to use.
* Missing update to proto file.
* ":helptags ALL" crashes.
* An empty list in function() causes an error.
* Crash when assert_equal() runs into a NULL string.
* Crash in assert_fails().
* Using CTRL-] in help on option in parentheses doesn't work.
* Using old style tests for quickfix.
* There is no way to avoid the message when editing a file.
* No test for ":help".
* Setting 'compatible' in test influences following tests.
* Tests get stuck at the more prompt.
* ":undo 0" does not work.
* Write error of viminfo file is not handled properly.
* Cannot pass "dict.Myfunc" around as a partial.
* There is no way to invoke a function later or periodically.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=333
* Using "ever" for packages is confusing.
* Specifying buffer number for channel not implemented yet.
* MS-Windows job_start() closes wrong handle.
* Compiler warning for unitinialized variable.
* MS-Windows channel leaks file descriptor.
* Using feedkeys() with an empty string disregards 'x' option.
* Compiler warning for shadowed variable.
* The feedkeys test has a one second delay.
* Cannot re-use a channel for another job.
* Too many feature flags for pipes, jobs and channels.
* Selection with the mouse does not work in command line mode.
* Too much code in eval.c.
* Channel test is a bit flaky.
* Missing job_info().
* job_start() with a list is not tested.
* Channel log methods are not tested.
* On Win32 escaping the command does not work properly.
* GTK3: horizontal cursor movement in Visual selection not good.
* Sticky type checking is more annoying than useful.
* Getting a cterm highlight attribute that is not set results in the string "-1".
* Two tests fail.
* Cannot load packages early.
* Cannot generate help tags in all doc directories.
* ":colorscheme" does not use 'packpath'.
* ":runtime" does not use 'packpath'.
* Completion for :colorscheme does not use 'packpath'.
* List of test targets incomplete.
* "make install" changes the help tags file, causing it to differ from the repository.
* Windows cannot be identified.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=331
* Statusline highlighting is sometimes wrong.
* "J" fails if there are not enough lines.
* Channel output to file not implemented yet.
* Channel test is a bit flaky.
* Channel with disconnected in/out/err is not supported.
* Channel test: Waiting for a file to appear doesn't work.
* Cannot write channel err to a buffer.
* On a high resolution screen the toolbar icons are too small.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=329
* No error message when :packadd does not find anything.
* Garbage collection with an open channel is not tested.
* Writing last-but-one line of buffer to a channel isn't implemented yet.
* Crash when using ch_getjob().
* No test for reading last-but-one line.
* When channel log is enabled get too many "looking for messages" log entries.
* Job cannot read from a file.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=327
* When using hangulinput with utf-8 a CSI character is misintepreted.
* Function arguments marked as unused while they are not.
* Test_reltime is flaky, it depends on timing.
* ":loadplugin" doesn't take care of ftdetect files.
* No test for ":loadplugin".
* Cannot add a pack direcory without loading a plugin.
* "timeout" option not supported on ch_eval*().
* A one-time callback is not used for a raw channel.
* Channel "err-io" value "out" is not supported.
* Job input from buffer is not implemented.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=325
* Sort test doesn't test with "1" argument.
* Channel test sometimes fails, especially on OS/X.
* Coverity reports missing restore.
* Missing out-of-memory check. And Coverity warning.
* Can't build without the autocommand feature.
* Compiler warnings without the float feature.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=324
* Error when reading fails uses wrong errno. Keeping channel open
after job stops results in test failing.
* The "out-io" option for jobs is not implemented yet.
* When encoding JSON, turning NaN and Infinity into null without
giving an error is not useful.
* JSON encoding doesn't handle surrogate pair.
* Can't get buffer number of a channel.
* Using empty name instead of no name for channel buffer.
* Memory corruption when 'encoding' is not utf-8.
* Crash when using json_decode().
* Memory leak when using ch_read().
* JSON tests fail if 'encoding' is not utf-8.
* Json encoding still fails when encoding is not utf-8.
* Vim hangs when a channel has a callback but isn't referenced.
* Test 87 fails with Python 3.5.
* Opening a channel with select() is not done properly.
* When a JSON channel has a callback it may never be cleared.
* When the argument of sort() is zero or empty it fails.
OBS-URL: https://build.opensuse.org/package/show/editors/vim?expand=0&rev=322
