pool/virt-manager
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

- bsc#1071825 - AttributeError: 'NoneType' object has no attribute

Browse Source 
'change_run_text'
  virtman-register-delete-event-for-details-dialog.patch

OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=388
This commit is contained in:
Charles Arnold 2017-12-11 22:06:47 +00:00 committed by Git OBS Bridge
parent 378d8fa4ec
commit da54199b5f
3 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
virt-manager.changes
View File

@ -1,3 +1,10 @@
-------------------------------------------------------------------
Mon Dec 11 14:50:59 MST 2017 - carnold@suse.com
- bsc#1071825 - AttributeError: 'NoneType' object has no attribute
'change_run_text'
virtman-register-delete-event-for-details-dialog.patch
-------------------------------------------------------------------
Thu Dec 7 12:41:25 UTC 2017 - cbosdonnat@suse.com

2
virt-manager.spec
View File

@ -126,6 +126,7 @@ Patch206: 0001-virtinst-python3-terminal-width-should-be-int.patch
Patch207: 0002-virtinst-python3-avoid-comparison-of-None-and-int.patch
Patch208: 0003-virtinst-python3-avoid-using-long-type.patch
Patch209: 0004-virtinst-python3-use-binary-mode-for-kernel.patch
Patch210: virtman-register-delete-event-for-details-dialog.patch
BuildArch: noarch
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@ -297,6 +298,7 @@ machine).
%patch207 -p1
%patch208 -p1
%patch209 -p1
%patch210 -p1
%build
%if %{qemu_user}

22
virtman-register-delete-event-for-details-dialog.patch Normal file
View File

@ -0,0 +1,22 @@
References: bsc#1071825
Running under python3 the delete-event as defined in details.ui and connected
in details.py does not get called when the top right (x) button on the dialog
is clicked. It appears that even though this code is unchanged and works on python2,
it is not recognized as a top level dialog on python3 and therefore we explicitly
need to set the connection event. Not getting the event to cleanup leaves us in a
bad state for when the details dialog is reopened.
Index: virt-manager-1.4.3/virtManager/details.py
===================================================================
--- virt-manager-1.4.3.orig/virtManager/details.py
+++ virt-manager-1.4.3/virtManager/details.py
@@ -596,6 +596,9 @@ class vmmDetails(vmmGObjectUI):
self.console.details_auth_login),
})
+ # Make sure the delete event is properly registered for the details dialog
+ self.topwin.connect("delete-event", self._window_delete_event)
+
# Deliberately keep all this after signal connection
self.vm.connect("state-changed", self.refresh_vm_state)
self.vm.connect("resources-sampled", self.refresh_resources)