Pull request for recommended update for grub2-compat-ia32 #194
Dismiss Review
Assignees
abergmann
adrianSuSE
atartamo
autobuild-owner
autobuild-review
autogits_obs_staging_bot
autogits_workflow_pr_bot
bfilho
bigironman
darix
dmach
eroca
factory_bot
gitea-actions-autobuild
gsonnu
jdsn
legaldb
lkocman-factory
maintenance-release-review
maxlin_factory
mbozicevic
mimi_vx
mschnitzer
msmeissn
mstrigl
oertel
opensuse-review
packagehub-review
pluskalm
qam-openqa-review
rfrohl
smithfarm
szarate
Clear assignees
abergmann
adrianSuSE
atartamo
autobuild-owner
autobuild-review
autogits_obs_staging_bot
autogits_workflow_pr_bot
bfilho
bigironman
darix
dmach
eroca
factory_bot
gitea-actions-autobuild
gsonnu
jdsn
legaldb
lkocman-factory
maintenance-release-review
maxlin_factory
mbozicevic
mimi_vx
mschnitzer
msmeissn
mstrigl
oertel
opensuse-review
packagehub-review
pluskalm
qam-openqa-review
rfrohl
smithfarm
szarate
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: products/PackageHub#194
Reference in New Issue
Block a user
Delete Branch "msmeissn/PackageHub:maintenance-update-1761560140"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR: pool/grub2-compat-ia32!2
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:194 .
Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, pluskalm, rfrohl, slemke .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@maintenance-release-review: approve.To request changes on behalf of the group, create the following comment:
@maintenance-release-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build successful
what about comment from adamm ?
Same as I wrote in slack:
osc api /build/openSUSE:Backports:SLE-16.0:PullRequest:194/standard/x86_64/_repository returns empty, thus the bot doesn't know about any packages to use but for other projects it returns the list of binaries in the update.
Max mentions:
I did install the update manually and can confirm that it works (new params are added to grub config, and system works after a reboot)
@qam-openqa-review: approve
szarate approved a review on behalf of qam-openqa-review
comment from adamm about requires post/postun in pool PR is still unresolved
Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, pluskalm, rfrohl, slemke .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@maintenance-release-review: approve.To request changes on behalf of the group, create the following comment:
@maintenance-release-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:194 .
Additional QA builds:
https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:194:Leap
Build successful
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
@opensuse-review : approve
LGTM
merge ok
oertel approved a review on behalf of opensuse-review
@maintenance-release-review: approve
merge ok
rfrohl approved a review on behalf of maintenance-release-review
@qam-openqa-review: approve
szarate approved a review on behalf of qam-openqa-review
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, pluskalm, rfrohl, slemke .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@maintenance-release-review: approve.To request changes on behalf of the group, create the following comment:
@maintenance-release-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:194 .
Additional QA builds:
https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:194:Leap
Build successful
waiting for review by someone
@maintenance-release-review: approve
merge ok
rfrohl approved a review on behalf of maintenance-release-review
Same as #194 (comment) just tested manually
@qam-openqa-review: approve
szarate approved a review on behalf of qam-openqa-review
unresolved comments pending from adamm
@opensuse-review : approve
LGTM
merge ok
oertel approved a review on behalf of opensuse-review