rpm/polari
SHA256
1
0
Fork 0
forked from pool/polari
Code Pull Requests Activity

Accepting request 822577 from GNOME:Factory

Browse Source 
OBS-URL: https://build.opensuse.org/request/show/822577
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/polari?expand=0&rev=43
This commit is contained in:
Dominique Leuenberger 2020-07-29 15:15:24 +00:00 committed by Git OBS Bridge
commit 80a15ec1a1
3 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
polari-fix-log-spam.patch Normal file
View File

@ -0,0 +1,45 @@
From eb918032722041abaed5f74a37a091e322e2d319 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Sat, 18 Jul 2020 16:12:25 +0200
Subject: [PATCH] urlPreview: Move margin into CSS
Setting it in code for some reason confuses size negotiations, resulting
in warnings about negative size requests. It looks like CSS margins
don't suffer from the same problem, so just use those instead.
https://gitlab.gnome.org/GNOME/polari/-/issues/142
---
data/resources/application.css | 3 +++
src/urlPreview.js | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/data/resources/application.css b/data/resources/application.css
index a0a57a76..e455304f 100644
--- a/data/resources/application.css
+++ b/data/resources/application.css
@@ -118,6 +118,9 @@ treeview.polari-server-room-list {
}
.url-preview { padding: 8px; }
+.url-preview { margin: 12px; }
+.url-preview:dir(ltr) { margin-left: 0; }
+.url-preview:dir(rtl) { margin-right: 0; }
.url-preview image { min-width: 120px; min-height: 90px; }
.url-preview label { font-size: small; }
diff --git a/src/urlPreview.js b/src/urlPreview.js
index e388b78b..b818c812 100644
--- a/src/urlPreview.js
+++ b/src/urlPreview.js
@@ -78,8 +78,6 @@ var URLPreview = GObject.registerClass({
this.set({
orientation: Gtk.Orientation.VERTICAL,
- margin: 12,
- margin_start: 0,
spacing: 6,
});
--
GitLab

5
polari.changes
View File

@ -1,3 +1,8 @@
-------------------------------------------------------------------
Sat Jul 18 19:15:46 UTC 2020 - Bjørn Lie <bjorn.lie@gmail.com>
- Add polari-fix-log-spam.patch: Quiet down unneeded warnings.
-------------------------------------------------------------------
Wed Jun 3 16:34:04 UTC 2020 - Bjørn Lie <bjorn.lie@gmail.com>

2
polari.spec
View File

@ -28,6 +28,8 @@ Source0: https://download.gnome.org/sources/polari/3.36/%{name}-%{version
Source99: polari-rpmlintrc
# PATCH-FIX-UPSTREAM polari-fix-nb-translation.patch glgo#GNOME/polari!145 -- Fix Norwegian bokmål translation
Patch0: polari-fix-nb-translation.patch
# PATCH-FIX-UPSTREAM polari-fix-log-spam.patch -- Quiet down unneeded log warnings
Patch1: polari-fix-log-spam.patch
BuildRequires: gjs >= 1.57.3
BuildRequires: meson >= 0.43.0