forked from pool/rpmlint
716ca7d8fd
551 Commits
Author | SHA256 | Message | Date | |
---|---|---|---|---|
716ca7d8fd |
- Update to version 84.87+git20180703.88daa4e:
* Adjust order of output as well OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=601 |
|||
40e7ac70b4 |
- Update to version 84.87+git20180703.03176da:
* adjust reference testoutput for removal of badness OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=600 |
|||
e67391f602 |
- Update rpmlint-checks to version master:
* New file 5.33 does identify pie executables now (bsc#1097339) OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=599 |
|||
ea2b14b777 |
Accepting request 620194 from home:cschweingruber:branches:devel:openSUSE:Factory:rpmlint
- Add 'sogo' user and group (used in server:SOGo) - add rpmlint-tests-sle15.patch to fix rpmlint-tests build for sle/leap 15 - Update to version 84.87+git20180220.6f1f0aa: * polkit: adjust reference output to match corresponding change in rpmlint-checks - Update to version 84.87+git20180218.1142fcc: * Update polkit ref tests - Update to version 84.87+git20180202.3df4ae7: * Add testcases for MenuXDGCheck.py - Update to version 84.87+git20171011.8b163ac: * Trying to fixup the erlang check - Update to version 84.87+git20171011.856375f: * Add unit test for ErlangCheck - Update to version 84.87+git20171010.a53d9bd: * Remove appdata related tests, those are upstream now - Update to version 84.87+git20171009.dfac67b: * Adjust output for enabled non-std group checks - Update to version 84.87+git20170930.921e051: * Update reference files against rpmlint 1.10 - Update to version 84.87+git20170928.27b6cb3: * Adjustments for newer rpmlint drop 0001-Update-varrun-test-for-Leap-42.2-severity-reduction.patch rpmlint-pie-factory.patch, rpmlint-pie-leap42.patch: this belongs into git - Update to version 84.87+git20170928.d2c55ee: * Remove some outdated sysv init check, we have switched to systemd - rpmlint-pie-leap42.patch, rpmlint-pie-factory.patch: adjust testsuite to match new PIE warning, for both Leap 42.3 and Factory. - Update to version master: * remote unused/outdated checks - Update to version 84.87+git20170418.092177d: * Remove initscript related tests, systemd FTW! - Update to version 84.87+git20170320.f92cea5: * Adjust for new init script check - Update to version 84.87+git20161214.5500838 * add checks for shlib-policy-name-error and "no dependency on *lib*" - remove 0002-Update-license1-test-for-Leap-42.2-severity-reductio.patch as rpmlint-Factory-strict is pulled in always. - Patch lint severity reductions for >= Leap 42.2: 0001-Update-varrun-test-for-Leap-42.2-severity-reduction.patch 0002-Update-license1-test-for-Leap-42.2-severity-reductio.patch - Update to version 13.2+git20160725.8d99488: * add check for calls to gethostbyname and similar * add check for correct invocation of chroot - remove rpmlint-check-gethostbyname.patch - BuildRequire rpmlint-Factory-strict to have same config on all releases, fixes failed tests on Tumbleweed - add regression test for boo#970170 - Update to version 13.2+git20151130.b31588d: + add shared library tests - Update to version 13.2+git20151113.ff9879a: + adjust for tmpfiles fix - Update to version 13.2+git20151110.e8d6260: + fixed two new warnings - Update to version 13.2+git20150520.a374c88: + add tmpfiles.d checks - Update to version 13.2+git20150519.278efdf: + add ghost file checks + print names of failed tests - Update to version 13.2+git20150410.6161e60: + build our own non-PIE binaries, as the distribution slowly gets converted to all PIE binaries (removed rpmlint-pie-fixes.patch) - rpmlint-pie-fixes.patch: build own non-pie binaries to avoid relying on random system binaries. - Update to version 13.2+git20150310.00c9b55: + fix reference output when new bash is used - fix rclink* tests by adding expected systemd macros - add test cases for systemd macros - adjust for new var/run check - use service file - add appdata check - fix reference output for non-ghost* tests - add tests for rc links (bnc#860340) - update reference data to match Factory - generate tarball via service file - update reference data to make checks pass again (bnc#793546)) - omit debug packages from checks - add pam test case - adjust to new badness score for non-position-independent-executable - add logrotate test - add test for buildroot check - suse-filelist-empty is not fatal anymore - add -devel group check - adjust to new license check and add test case - non-ghost-in-var-run is fatal now - fix testsuite - check for false positives in pie test - add polkit test - add an actually readable package description - add check for /var/log/subsys - update ref files - another init script test case - add new initscript warnings - initial package - Add 'sogo' user and group (used in server:SOGo) - whitelisting NetworkManager-libreswan plugin (bnc#1089340) - add Lua/NodeJS related groups to list of valid groups (bsc#1095769) - Update rpmlint-checks to version master: * Blacklist python test folder in python packages * Error out on /etc/bash_completion.d in packages * Do not use otherproviders() SUSEism - Add Development/Languages/OCaml group. - Add 'synapse' user and group. - Add 'openvswitch' user and group. - whitelisting pam_yubico module (bsc#1087060) - adding new names for kalarm DBUS service (bsc#1087714) - added bacula user and group. - Add tox user and toxcmd group as standard openSUSE GID and UID - Corrected tpm2-abrmd (bnc#1049694). The D-Bus activation file is named differently than the configuration file. - Add one more deprecated license: + GPL-2.0-with-font-exception. - allow more deprecated licenses to unbreak ring1+2 - add 0001-Always-import-XDG-desktop-files-as-utf8.patch - Allow some deprecated licenses that we would replace on commit (SPDX 2->SPDX 3 conversion) - Update rpmlint-checks to version master: * polkit: make untracked privileges also an error - Update rpmlint-checks to version master: * Support uppercase tag macros used by RPM 4.14 - Update to version 84.87+git20180202.3df4ae7: * Add testcases for MenuXDGCheck.py - refresh for 0001-Improve-XDG-Menu-checks-stability.patch remove xdg-paths-update.diff (merged into other patch) - whitelisting usbauth (bsc#1066877) - Add Development/{Languages,Libraries}/Rust groups as noted in wiki - add missing comma (,) to config file - add user/group _nsd for NSD name server - add 0001-Binariescheck-Check-for-chroot-chdir-on-ARM-PPC.patch - whitelisting kcmsddm (bsc#1065563) - Update to version master: * Fix warnings * Add new rpmlint check for new %{_fillupdir} macro (boo#1069468) * Open paths within the rpm file itself * Fix python warning * BashismCheck: Only check regular files * Rewrite BashismsCheck to actually work - Add rpmlint-slpp-NUM-NUM.patch: Match libFOO<num>-<num> as a valid dependency on a libary. According the openSUSE packaging policy, if the library name ends on a number, we add a dash between the basename (before the .so) and the version after .so. - Update rpmlint-tests to version master: * Add Flake8 travis check * Fix scriptprog invocation * Print the duplicated filenames sorted to be stable accross multiple calls - add 0001-Avoid-calling-close-on-undefined-fd-variable.patch - Description updates. Use the %make_install macro. - update suse-whitelist-opensuse.diff to avoid a false positive - adding connman (bsc#1057697) - add 0001-Accept-python-abi-as-a-valid-versioned-python-depend.patch - refresh 0001-Improve-XDG-Menu-checks-stability.patch (bsc#1063371) - Update to version master: * Python 3.x porting of the ErlangCheck - Update to version master: * Treat strongly versioned libs also as compliant (bsc#723726) * LibraryPolicy: allow %%_licensedir in packages (used by %license) - Hide the noisy warnings - add 0001-Avoid-false-positives-on-is_elf-check.patch (bsc#1057216) add 0007-Validate-Appdata-also-when-appstream-util-is-unavail.patch - Update rpmlint-checks to version master: * Fix false positives for -theme- -> -branding- rename * Stop leaking filedescriptors * Pythonic fixes * Drop CheckAppdata (there is AppDataCheck upstream) * Tighten ELF check * Tiny code formatting cleanup * Tighten the branding policy reporting a bit to make it less confusing - add package groups from https://en.opensuse.org/openSUSE:Package_group_guidelines to enable the groups check - Update rpmlint-checks: * Flake8 fixes * Properly anchor systemd path checks * Python 3.x porting * Add TmpFilesCheck * Flake8 / Stop leaking filedescriptors * Port LibraryPolicyCheck to Python 3.x - Update rpmlint-tests: * Stop leaking filedescriptors * Address various deprecation warnings * Avoid leaking fds and further Python 3.x porting - update to 1.10: * test: Skip fedoradev GPG checks at least for now * test: Refresh fedora* packages on image build * test: Use assertEqual where appropriate, thanks to flake8/hacking * test: Update fedora24 config to fedora26, run it on Travis * Add a new test for tmpfiles.d snippets in the /etc/ tree. * Add new tests for systemd units and udev rules in /etc/ tree * test: Disable hacking for now until it's flake8 3.4+ compatible * test: Set up flake8-bugbear, enable it in fedoradev container * rpmlint: Avoid unused loop control variable * ZipCheck: Add TODO * *: Avoid mutable argument defaults * Be aware of -debugsource packages * rpmdiff: Fix unused variable from previous commit * rpmdiff: Support soft dependencies * BinariesCheck, FilesCheck: Ignore various .build-id dirs * Add python3-devel and rpm-build to fedoradev container to provoke some issues * BinariesCheck: Popen env consistency fix * Pkg.getstatusoutput: Set LC_ALL for all Popens, defaulting to C * rpmlint: Fix checking specfile from stdin * test.sh: Extract rpmlint command to run_rpmlint * Revert "Remove unused spec_lines check_spec argument" * BinariesCheck: Trivial cleanups * travis: Run make install too * FilesCheck: Allow multiple bytecode magic values per Python version * tests: Make output test tools easier to reuse * FilesCheck: hg.python.org -> github.com/python * Pkg: Return vendor and distribution as unicode strings * FilesCheck: Add Python 3.7 bytecode magic value * Pkg.b2s: Add some more test cases * Pkg.b2s: Pass through str as-is on Python 3 * TagsCheck.py: accept SPDX "and" and "or" operators in all-uppercase spelling * rb'foo' is not supported in Python 2, use br'foo' instead * travis: Enable centos6 * Avoid Python 3.6 invalid esc seq warnings, use more raw strings * flake8 fixes * SpecCheck: Detect patches applied with "patch <" and "patch -i" * add /usr/lib/systemd to DEFAULT_HARDCODED_LIB_PATH_EXCEPTIONS (#93) * SpecCheck: Do not demand versioned filename Provides/Obsoletes * FilesCheck: Update Python 3.6 bytecode magic value again * Config: Fix flake8 3.2 / pycodestyle 2.2 errors (closes #82) * *: Fix various low hanging issues flagged by pycodestyle 2.1.0 (#82) * test.sh: Output flake8 --version * rpmdiff.1: update Arturo Borrero Gonzalez email address * FilesCheck: Update Python 3.6 bytecode magic value * Skip chroot-without-chdir check on non-x86_64 * shlib-with-non-pic-code: add text on how to figure files compiled without -fPIC (#79) * *: Move indentation etc settings to .editorconfig * AbstractCheck: Close urllib responses explicitly also on error * tests: Switch Travis tests to Docker * Use importlib to load checks where available * FilesCheck: Use os.devnull * Testing: Avoid ResourceWarning on config read * Run tests with warnings on * Ignore negative returncode after SIGPIPE caused by closing on purpose * Fix last commit * Use default bufsize, move regex compile to common place * BinariesCheck: lower memory requirements, fix chroot/chdir detection * FilesCheck: Avoid crash accessing non-ASCII filenames in some cases * Filter: More non-ASCII print fixing, including in e.g. C locale * SpecCheck: Output spec basename, not tempfile when checking srpm * Cleanups * FilesCheck: Update Python 3.5 and 3.6 bytecode magic values * test: Test for unexpected errors in default and C locales * Remove obsolete LC_ALL setting from Makefile - drop version-control-internal-file.diff, boo1027577-license_tag.patch, add-weak-dependencies.diff: upstream - drop sourced-dirs.diff, fix-shared-library-matching.diff, suse-python-abi-check.diff, add-check-for-tmpfiles-created-at-r.diff: obsolete - drop suse-readd_terminator_in_regex.patch: merged into original patch - add suse-tests-without-badness.patch, 0001-Extend-scm_regex-to-capture-more-SCM-system-files.patch, 0003-Tighten-lib_regex-to-avoid-false-positive-in-python-.patch, 0001-Execute-chroot-tests-also-on-x86-rpms.patch, ignore-readelf-ar-error.diff, remove-ghostfile-checks.diff, fix-diag-sortorder.diff, drop-unicodedata-dep.diff, 0001-Tighten-wrong-script-interpreter-check-to-lower-fals.patch, 0001-Improve-XDG-Menu-checks-stability.patch, 0001-split-wrong-script-interpreter-into-env-script-inter.patch, 0001-Handle-post-scripts-that-contain-non-ascii-character.patch - drop config.in: unused - switch to python 3.x - update to 1.9: * Pkg: Fix magic.descriptor availability check * warn: Define only once, with print_function * FilesCheck: Check for *.gir in devel, *.typelib in non-devel, fixes #74 * FilesCheck: Improve devel-file-in-non-devel-package description * flake8: Ignore H105 * Makefile: Remove generate-isocodes dep from __isocodes__ * __isocodes__: Regenerate * generate-isocodes: Switch to JSON source files (#72) * test.sh: Check man pages for warnings * Delete dead if-block * Filter: Line wrap cleanup * Filter: Use sys.version_info to check Python version * Fix octal string literals * Solve exceptions on printing str (Fixes #61) * tests: Add autofs binary rpm for testing non-ASCII output issues * test: Add some test packages containing non-UTF-8 filenames * BinariesCheck: avoid false chroot w/o chdir when objdump fails * flake8 fixes * rpmdiff: Import site only if needed * Testing: Add and use default for path to tests * FilesCheck: Update Python 3.6 bytecode magic value * FilesCheck: Fix regression in finding shebangs without arguments * Ignore .cache dir * Clean up Python < 2.6 cruft * Add hacking flake8 to Travis and ignores * flake8 fixes * Use new style classes * Run flake8 on rpmdiff and rpmlint too * Handle more file open/close with "with" * Exception handling cleanups * FilesCheck: Look for shebang only at start of file * travis: python3-rpm doesn't exist even for Trusty, so can't test with 3.4 * travis: Switch to Ubuntu Trusty, test with Python 2.7 and 3.4 * Use Travis apt addon for whitelisted packages * Test import order * Sort imports per PEP8, Google Python Style Guide * Add Python 3.6 magic value * Fix resolving Python source from 3.5 *.opt-[12].pyc * Move most Emacs settings to .dir-locals.el * Add %python2_sitearch and %python3_sitearch to private SO paths * Prevent empty paths from entering private SO paths * remove files-attr-not-set check * Expand postin/postun once per pkg instead once per file * Install rpm in travis for signature check * Avoid running some regexps * Run flake8 in test suite * flake8 fixes * make test suite fail on more errors * Comment update * Note and test libmagic >= 5.05 dep * Fix magic processing for Python 3 * Mimic magic closer for symbolic links * Workaround slowness due to python-magic bug * Shortcut file magic, derive from file mode * Spelling fix * Unbreak create_*regex_call now that lines are shortened by call_regex * Drop unnecessary symbol_table_regex * Avoid false function call vs definition positives, thanks to Stefan Bruens * pep8 fixes * Add some pep8 settings * Split parsing of readelf output into header and symbols part * Skip checks for problematic function calls if common prefix does not match * Use shlex.quote for better shell escaping where available * TODO update * Don't limit build badge to master branch * Convert README to markdown * Travis: install rpm2cpio * +TODO * Travis: Use Python 2.7 and system site packages * Travis: try pytest from pip instead of apt-get * Initial travis setup * Include interpreter arguments in output messages for filtering control * Flag /usr/bin/env as a wrong interpreter - drop rpmlint-pkg-quoting.diff, suse-g-ir-chech.diff, remove-expand-macros.diff, remove-files-attr-not-set-check.diff, postin-speedup.diff, binaryinfo-speedup.diff, 0001-Fix-resolving-Python-source-from-3.5-.opt-12.pyc.patch, issue_68_BinariesCheck_lower_memory-1.patch, issue_68_BinariesCheck_lower_memory-2.patch, issue_68_BinariesCheck_lower_memory-3.patch, issue_68_BinariesCheck_lower_memory-4.patch, BinariesCheck_fix_chroot_check_on_non_x86.patch: either upstreamed as is or slightly different - drop suse-sysv-init-checks.diff, 0001-Avoid-messing-with-the-error-encoding-Fixes-61.patch, suse-filesystem.diff, script-interpreter-only-for-exec-sc.diff: obsolete - drop update_git.sh related stuff: this is obsolete, patches are either supposed to be upstreamed or handled via quilt - add suse-skip-macro-expansion.diff: rename from remove-expand-macros.diff - Update to version master: * Ignore trailing whitespace in permission files (bsc#1060738) - Add group 'singularity' for package singularity (See network:cluster/singularity) (FATE#323048). - Add dehydrated user & group for dehydrated, a letsencrypt client FATE#323377 - Adding fwupd (bsc#932807) - add coroqnetd for corosync-qnetd to rpmlint - Adding NetworkManager-l2tp (bsc#846337) - Adding pam_script (bsc#1039848) - Adding nfs-ganesha (bsc#997880) - Added tpm2-abrmd (bnc#1049694) - Add user mednafen for mednafen network play server - Adding pam_dbus (bsc#1039709) - rpmlint-all-pie.patch: for non-PIE built binaries emit a warning to suggest build them as PIE. - std-user and std-group 'bitcoin' added for building correct bitcoin daemon - Add BinariesCheck_fix_chroot_check_on_non_x86.patch Check for correct invocation of chroot was only implemented for x86 - std-user and std-group 'xymon', added for building correct xymon client - whitelisting openqa (bsc#1039290) - add 'prometheus' and 'grafana' standard users and groups - whitelisting switchroo-control (bsc#1034309) - whitelisting backintime (bsc#1007723, bsc#1032717) - whitelisting thunderbolt (bsc#1033554) - Update to version master: * remote unused/outdated checks - Update to version 84.87+git20170418.092177d: * Remove initscript related tests, systemd FTW! - Adding kwalletmanager5 (bsc#1033296) - Adding os-autoinst (bsc#1032649) - remove CheckKDE4Deps, CheckInitScripts - actually enable CheckSysVinitOnSystemd - Add logstash to StandardGroups and StandardUsers. - rpmlint-checks: * Check for old SysVinit scripts and the usage of insserv (FATE#322953) * Prevent a false-positive in systemd - fix boo#1027577 patch boo1027577-license_tag.patch - rename user/group sks to _sks following https://github.com/LinuxStandardBase/lsb/pull/21 - adding blueman (bsc#987141) - Add gdm to StandardGroups. - Add polkitd to StandardUsers. - suse-spdx-license-exceptions.patch: removed fuzziness from patch. - issue_68_BinariesCheck_lower_memory.patch: split into seperate patches issue_68_BinariesCheck_lower_memory-1.patch issue_68_BinariesCheck_lower_memory-2.patch issue_68_BinariesCheck_lower_memory-3.patch issue_68_BinariesCheck_lower_memory-4.patch and unfuzzed patch number 3. - Whitelisting rebootmgr (bsc#1019644) - Whitelisting powerdevil discretegpuhelper (bsc#1019748) - Adding org.freedesktop.resolve1.conf (bsc#917781) - add suse-readd_terminator_in_regex.patch Fixes bad detection of dependencies for devel packages - update suse-obsolete-version check (bsc#743981) - whitelisting pam_slurm (bsc#1007053) - whitelisting pam_gdm (bsc#1004346) - config: whitelist flatpak dbus service/config (bsc#984817) - adding sysprof DBUS service (bsc#996111) - Adding sks (Synchronizing Key Server) to known user/group - rpmlint-checks: * Make checks python3 compatible * Fix update-alternatives check when it's quoted - Update some checks to work on both Python 2 and 3 - rpmlint-checks: * Fix typo in BrandingPolicyCheck.py - Add issue_68_BinariesCheck_lower_memory.patch Fixes out-of-memory errors on 32bit systems (bsc#969732) - Adding prosody to known user/group - add 0001-Fix-resolving-Python-source-from-3.5-.opt-12.pyc.patch: Fixes FilesCheck to resolve correctly the python source file from pyc files following PEP0488 (like *.{tag}.opt-[12].pyc). (bsc#982076) - suse-spdx-license-exceptions.patch, suse-sysv-init-checks.diff: adjust to match rpmlint-tests again - update link to list of valid licenses - temporary approval for tcmu-runner dbus service (bsc#978903) - add omit_BUILDROOT_from_pyo_files.patch (boo#978306) - add suse-spdx-license-exceptions.patch (bsc#973404) - whitelisting openattic (bsc#972478) - Updated config file to add user chrony and group chrony (Fate#319508) - whitelist rabbitmq user and group - Fix boo#970170: rpmlint no longer detects gethostbyname calls, also detect gethostbyname{,2}{,_r}, gethostbyaddr{,_r} * update suse-binariescheck.diff * rpmlint-check-gethostbyname.patch - add 0001-Avoid-messing-with-the-error-encoding-Fixes-61.patch (bsc#967556) - fix requires - add 'guixbuild' as standard group - don't require %config for bash completion scripts in /etc - whitelist systemd-importd (bnc#964935) - enable tests during building - add postin-speedup.diff, binaryinfo-speedup.diff - whitelist iio-sensor-proxy (bsc#939191) - whitelist drbdmanage DBUS (bsc#956811) - add wireshark group [bsc#957624] - adding thermald DBUS service (bsc#954771) - fix shared library matching (fix-shared-library-matching.diff) - rpmlint 1.8 update * python 3 fixes * Add support for file triggers * Mechanism to black list certain C calls * new error: non-devel-file-in-devel-package * appdata check configurable * project moved to github * Patches dropped: avoid-mismatched-libregex.diff filename-non-utf8-exception.diff fix-ghost-file-handling.diff save-content-to-an-array.diff fix-TmpFilesCheck-pattern-match.diff move-ghost-file-check-to-TmpFilesCh.diff - fix TmpFilesCheck not finding pattern in the full script (fix-TmpFilesCheck-pattern-match.diff) - whitelisting cinnamon settings daemon (bsc#951830) - Speedup CheckBuildDate check - add _service file snippet for rpmlint-checks and regenerate from git - Added salt user and group (bnc#939831) - Added teamd DBUS config (bnc#941993) - Add shibd user and group [fate#318304] - Add vnc user and group. (fate#318936) - add a whitespace line as %autosetup seems broken. - Add mysql group to the known groups - skip files handled by tmpfile mechnism in regular ghost file check (move-ghost-file-check-to-TmpFilesCh.diff) - fix update_git.sh - make sure tmpfiles are listed in %files (add-check-for-tmpfiles-created-at-r.diff) - don't complain about missingok ghost files (fix-ghost-file-handling.diff) - remove obsolete check for %defattr in spec files (remove-files-attr-not-set-check.diff) - added standard user and group ceph (bnc#928492) - fixing some .conf/.service suffixes - adding realmd DBUS service (bnc#916766) - update save-content-to-an-array.diff with upstream version - new versioin 1.6 - add script update_git.sh based on qemu's to simplify importing a patch series from git after rebasing. * Patches dropped: 0001-Python-3-compatibility-tweaks.patch (upstream) 0001-Set-Python-3.4-magic-number-to-3310.patch (upstream) add-scoring-support.diff (different upstream solution) check-buildroot-during-install.diff (need to fix no-cleaning-of-buildroot check upstream) fix-versioned-prereq.diff (was disabled, not sure what it's useful for) ignore-non-readable-in-etc.diff (filtered anyways) locale-support.diff (drop) locale-update.diff (different upstream solution now) more-verbose-lsb-check.diff (drop) perl-versioned-rpath-deps.diff (upstream) rpmlint-1.5-disallow-var-run-and-var-lock.diff (upstream) rpmlint-1.5-Fix-setgroups-error-name.diff (upstream) rpmlint-decode-fix.diff (different upstream solution) rpmlint-fix-unexpanded-macros-for-array-values.patch (different upstream solution) stricter-tags-check.diff (merged in weak deps and check-for-self-provides.diff) suppress-for-perl-python.diff (use filter instead) suse-binary-info-compile-opts.diff (drop) suse-changelog.patch (change config instead) suse-mono-deps-checks.diff (useful?) suse-required-lsb-tags.diff (different upstream solution) verify-buildrequires.diff (very build system specific, drop) xdg-check-exception.diff (upstream) * renamed patches: script-interpreter-only-for-exec-scripts.diff -> script-interpreter-only-for-exec-sc.diff confusing-invalid-spec-name.patch -> confusing-invalid-spec-name.diff suse-manpages-for-rc-scripts.patch -> suse-manpages-for-rc-scripts.diff sysv5-init-checks.diff -> suse-sysv-init-checks.diff * added patches: check-for-self-provides.diff save-content-to-an-array.diff - use the correct networkd dbus service names. (bnc#918799) - added systemd network DBUS service (bnc#918799) - added storaged DBUS service (bnc#915769) - add standard users and groups pcp and pcpqa for pcp - whitelist sddm (boo#897788) - added firewalld dbus service (bnc#907625) - added iouyap group (bnc#904060) - added standard user and group davfs2 (bnc#907662, FATE#318116) - Added standard user and group crowbar for crowbar systemmanagement - added standard user and group siproxd for the siproxd proxy - added standard user iodined for the iodine DNS tunnel daemon - FATE#314409. Add libstoragemgmt user/group. - Add sddm user/group - Added standard user/group polipo - Add user/group unbound for unbound caching dns server - adjust initscript check to match new systemctl based %restart_on_update resp %stop_on_removal - Add the groups systemd-journal, systemd-journal-gateway, and tape as required by systemd - Add the user systemd-journal-gateway as required by systemd - updated rpmlint-checks-master.tar.gz to include CheckSystemdInstall.py - allow org.kde.kf5auth.conf after adjustment of race condition (bnc#864716) - added user and group sensu required for sensu server, client - allow user and group ddclient for the ddclient users (bnc#881520) - allow user bitlbee for the bitlbee irc server. - enable oFono DBUS for SLE12 (bnc#862354) - enable org.selinux.service and org.selinux.conf of policycoreutils (pending more review) bnc#878631 - add 0001-Set-Python-3.4-magic-number-to-3310.patch (bnc#876470) - dd filter expections for filesystem package - disallow /var/run and /var/lock (rpmlint-1.5-disallow-var-run-and-var-lock.diff) - adding ovirtagent standard user and standard group names (uid/gid 175) - adding baloo DBUS service file (missing in last request) (bnc#866131) - adding baloo DBUS config, formerly nepomuk (bnc#866131) - allow /run (bnc#870190) - update KMPPolicycheck - added group 'squid' for squid - added user, group 'boinc' for boinc-client - allow org.freedesktop.GeoClue2.Agent.conf (bnc#862216) - add minimal check to verify appdata.xml files are parsable XML - added patches: * rpmlint-fix-unexpanded-macros-for-array-values.patch - fix _unexpanded_macros for array values - rip out all decode in an attempt to make it work - modified patches: * rpmlint-decode-fix.diff - added paches: * rpmlint-decode-fix.diff - Fix decode from UTF-8 string in Python 2 - usr-arch.diff: update usr_arch_share_regex - adapt to new rpm weak dependency tags - added patches: * 0001-Python-3-compatibility-tweaks.patch - Change openstack- related users to non-prefixed variants, as they get renamed with the switch to Icehouse - whitelisting networkmanager-openswan (bnc#808549) - remove suse-rclink-check.diff and implement as separate check for systemd units instead (bnc#860340). - Added group 'ts-shell' for terminal server - Whitelisting NFC neard DBUS service (bnc#837978) - Add user and group 'arangodb' for ArangoDB database server - Whitelisting kwallet DBUS service (bnc#849739) - Whitelisting bluez DBUS service (bnc#768062) - Adding org.selinux DBUS service (bnc#848550) - Add 'elasticsearch' to standard users and groups * package: elasticsearch * Summary: Open Source, Distributed, RESTful Search Engine * URL: http://www.elasticsearch.org * License: Apache-2.0 * systemd elasticsearch.service needs LimitNOFILE=65535 LimitMEMLOCK=infinity for user and group elasticsearch - Whitelisting com.redhat.tuned DBUS service (bnc#787379) - Sync checks with git (FATE#316521) - whitelist second iteration of wicked dbus service names (bnc#783932) - blacklist old systemd/udev directories (bnc#816467) - remove checking for groups (bnc#767551) - ignore icon size mismatches on animated icons (bnc#480664) - update obsolete/invalid suse version check - whitelisted mate DBUS Service (bnc#831404) - add requirement for ErlangCheck.py (pull request #2) - whitelisted GeoClue2 DBUS Service (bnc#838360) - allow pam_mate_keyring (same to gnome keyring) (bnc#831404) - update rpmlint-checks from git - add suse-ignore-specfile-errors.diff: ignore specfile-errors - add xdg-check-exception.diff: handle xdg menu files without exec entry (bnc#833384) - allow pam_snapper after audit (bnc#815383) - follow /usr move for the /bin/ binaries in pie.config. - fix setgroups error name, patch from upstream git: rpmlint-1.5-Fix-setgroups-error-name.diff - allow systemd machined service as-is (bnc#828207) - Allow current wicked DBUS services (bnc#783932) - allow nepomuk helpers temporary without full audit (bnc#825262) - drop outdated Update-alternatives check (bnc#826993) - add basic new update-alternatives check - Add 'chef' to standard users and groups - allowed kcm helper for lightdm-kde-greeter (bnc#794705) - allow fprintd DBUS services (bnc#792095) - Add group 'locate' for mlocate package - update to 1.5: * New Homepage * Plenty of new checks - add compressed-backup-regex.diff - remove python3_magic_number_fix.diff - Add user and group 'svn' for svnserve in package subversion - add new ModemManager interface / service (bnc#798273) - add suse-filter-more-verbose.diff: * make it more obvious which rpmlintrc causes an exception (bnc#801192) - allow nm-iodine-service.conf DBUS service (bnc#781071) - Add user and group 'empd' for erlang - Add user 'fonehome' and group 'fonehome' - Add Kolab users + groups * kolab (Kolab System Account / management) * kolab-n (Kolab System Account (N) / non-privileged) * kolab-r (Kolab System Account (R) / restricted) - fix incorrect branding require warnings - update check for %run_permissions - Add suse-manpages-for-rc-scripts.patch: Don't complain about missing man-pages for rc-scripts - Add colord uid and gid. - Add additional OpenStack users/groups - Added a patch (python3_magic_number_fix.diff) to update the magic number for python 3 (patch taken from upstream). - whitelist org.freedesktop.AutoMount.conf (bnc#782691), that wants to talk to udisks - add libopenal1 to legacy exceptions again. Got lost after the packaging changes apparently. - allow snapper dbus service after audit (bnc#759391) - no longer allow semicolon in licenses - Remove check for /var/lock and /var/run since it's in upstream rpmlint already. - Add README.packaging.txt to explain packaging of file rpmlint-checks-$VERSION.tar.gz - Package all *py files into rpmlint-checks tarball - Add _service file to update rpmlint-checks tarball - Add /etc/systemd.d, /etc/modules-load.d and /etc/tmpfiles.d to the blacklist, only users should write here. - Blacklist the directories used by systemd. - Remove SuSEconfig directories (update patch suse-filesystem.diff) - Add warnings about files on tmpfs in /var/lock or /var/run. - restore LibraryPolicy from git - fix one more case of scripts progs changing types - update to 1.4: * rpmdiff: Teach rpmdiff about pretrans and posttrans * SpecCheck.py: merge patch from #97, using BuildArch with something else than Noarch is likely a error and causing issues. * FilesCheck.py: Add Python 3.3 magic number * FilesCheck.py, InitScriptCheck.py, MenuCheck.py, Pkg.py, PostCheck.py: Prepare for rpm-python possibly returning script progs as arrays. - added icinga users and groups - remove python naming check (bnc#768247) - add libopenal1 to legacy exceptions. It's a special case since the ABI for openal is defined in a standard and there can be multiple imlementations of the standard. Therefore it's necessary to have some kind of prefix or suffix for packages that contain libopenal1 - add bluez dbus autolaunch stub (bnc#768062) - Add several OpenStack users/groups - Cleanup list of SuSEconfig scripts - remove non-existant entries. - remove tdb tools binaries, not needed for PIE (bnc#765476) - add cdemu-deamon to dbus white list (bnc#764063) - add check for pam modules (fate#313077) - add texlive.texlive to whitelist (bnc#762144) - add 'mktex' group as used by texlive - fix false positives for swp matching - better deal with spaces in logrotate config - add colord-sane dbus service to whitelist (bnc#752518) - fix parsing of update-alternatives and clarify info message - block .swp files as well (they are usually vi(m) backup files) - add udisks2 to dbus whitelist (bnc#742751) - add smb4k to dbus whitelist (bnc#749065) - ignore fixed dependencies on config() - add logrotate check (bnc#677335) - NetworkManager.conf was renamed to org.freedesktop.NetworkManager.conf (bnc#747780) - suse-filelist-empty is meant as warning only - add standard group and user znc (server:irc/znc) - added standard user and group "puppet" - reenable libtool wrapper check - unbreak config afer DesktopTranslationCheck was removed - create the valid licenses from list tracked by SUSE legal (dumped into obs-service_format_spec_file, so use that one as buildrequire) - added: standard group 'tor' - added: standard user 'tor' - the untranslated-desktop-file check is obsolete, in factory all .desktop files are trimmed and marked - in all other projects (including devel projects) %suse_update_desktop_file won't touch the files for translation only - fix invalid-suse-version-chec (bnc#732671) - fix devel-package-with-non-devel-group check (bnc#732897) - enable license check - add NetworkManager-openconnect to dbus whitelist (bnc#732915) - add global filter for SuSEfirewall2's sysconfig file as setBadness in the package is not allowed - added: standard group 'citadel' - added: standard user 'citadel' - changed: addDetails('non-standard-uid', ... branch paket ...', 'non-standard-uid', ... branch paket ...') - add vacation/vacation to valid group/user list (needed for PostfixAdmin's vacation.pl script) - avoid warning with shlib policy on libtool - check for versioned dependency on python(abi) (bnc#659068) - fix stripping of unknown polkit suffixes (bnc#711485) - update to 1.3: * Add --rawout option * Warn about non-ghost files in /var/run and /var/lock * Fix setting message type for reasons with badness threshold defined * Use "declare -F" instead of "type" to check if a bash function exists. - add jenkins/jenkins to valid group/user list - Spelling fixes - add org.kde.kalarmrtcwake to dbus whitelist (bnc#707723) - only consider executable ELF files for non-position-independent-executable check - add more users and groups from Factory - add lightdm user and group (bnc#708205) - add org.freedesktop.DisplayManager.conf (bnc#708205) - remove obsolete knotification-requires check - bump obsolete openSUSE version to 11.2 - add more systemd dbus services to whitelist (bnc#705677) - CheckSUIDPermissions: use non-position-independent-executable as accepted upstream - remove some false positives of the no-dependency-on checker - fix library policy check complaining about non-ELF files (bnc#700067) - add colord to dbus whitelist (bnc#698250) - CheckPolkitPrivs.py: use different tag for non-fatal issues - CheckBuildDate.py: print either file-contains-current-date or file-contains-current-date but not both - add check for /var/lock/subsys usage - disable source-or-patch-not-compressed. Not useful anymore. - add synche-connector (bnc#683956) to dbus whitelist - update system-config-printer (bnc#694640) in dbus whiteliste - update legacy filter in shlib policy checker - new version 1.2 * Check outdated or misspelled FSF addresses in text files. - update rpmlint-pie.diff and suse-file-var-run.diff with upstream accepted variant - don't filter non-standard-gid anymore - add dir-or-file-in-var-lock check - remove 'nobody' from standard users - add not-a-position-independent-executable check - add radvd user to known list - add org.freedesktop.hostname1 to dbus whitelist (641924) - add account services (bnc#676638) - another try to fix InitScriptCheck.py (bnc#690961) - implement setFilterException() - rediff noarch-lib64.diff and enable it again (bnc#663885) - make error description more clearn (bnc#686328) - fix abort in BinariesCheck - fix sysv5-init-check.diff for real - fix sysv5-init-check.diff to not throw exception - fix sysv5-init-check.diff to check for preun, not postin - update CheckInitScripts.py: * add check for runlevel 4 * clarify boot.* error * accept $null in start/stop tags - also check for %run_permissions if package doesn't actually need permissions handling - merge suse-binarieschecks.diff and suse-hide-unstripped-outside-build.diff and fix the former - ignore dir-or-file-in-usr-local as it's handled by CheckFilelist.py - non-standard-dir-in-usr dito - add urfkill (bnc#688328)) - update to 1.1: - remove upstreamed patches * FilesCheck.py: Don't crash if a file cannot be opened * FilesCheck.py: Update expected Python 3.2 bytecode magic value * TagsCheck.py: Improve no-description-tag info message * TagsCheck.py: Improve changelog related info messages. * Pkg.py: Treat 'Unspecified' as a valid Group * TagsCheck.py: Add future and overflow checks for changelog * FilesCheck.py: Don't emit spurious executable perm warnings for docs with shebangs * FilesCheck.py: Don't read "head" of files for in each test * SpecCheck.py: Check source and patch file sizes and MD5 hashes * Pkg.py: Fix traceback when stringifying epoch-only versions * TagsCheck.py: Fix TypeError when outputting * Pkg.py: Make file capabilities available in PkgFile - add check for missing rcXXX symlinks (FATE#310641) - add NetworkManager to dbus whitelist (bnc#681128) - add wpa_supplicant to dbus whitelist (bnc#681116) - fix typo (bnc#675329) - add better help message for non-standard-uid - add kde backlight helper to whitelist (bnc#672145) - add webyast to dbus whitelist (bnc#660981) - add hal dbus system activation file too - add mumble-server to dbus white list (bnc#660784) - add NetworkManager-strongswan to dbus white list (bnc#656222) - Fix message for no-changelogname-tag: This is also caused by missing changes file. Original message posed a contradiction, in case the %changelog section header was there. - remove filter for no-url-tag (bnc#642588) - clarify wording for run_ldconfig check (bnc#637187) - skip desktop files in /etc (bnc#604283) - fix exception on postgresql build - also check ghost files for permission violations - add check for %set_permissions - modify match in CheckSUIDPermissions to work with new macros - allow info messages even if badness scoring is used - change Documentation/SuSE to /SUSE (bnc#618716) - whitelist "openSUSE" at start of Summary (bnc#618716) - remove invocations of expandMacro() - fix another exception in branding policy check (bnc#652628) - enable suse-hide-unstripped-outside-build.diff again - check for file system capabilities - check for %verifyscript and %run_permissions - update to 1.0: * add support for PEP 3147 when handling python bytecode * various doc improvements - remove debug logging - fix BrandingPolicy.py - fix supplements parsing (bnc#648404) - add build time check (bnc#635351) - init script check logic - add all currently known dbus services as legacy exception - add configurable whitelist to CheckDBUSServices.py - fix regression in suse-binariescheck.diff - add check for gnome and desktop related macros - Added lxdm as a valid group and user - update to 0.99: * Add Python 2.7 magic number ( https://bugzilla.redhat.com/623607, Nils Philippsen) - update to 0.98: * Pkg.py, test/test.Pkg.py: Fix self-obsoletion bug with Provides containing Epoch. * Pkg.py: Don't stringify None Epoch to 'None' string in compareEVR(). * Pkg.py: Sync rangeCompare() with yum 3.2.27. * TagsCheck.py: Reduce some spell check noise. * rpmlint: Fix handling of arguments containing spaces. * DocFilesCheck.py: Bypass doc file check earlier if package has no doc files. - Add suse-g-ir-chech.diff: *.gir belong in -devel packages. - Update suse-version.diff: last non-obsolete version of openSUSE is 11.1, and latest valid version of openSUSE is 11.4. - fix printWarning error in CheckBashisms - add confusing-invalid-spec-name.patch - add BashismsCheck - add Development/Debug group (bnc#612044) - additionally look at the BUILD_DEBUG variable to determine whether a warning should be printed. Needs an updated 'build' script. - don't print unstripped binary warning when used with build script (bnc#618004) - added "System/GUI/LXDE" as a valid rpmgroup - don't allow perl vendorarch in noarch packages - check for gethostbyname calls (bnc#506945) - fix branding check (bnc#579556) - fix exception in interpreter check - restrict shlib-fixed-dependency to shlib-policy packages - allow files in /tmp to be listed as %ghost - tighten pkg-config check - check for missing xinetd.d (bnc#436326) - check for files in /var/run (fate#303793) - check for live update problems (bnc#477649) - rediff and enable the shared lib dependency check fix - Add some missing rpm groups and sort list. - tighten the interpreter check (bnc#574650) - suppress warnings about cron.d symlinks (bnc#591431) - workaround unicode error exceptions on non-utf8 filenames - rediff some suse specific patches - fix buildroot detection (bnc#584952) - update to 0.95: * Skip ghost files in files checks, https://bugzilla.redhat.com/570086 * Work around Python's ASCII non-TTY stdout and our non-ASCII output. * Omit spell check warnings for capitalized words that do not start a sentence. * Wrap bunch of long lines, tune comments and info messages. * Require rpm-python >= 4.4.2.2 for expandMacro() in r1729. * do not execute check if the network test are marked as disabled, and simplify the logic * do not expand the format of the filename format, (patch from Per Oyvind Karlsten ) - update to 0.94: - rpm 4.8.0 support - better python bytecode checks - improved LSB/taglist - various fixes/patches upstreamed - update and enable CheckPolkitPrivs - update suse version check (add 11.2, drop 10.3) - fix usr-arch.diff - require python-magic as it's needed by some checks - suppress depmod warnings (bnc#456048) - add some missing groups - disable badness for group check until we know the impact - add a config file for standard RPM groups - fixed bnc#566018 - no-ghost-alternative-file check makes no sense - fixed CheckAlternativesGhostFiles test, renamed the warnings to generic-name-not-in-filelist, generic-name-not-marked-as-ghost - enable parallel build - update to 0.92: * various fixes and python 3 compatibility added * new checks for python compiled files - tighten the regex for libraries (bnc#544906) - fix exceptions in BinaryInfo - update to 0.90: * Makefile: 0.90. * rpmdiff: Add missing magic coding comment (https://bugzilla.redhat.com/508683, Michal Nowak). * TagsCheck.py: Fix incorrect info in self-obsoletion message. * FilesCheck.py: Output interpreter in non-executable-script warning, remove quotes from wrong-script-interpreter one. * Pkg.py: Remove stale comments. * TagsCheck.py: Code cleanup, NFC. * TagsCheck.py: improve percent-in-* message details. * TagsCheck.py: Remove obsolete-on-name check (superseded by self-obsoletion). * TagsCheck.py: Add check for self-obsoletion cases, https://bugzilla.redhat.com/461610 * Pkg.py: Borrow various utilities from yum's rpmUtils.miscutils. * Makefile, rpmUtils: Revert previous commit. * Makefile, rpmUtils, rpmUtils/miscutils.py, rpmUtils/transaction.py: Borrow rpmUtils/{miscutils,transaction}.py from yum. * rpmdiff: Improve dependency formatting. * rpmdiff: Take Epoch into account in self-provides filtering. * Pkg.py: Improve legacy prereq tracking with new rpm versions. * BinariesCheck.py: Don't output missing-PT_GNU_STACK-section messages if readelf failed. * FilesCheck.py: Add check for debuginfo packages without sources. * FilesCheck.py: Allow more common files to be non-readable (https://bugzilla.redhat.com/226412). * FilesCheck.py: Revert relative symlink target normalization back to more aggressive. * BinariesCheck.py, Config.py, ConfigCheck.py, FHSCheck.py, FilesCheck.py, I18NCheck.py, MenuCheck.py, Pkg.py, PostCheck.py, TagsCheck.py, rpmdiff: Code cleanups. * FilesCheck.py: Do not check existence of relative link targets on the filesystem for consistency with absolute link target checks, improve dangling-*symlink info messages. * FilesCheck.py, Pkg.py: Be a bit stricter when normalizing link targets, do it earlier. * FilesCheck.py, Pkg.py: Improve link target normalization in symlink checks. - filter cross-directory-hard-link as it is duplicate to a suse check - filter buildroot related checks (bnc#536594) - Added CheckAlternativesGhostFiles.py - see bnc#534451 comment#17 - disable bogus patch to InitScriptCheck.py. Causes failures and needs to be reworked - fix and add weak dependencies patch again to make some suse checks work - fix CheckPkgConfig.py to work with rpmlint 0.87 - refresh some patches to remove fuzz - BuildIgnore rpmlint-mini as it is currently broken - don't import pprint in CheckSUIDPermissions.py - remove /selinux again. No package except 'filesystem' is supposed to include that. - add filter for FHS violation of skelcd type packages - fix some more suse patches - added /selinux to allowed prefixes in CheckFilelist.py - add cups to dbus whitelist (bnc#515977) - fix suse checks for 0.87 - fix syntax error in suse-hide-unstripped-outside-build.diff - update to 0.87: * remove old rpm support * improved performance and compat with python 2.6 * many pylint/pychecker code fixes - fix library policy checker being inactive due to API change - update to 0.85: * various new checks and fixes to existing checks * remove upstreamed patches - use separate error for sysconfig stuff (bnc#470965) - move RCS detection to FilesCheck.py - remove explicit requires on python, already handled by %py_requires - remove check for /usr/share/info/dir from CheckFilelist.py, already in upstream FilesCheck.py - fix exception for texinfo - improve information hint for perl blacklisted paths - fix language list for sr (bnc#471254) - add exception for nfs-utils, texinfo and perl - allow backup files if they are ghost files - add check for DBus Policy problems - CheckFilelist: optimize FHS check to only complain about wrong directories rather than hundreds of individual files - CheckFilelist: add exceptions for kde and pam - CheckPolkitPrivs: use info instead of warning to avoid badness assignment - prefix dbus check with suse- - add filelist check - add whitelist entry for libieee1284 - add a check for PolicyKit privileges (disabled atm) - add check for DBUS services - update suse version check (add 11.1, drop 10.2) - check library packages more strict (bnc#456053) - ignore shared objects in a versioned non-std subdir (bnc#435588) - only test for regular files in ChkPkgConfig check - add check for otherproviders() in branding packages - correct kde4 related dependency checkers to not give false advises - check for wrong-arch references in pkgconfig files (graphviz) - lower false positives of untranslated-desktop files check - support for checking .comment.SUSE.OPTs. real check has been left out for now - generate a different error for directories with setuid/setgid bit - add check for /etc/permissions violations - update to 0.84: * remove upstreamed patches * no significant changes - add description for useless-explicit-requires (bnc#405887) - rediff patch - Fix name of completions file. - be more verbose in the lsb init script checks - change mandatory-lsb-keyword check to be in line with insserv - remove python-base in the warning as it is confusing. the warning itself is still valid though - fix config typo - enable non-conffile-in-etc warning (bnc#409643) - fix shlib policy dependency warnings (bnc#405280) - update cron dependency checker (bnc#400921) - No PT_GNU_STACK on ia64 and ppc64. - also read /etc/rpmlint/factory.config - fix typo in suse-version check - update to 0.83: * removed upstreamed patches * a couple of new checks, bugfixes - fix exception in tags check (bnc#399655) - add a warning for self-conflicts - fix naming policy check for lib64 based archs (bnc#392524) - fix typo in kde4 deps check - fix typo in branding policy check - readd cron check - fix kmp check after the policy change - add checker for correct deps of kde4 packages - add check for mono requirements (BNC#381979) - improve branding policy checks - add support for weak/reverse dependencies - add checks for percent's in weak/reverse dependencies - add checks for incorrect kmp dependencies (bnc384084#) - fix exception on testing for unversioned branding provides - suppress script warnings about /var/adm/fillup-templates (bnc#379601) - add start of a branding policy checker - Fix some regex in BinariesCheck - Add symtab and debuginfo tests for static libs - autogenerate users/groups from autobuild (bnc#374601) - suppress non-devel buildrequire dependency for tcl - fix licenses symlink handling (bnc#370364) - allow /usr/share/locale/be@latin (bnc#370418) - fix some false positives - add check for a really short description - be less restrictive in pkgconfig checks - suppress tag-not-utf8 warnings for now - add check for %run_ldconfig - improve check output - improved tags check - cleanups - reduce package-size-check false positives - add another postscript check - fix typo in sorting routine - updated spec file name-guessing to catch more cases - updated dot-in-identifier check - suppression updates - update to 0.82: * some patches were upstreamed * small bugfixes - rework fix for bnc#354177 to consider python bytecode arch-independent again, but catch it in arch-dependent paths - fix some minor buglets - consider python bytecode to not be arch independent (bnc#354177) - improve postcheck to ignore unexpanded macros in comments (bnc#355306) - check binary rpath for perl version dependency (bnc#355053) - add check for unversioned self-provides - update suse checks from SVN - check for dot's in dependencies - forbidden by autobuild policy - improve documentation - check for libtool wrapper scripts being packaged (#353240) - reapply patch-detection fix - add suppression for libzypp - fix wrong indentation in verify-buildrequires - bugfixes in check-mkdir-buildroot - bugfix in percent-post check - check for buildroot in %post scriptlets - remove abused legacy shared lib policy exceptions - suppression update - fix suppression for internal packages - add suppression for non-remote_fs on boot.* (#340588) - add warning for non-utf8 filenames (#343216) - more prereq checks - suppression update - add more prereq checks - fix prereq parsing code (#336712) - update the obsolete-suse-version check to include 10.0 and 11.0 - fix prereq checks to check for coreutils - reporting format change-back got rejected by upstream, so adopt other changes to deal with it - change back reporting format to list the severity first - add more legacy suppressions found by library policy fix - also check for Library Policy errors in /opt/kde3/lib - update to 0.81: * various new checks, some bugfixes * many patches upstreamed * rediffed all other patches - NOTE: output format has changed from W: package check-id .. to package.<arch>: W: check-id .. - another round of updates - library policy legacy suppression update - added 'mysql' to the list of standard users and groups - removed 'jonas' (dropped package) from that list - update library policy checker for libgcc and libcaca - check for /usr/share/gnome/help in documentation checks (#310134) - add check for non-whitelisted filedependencies (#326803) - fix hardlink check for /bin - Fix last change. - fix off-by-one in hardlink check - fix exception in DuplicatesCheck - fix buildroot false positive - check for hardlinks across partitions (#304167) - improve mkdir-installroot check - fix rpmlint package regarding check above ;) - improved the non-devel-buildrequires check - added some default filters for non-devel-buildrequires and unneccessary-buildrequires - check for wrong cleaning of buildroot in %install (#300232) - check for obscure and unneccessary buildrequires - add an icon size check (#163547) - refine the $remote_fs dependency check - suppression update - improved macro checks - documentation update - detect makefile junk (#217472) - suppression update - fix a couple of false positives - fix package-with-huge-docs check to not complain about documentation-only packages - remove verbosity from the shared library packaging policy check - fix man page check false positives - make package-with-huge-docs check less verbose - accept lua as a builtin shell - fix false positives on filesystem package - add check for init scrips missing $remote_fs - adjust library policy suppressions for opal and pwlib (#290347) - fix readme check (#291150) - its also a devel package if it provides a -devel subpackage (#289735) - suppress %config check for now (#286231) - fix typo in devel-rpmgroup check - another update list of legacy packages - update list of legacy packages - suppressions for mono related packages (#282121) - fix the bzip2/gzip confusion again - update list of legacy packages - add list of legacy package names with non-policy conform package name - check updates from SVN - suppression update - suppress devel-file-in-non-devel package if its just a compat symlink to another .so - avoid unstripped binaries warnings in BETA - fix filesystem lint false positives - suppression update - add descriptions to sysv5 init checks - use readelf for binary info to improve performace - check if source patch/tarballs is not bzip2'ed and bigger than 100k (suse packaging conventions requirement) - check if package contains excessive sized documentation - hide errors related to .packlist files from perl still need to figure out though why they're there - fix build - make the buildroot check work - make the buildroot check factor 10-15 faster - fix the pkgconfig check - fix warning-hide hack (#279865) - description update - hide unstripped-binary-or-object warning outside build (#279865) - fix typo in library policy check - adopt library checks for suse library packaging policy - add check for unnecessarily packaged files - description update - suppression update - suppression update - fix various checks - add checks for init scripts - update LibraryPolicy Checker - suppression update - fix XDG menu checker to also include non-/usr paths - fix ghost-file-creation check to skip missingok files (#278761) - suppression-update - Library Policy Checker crash fixes (#278592) - add description for missing lsb tags check - fix obsolete-not-provided for yast2-provides - fix devel-file check matching module names (e.g. apache2) - avoid spurious executable warnings for docdatadir/examples - add LibraryPolicy checker from Richard (warning only) - suppression update - fix suppression for qa_ packages - fix exceptions caused by DesktopTranslation check - fix crash caused by trailing colons in requires - fix file paths in Duplicate and DesktopTranslation checks - update sourced-dirs list - add some more standard users - add suppression for devel-file-in-non-devel package in java - filter some more noise - add descriptions for obsolete suse version check - suppress some more noise - don't run duplicates check for source rpms - suppress errors for cross-avr-* - suppress devel-packaging-naming errors for gcc41, gcc42 - group output by check and put errors last (#276943) - suppress some more noise (#277308) - suppress %ifarch-applied-patch (#277316) - more suppressions for misnamed devel packages (#277317) - Suppress errors about platform dependent code in /usr/share if its inside a platform-dependant subdirectory - Suppress devel-file-in-non-devel-package for systemtap (#277338) - Make sure that the package fails if there is any syntax error anywhere - typo fix - update config - add three more checks - update Duplicates Check to not crash on ghost files - suppress bzip2 related warnings - no documentation for lib packages - add a check how much space is wasted by duplicated files - remove rpm-devel requirement - add check for filerequires on /usr/bin/env - fix syntax errors in previous change - add a check for /opt/kde3 not in %doc or in %lang - fix files not in %lang check - remove tabs from sources - fix desktop file check (#252482) - allow extensions to LSB starting with "X-" (#271495) - remove check for usedforbuild tag. magic happens and it is created automatically - add spec checks for obsolete suse hacks - update to 0.80: * many more checks - suppression updates - suppressions for OpenOffice and linux-kernel-headers - update suppressions - fix compatibility with rpm-python of sles9 (#216081) - update to 0.77: * updated checks regarding FHS compliance * some python-lint fixlets - update to 0.76 - update to 0.75 - suppress some glibc related errors (#157906) - add km to the list of valid locales - converted neededforbuild to BuildRequires - add check for untranslated desktop files - fix i18n subdir check - filter init-script-name-with-dot /etc/init.d/boot.* and script-without-shellbang /etc/profile.d/* - update to 0.71 - strip "requires-on-release" for now, too much noise - ignore dir-or-file-in-opt - update to 0.70 - upgrade to rpmlint 0.69 - split out the config file from the SUSE patch - remove some MDK specific tests and add some SUSE specific tests - building as non-root - initial version OBS-URL: https://build.opensuse.org/request/show/620194 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=598 |
|||
e6e9b3fd61 |
Accepting request 616106 from home:mgerstner:branches:devel:openSUSE:Factory:rpmlint
- whitelisting NetworkManager-libreswan plugin (bnc#1089340) OBS-URL: https://build.opensuse.org/request/show/616106 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=596 |
|||
441da09de8 |
- add Lua/NodeJS related groups to list of valid groups (bsc#1095769)
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=594 |
|||
c570150c6e |
- add Lua/NodeJS related groups to list of valid groups
- Update rpmlint-checks to version master: * Blacklist python test folder in python packages * Error out on /etc/bash_completion.d in packages * Do not use otherproviders() SUSEism OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=593 |
|||
84940addb2 |
Accepting request 607725 from home:onthewings:branches:devel:openSUSE:Factory:rpmlint
Add Development/Languages/OCaml group as suggested in https://build.opensuse.org/request/show/604407 The group has been used in many OCaml packages, including OCaml itself. I also added it to the wiki: https://en.opensuse.org/openSUSE:Package_group_guidelines#Languages OBS-URL: https://build.opensuse.org/request/show/607725 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=592 |
|||
3acb7afc4f |
add missing file
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=590 |
|||
86dfa7af59 |
- add rpmlint-tests-sle15.patch to fix rpmlint-tests build for
sle/leap 15 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=589 |
|||
ae65822bc4 |
Accepting request 604377 from home:okurz:branches:devel:openSUSE:Factory:rpmlint
Add synapse user and group fo matrix-synapse OBS-URL: https://build.opensuse.org/request/show/604377 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=588 |
|||
27aa711a2b |
Accepting request 603154 from home:markoschandras:branches:devel:openSUSE:Factory:rpmlint
- Add 'openvswitch' user and group. OBS-URL: https://build.opensuse.org/request/show/603154 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=586 |
|||
1b61f1b628 |
Accepting request 598566 from home:mgerstner:branches:devel:openSUSE:Factory:rpmlint
- whitelisting pam_yubico module (bsc#1087060) OBS-URL: https://build.opensuse.org/request/show/598566 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=584 |
|||
1c5c2c3f52 |
Accepting request 595303 from home:mgerstner:branches:devel:openSUSE:Factory:rpmlint
- adding new names for kalarm DBUS service (bsc#1087714) OBS-URL: https://build.opensuse.org/request/show/595303 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=582 |
|||
95c720f6ea |
- added bacula user and group.
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=580 |
|||
dc089f0ce1 |
Accepting request 592876 from home:novellscheiss:branches:devel:openSUSE:Factory:rpmlint
- Add user 'bacula' and group 'bacula' - Update to version 84.87+git20180220.6f1f0aa: * polkit: adjust reference output to match corresponding change in rpmlint-checks - Update to version 84.87+git20180218.1142fcc: * Update polkit ref tests - Update to version 84.87+git20180202.3df4ae7: * Add testcases for MenuXDGCheck.py - Update to version 84.87+git20171011.8b163ac: * Trying to fixup the erlang check - Update to version 84.87+git20171011.856375f: * Add unit test for ErlangCheck - Update to version 84.87+git20171010.a53d9bd: * Remove appdata related tests, those are upstream now - Update to version 84.87+git20171009.dfac67b: * Adjust output for enabled non-std group checks - Update to version 84.87+git20170930.921e051: * Update reference files against rpmlint 1.10 - Update to version 84.87+git20170928.27b6cb3: * Adjustments for newer rpmlint drop 0001-Update-varrun-test-for-Leap-42.2-severity-reduction.patch rpmlint-pie-factory.patch, rpmlint-pie-leap42.patch: this belongs into git - Update to version 84.87+git20170928.d2c55ee: * Remove some outdated sysv init check, we have switched to systemd - rpmlint-pie-leap42.patch, rpmlint-pie-factory.patch: adjust testsuite to match new PIE warning, for both Leap 42.3 and Factory. - Update to version master: * remote unused/outdated checks - Update to version 84.87+git20170418.092177d: * Remove initscript related tests, systemd FTW! - Update to version 84.87+git20170320.f92cea5: * Adjust for new init script check - Update to version 84.87+git20161214.5500838 * add checks for shlib-policy-name-error and "no dependency on *lib*" - remove 0002-Update-license1-test-for-Leap-42.2-severity-reductio.patch as rpmlint-Factory-strict is pulled in always. - Patch lint severity reductions for >= Leap 42.2: 0001-Update-varrun-test-for-Leap-42.2-severity-reduction.patch 0002-Update-license1-test-for-Leap-42.2-severity-reductio.patch - Update to version 13.2+git20160725.8d99488: * add check for calls to gethostbyname and similar * add check for correct invocation of chroot - remove rpmlint-check-gethostbyname.patch - BuildRequire rpmlint-Factory-strict to have same config on all releases, fixes failed tests on Tumbleweed - add regression test for boo#970170 - Update to version 13.2+git20151130.b31588d: + add shared library tests - Update to version 13.2+git20151113.ff9879a: + adjust for tmpfiles fix - Update to version 13.2+git20151110.e8d6260: + fixed two new warnings - Update to version 13.2+git20150520.a374c88: + add tmpfiles.d checks - Update to version 13.2+git20150519.278efdf: + add ghost file checks + print names of failed tests - Update to version 13.2+git20150410.6161e60: + build our own non-PIE binaries, as the distribution slowly gets converted to all PIE binaries (removed rpmlint-pie-fixes.patch) - rpmlint-pie-fixes.patch: build own non-pie binaries to avoid relying on random system binaries. - Update to version 13.2+git20150310.00c9b55: + fix reference output when new bash is used - fix rclink* tests by adding expected systemd macros - add test cases for systemd macros - adjust for new var/run check - use service file - add appdata check - fix reference output for non-ghost* tests - add tests for rc links (bnc#860340) - update reference data to match Factory - generate tarball via service file - update reference data to make checks pass again (bnc#793546)) - omit debug packages from checks - add pam test case - adjust to new badness score for non-position-independent-executable - add logrotate test - add test for buildroot check - suse-filelist-empty is not fatal anymore - add -devel group check - adjust to new license check and add test case - non-ghost-in-var-run is fatal now - fix testsuite - check for false positives in pie test - add polkit test - add an actually readable package description - add check for /var/log/subsys - update ref files - another init script test case - add new initscript warnings - initial package - Add tox user and toxcmd group as standard openSUSE GID and UID - Corrected tpm2-abrmd (bnc#1049694). The D-Bus activation file is named differently than the configuration file. - Add one more deprecated license: + GPL-2.0-with-font-exception. - allow more deprecated licenses to unbreak ring1+2 - add 0001-Always-import-XDG-desktop-files-as-utf8.patch - Allow some deprecated licenses that we would replace on commit (SPDX 2->SPDX 3 conversion) - Update rpmlint-checks to version master: * polkit: make untracked privileges also an error - Update rpmlint-checks to version master: * Support uppercase tag macros used by RPM 4.14 - Update to version 84.87+git20180202.3df4ae7: * Add testcases for MenuXDGCheck.py - refresh for 0001-Improve-XDG-Menu-checks-stability.patch remove xdg-paths-update.diff (merged into other patch) - whitelisting usbauth (bsc#1066877) - Add Development/{Languages,Libraries}/Rust groups as noted in wiki - add missing comma (,) to config file - add user/group _nsd for NSD name server - add 0001-Binariescheck-Check-for-chroot-chdir-on-ARM-PPC.patch - whitelisting kcmsddm (bsc#1065563) - Update to version master: * Fix warnings * Add new rpmlint check for new %{_fillupdir} macro (boo#1069468) * Open paths within the rpm file itself * Fix python warning * BashismCheck: Only check regular files * Rewrite BashismsCheck to actually work - Add rpmlint-slpp-NUM-NUM.patch: Match libFOO<num>-<num> as a valid dependency on a libary. According the openSUSE packaging policy, if the library name ends on a number, we add a dash between the basename (before the .so) and the version after .so. - Update rpmlint-tests to version master: * Add Flake8 travis check * Fix scriptprog invocation * Print the duplicated filenames sorted to be stable accross multiple calls - add 0001-Avoid-calling-close-on-undefined-fd-variable.patch - Description updates. Use the %make_install macro. - update suse-whitelist-opensuse.diff to avoid a false positive - adding connman (bsc#1057697) - add 0001-Accept-python-abi-as-a-valid-versioned-python-depend.patch - refresh 0001-Improve-XDG-Menu-checks-stability.patch (bsc#1063371) - Update to version master: * Python 3.x porting of the ErlangCheck - Update to version master: * Treat strongly versioned libs also as compliant (bsc#723726) * LibraryPolicy: allow %%_licensedir in packages (used by %license) - Hide the noisy warnings - add 0001-Avoid-false-positives-on-is_elf-check.patch (bsc#1057216) add 0007-Validate-Appdata-also-when-appstream-util-is-unavail.patch - Update rpmlint-checks to version master: * Fix false positives for -theme- -> -branding- rename * Stop leaking filedescriptors * Pythonic fixes * Drop CheckAppdata (there is AppDataCheck upstream) * Tighten ELF check * Tiny code formatting cleanup * Tighten the branding policy reporting a bit to make it less confusing - add package groups from https://en.opensuse.org/openSUSE:Package_group_guidelines to enable the groups check - Update rpmlint-checks: * Flake8 fixes * Properly anchor systemd path checks * Python 3.x porting * Add TmpFilesCheck * Flake8 / Stop leaking filedescriptors * Port LibraryPolicyCheck to Python 3.x - Update rpmlint-tests: * Stop leaking filedescriptors * Address various deprecation warnings * Avoid leaking fds and further Python 3.x porting - update to 1.10: * test: Skip fedoradev GPG checks at least for now * test: Refresh fedora* packages on image build * test: Use assertEqual where appropriate, thanks to flake8/hacking * test: Update fedora24 config to fedora26, run it on Travis * Add a new test for tmpfiles.d snippets in the /etc/ tree. * Add new tests for systemd units and udev rules in /etc/ tree * test: Disable hacking for now until it's flake8 3.4+ compatible * test: Set up flake8-bugbear, enable it in fedoradev container * rpmlint: Avoid unused loop control variable * ZipCheck: Add TODO * *: Avoid mutable argument defaults * Be aware of -debugsource packages * rpmdiff: Fix unused variable from previous commit * rpmdiff: Support soft dependencies * BinariesCheck, FilesCheck: Ignore various .build-id dirs * Add python3-devel and rpm-build to fedoradev container to provoke some issues * BinariesCheck: Popen env consistency fix * Pkg.getstatusoutput: Set LC_ALL for all Popens, defaulting to C * rpmlint: Fix checking specfile from stdin * test.sh: Extract rpmlint command to run_rpmlint * Revert "Remove unused spec_lines check_spec argument" * BinariesCheck: Trivial cleanups * travis: Run make install too * FilesCheck: Allow multiple bytecode magic values per Python version * tests: Make output test tools easier to reuse * FilesCheck: hg.python.org -> github.com/python * Pkg: Return vendor and distribution as unicode strings * FilesCheck: Add Python 3.7 bytecode magic value * Pkg.b2s: Add some more test cases * Pkg.b2s: Pass through str as-is on Python 3 * TagsCheck.py: accept SPDX "and" and "or" operators in all-uppercase spelling * rb'foo' is not supported in Python 2, use br'foo' instead * travis: Enable centos6 * Avoid Python 3.6 invalid esc seq warnings, use more raw strings * flake8 fixes * SpecCheck: Detect patches applied with "patch <" and "patch -i" * add /usr/lib/systemd to DEFAULT_HARDCODED_LIB_PATH_EXCEPTIONS (#93) * SpecCheck: Do not demand versioned filename Provides/Obsoletes * FilesCheck: Update Python 3.6 bytecode magic value again * Config: Fix flake8 3.2 / pycodestyle 2.2 errors (closes #82) * *: Fix various low hanging issues flagged by pycodestyle 2.1.0 (#82) * test.sh: Output flake8 --version * rpmdiff.1: update Arturo Borrero Gonzalez email address * FilesCheck: Update Python 3.6 bytecode magic value * Skip chroot-without-chdir check on non-x86_64 * shlib-with-non-pic-code: add text on how to figure files compiled without -fPIC (#79) * *: Move indentation etc settings to .editorconfig * AbstractCheck: Close urllib responses explicitly also on error * tests: Switch Travis tests to Docker * Use importlib to load checks where available * FilesCheck: Use os.devnull * Testing: Avoid ResourceWarning on config read * Run tests with warnings on * Ignore negative returncode after SIGPIPE caused by closing on purpose * Fix last commit * Use default bufsize, move regex compile to common place * BinariesCheck: lower memory requirements, fix chroot/chdir detection * FilesCheck: Avoid crash accessing non-ASCII filenames in some cases * Filter: More non-ASCII print fixing, including in e.g. C locale * SpecCheck: Output spec basename, not tempfile when checking srpm * Cleanups * FilesCheck: Update Python 3.5 and 3.6 bytecode magic values * test: Test for unexpected errors in default and C locales * Remove obsolete LC_ALL setting from Makefile - drop version-control-internal-file.diff, boo1027577-license_tag.patch, add-weak-dependencies.diff: upstream - drop sourced-dirs.diff, fix-shared-library-matching.diff, suse-python-abi-check.diff, add-check-for-tmpfiles-created-at-r.diff: obsolete - drop suse-readd_terminator_in_regex.patch: merged into original patch - add suse-tests-without-badness.patch, 0001-Extend-scm_regex-to-capture-more-SCM-system-files.patch, 0003-Tighten-lib_regex-to-avoid-false-positive-in-python-.patch, 0001-Execute-chroot-tests-also-on-x86-rpms.patch, ignore-readelf-ar-error.diff, remove-ghostfile-checks.diff, fix-diag-sortorder.diff, drop-unicodedata-dep.diff, 0001-Tighten-wrong-script-interpreter-check-to-lower-fals.patch, 0001-Improve-XDG-Menu-checks-stability.patch, 0001-split-wrong-script-interpreter-into-env-script-inter.patch, 0001-Handle-post-scripts-that-contain-non-ascii-character.patch - drop config.in: unused - switch to python 3.x - update to 1.9: * Pkg: Fix magic.descriptor availability check * warn: Define only once, with print_function * FilesCheck: Check for *.gir in devel, *.typelib in non-devel, fixes #74 * FilesCheck: Improve devel-file-in-non-devel-package description * flake8: Ignore H105 * Makefile: Remove generate-isocodes dep from __isocodes__ * __isocodes__: Regenerate * generate-isocodes: Switch to JSON source files (#72) * test.sh: Check man pages for warnings * Delete dead if-block * Filter: Line wrap cleanup * Filter: Use sys.version_info to check Python version * Fix octal string literals * Solve exceptions on printing str (Fixes #61) * tests: Add autofs binary rpm for testing non-ASCII output issues * test: Add some test packages containing non-UTF-8 filenames * BinariesCheck: avoid false chroot w/o chdir when objdump fails * flake8 fixes * rpmdiff: Import site only if needed * Testing: Add and use default for path to tests * FilesCheck: Update Python 3.6 bytecode magic value * FilesCheck: Fix regression in finding shebangs without arguments * Ignore .cache dir * Clean up Python < 2.6 cruft * Add hacking flake8 to Travis and ignores * flake8 fixes * Use new style classes * Run flake8 on rpmdiff and rpmlint too * Handle more file open/close with "with" * Exception handling cleanups * FilesCheck: Look for shebang only at start of file * travis: python3-rpm doesn't exist even for Trusty, so can't test with 3.4 * travis: Switch to Ubuntu Trusty, test with Python 2.7 and 3.4 * Use Travis apt addon for whitelisted packages * Test import order * Sort imports per PEP8, Google Python Style Guide * Add Python 3.6 magic value * Fix resolving Python source from 3.5 *.opt-[12].pyc * Move most Emacs settings to .dir-locals.el * Add %python2_sitearch and %python3_sitearch to private SO paths * Prevent empty paths from entering private SO paths * remove files-attr-not-set check * Expand postin/postun once per pkg instead once per file * Install rpm in travis for signature check * Avoid running some regexps * Run flake8 in test suite * flake8 fixes * make test suite fail on more errors * Comment update * Note and test libmagic >= 5.05 dep * Fix magic processing for Python 3 * Mimic magic closer for symbolic links * Workaround slowness due to python-magic bug * Shortcut file magic, derive from file mode * Spelling fix * Unbreak create_*regex_call now that lines are shortened by call_regex * Drop unnecessary symbol_table_regex * Avoid false function call vs definition positives, thanks to Stefan Bruens * pep8 fixes * Add some pep8 settings * Split parsing of readelf output into header and symbols part * Skip checks for problematic function calls if common prefix does not match * Use shlex.quote for better shell escaping where available * TODO update * Don't limit build badge to master branch * Convert README to markdown * Travis: install rpm2cpio * +TODO * Travis: Use Python 2.7 and system site packages * Travis: try pytest from pip instead of apt-get * Initial travis setup * Include interpreter arguments in output messages for filtering control * Flag /usr/bin/env as a wrong interpreter - drop rpmlint-pkg-quoting.diff, suse-g-ir-chech.diff, remove-expand-macros.diff, remove-files-attr-not-set-check.diff, postin-speedup.diff, binaryinfo-speedup.diff, 0001-Fix-resolving-Python-source-from-3.5-.opt-12.pyc.patch, issue_68_BinariesCheck_lower_memory-1.patch, issue_68_BinariesCheck_lower_memory-2.patch, issue_68_BinariesCheck_lower_memory-3.patch, issue_68_BinariesCheck_lower_memory-4.patch, BinariesCheck_fix_chroot_check_on_non_x86.patch: either upstreamed as is or slightly different - drop suse-sysv-init-checks.diff, 0001-Avoid-messing-with-the-error-encoding-Fixes-61.patch, suse-filesystem.diff, script-interpreter-only-for-exec-sc.diff: obsolete - drop update_git.sh related stuff: this is obsolete, patches are either supposed to be upstreamed or handled via quilt - add suse-skip-macro-expansion.diff: rename from remove-expand-macros.diff - Update to version master: * Ignore trailing whitespace in permission files (bsc#1060738) - Add group 'singularity' for package singularity (See network:cluster/singularity) (FATE#323048). - Add dehydrated user & group for dehydrated, a letsencrypt client FATE#323377 - Adding fwupd (bsc#932807) - add coroqnetd for corosync-qnetd to rpmlint - Adding NetworkManager-l2tp (bsc#846337) - Adding pam_script (bsc#1039848) - Adding nfs-ganesha (bsc#997880) - Added tpm2-abrmd (bnc#1049694) - Add user mednafen for mednafen network play server - Adding pam_dbus (bsc#1039709) - rpmlint-all-pie.patch: for non-PIE built binaries emit a warning to suggest build them as PIE. - std-user and std-group 'bitcoin' added for building correct bitcoin daemon - Add BinariesCheck_fix_chroot_check_on_non_x86.patch Check for correct invocation of chroot was only implemented for x86 - std-user and std-group 'xymon', added for building correct xymon client - whitelisting openqa (bsc#1039290) - add 'prometheus' and 'grafana' standard users and groups - whitelisting switchroo-control (bsc#1034309) - whitelisting backintime (bsc#1007723, bsc#1032717) - whitelisting thunderbolt (bsc#1033554) - Update to version master: * remote unused/outdated checks - Update to version 84.87+git20170418.092177d: * Remove initscript related tests, systemd FTW! - Adding kwalletmanager5 (bsc#1033296) - Adding os-autoinst (bsc#1032649) - remove CheckKDE4Deps, CheckInitScripts - actually enable CheckSysVinitOnSystemd - Add logstash to StandardGroups and StandardUsers. - rpmlint-checks: * Check for old SysVinit scripts and the usage of insserv (FATE#322953) * Prevent a false-positive in systemd - fix boo#1027577 patch boo1027577-license_tag.patch - rename user/group sks to _sks following https://github.com/LinuxStandardBase/lsb/pull/21 - adding blueman (bsc#987141) - Add gdm to StandardGroups. - Add polkitd to StandardUsers. - suse-spdx-license-exceptions.patch: removed fuzziness from patch. - issue_68_BinariesCheck_lower_memory.patch: split into seperate patches issue_68_BinariesCheck_lower_memory-1.patch issue_68_BinariesCheck_lower_memory-2.patch issue_68_BinariesCheck_lower_memory-3.patch issue_68_BinariesCheck_lower_memory-4.patch and unfuzzed patch number 3. - Whitelisting rebootmgr (bsc#1019644) - Whitelisting powerdevil discretegpuhelper (bsc#1019748) - Adding org.freedesktop.resolve1.conf (bsc#917781) - add suse-readd_terminator_in_regex.patch Fixes bad detection of dependencies for devel packages - update suse-obsolete-version check (bsc#743981) - whitelisting pam_slurm (bsc#1007053) - whitelisting pam_gdm (bsc#1004346) - config: whitelist flatpak dbus service/config (bsc#984817) - adding sysprof DBUS service (bsc#996111) - Adding sks (Synchronizing Key Server) to known user/group - rpmlint-checks: * Make checks python3 compatible * Fix update-alternatives check when it's quoted - Update some checks to work on both Python 2 and 3 - rpmlint-checks: * Fix typo in BrandingPolicyCheck.py - Add issue_68_BinariesCheck_lower_memory.patch Fixes out-of-memory errors on 32bit systems (bsc#969732) - Adding prosody to known user/group - add 0001-Fix-resolving-Python-source-from-3.5-.opt-12.pyc.patch: Fixes FilesCheck to resolve correctly the python source file from pyc files following PEP0488 (like *.{tag}.opt-[12].pyc). (bsc#982076) - suse-spdx-license-exceptions.patch, suse-sysv-init-checks.diff: adjust to match rpmlint-tests again - update link to list of valid licenses - temporary approval for tcmu-runner dbus service (bsc#978903) - add omit_BUILDROOT_from_pyo_files.patch (boo#978306) - add suse-spdx-license-exceptions.patch (bsc#973404) - whitelisting openattic (bsc#972478) - Updated config file to add user chrony and group chrony (Fate#319508) - whitelist rabbitmq user and group - Fix boo#970170: rpmlint no longer detects gethostbyname calls, also detect gethostbyname{,2}{,_r}, gethostbyaddr{,_r} * update suse-binariescheck.diff * rpmlint-check-gethostbyname.patch - add 0001-Avoid-messing-with-the-error-encoding-Fixes-61.patch (bsc#967556) - fix requires - add 'guixbuild' as standard group - don't require %config for bash completion scripts in /etc - whitelist systemd-importd (bnc#964935) - enable tests during building - add postin-speedup.diff, binaryinfo-speedup.diff - whitelist iio-sensor-proxy (bsc#939191) - whitelist drbdmanage DBUS (bsc#956811) - add wireshark group [bsc#957624] - adding thermald DBUS service (bsc#954771) - fix shared library matching (fix-shared-library-matching.diff) - rpmlint 1.8 update * python 3 fixes * Add support for file triggers * Mechanism to black list certain C calls * new error: non-devel-file-in-devel-package * appdata check configurable * project moved to github * Patches dropped: avoid-mismatched-libregex.diff filename-non-utf8-exception.diff fix-ghost-file-handling.diff save-content-to-an-array.diff fix-TmpFilesCheck-pattern-match.diff move-ghost-file-check-to-TmpFilesCh.diff - fix TmpFilesCheck not finding pattern in the full script (fix-TmpFilesCheck-pattern-match.diff) - whitelisting cinnamon settings daemon (bsc#951830) - Speedup CheckBuildDate check - add _service file snippet for rpmlint-checks and regenerate from git - Added salt user and group (bnc#939831) - Added teamd DBUS config (bnc#941993) - Add shibd user and group [fate#318304] - Add vnc user and group. (fate#318936) - add a whitespace line as %autosetup seems broken. - Add mysql group to the known groups - skip files handled by tmpfile mechnism in regular ghost file check (move-ghost-file-check-to-TmpFilesCh.diff) - fix update_git.sh - make sure tmpfiles are listed in %files (add-check-for-tmpfiles-created-at-r.diff) - don't complain about missingok ghost files (fix-ghost-file-handling.diff) - remove obsolete check for %defattr in spec files (remove-files-attr-not-set-check.diff) - added standard user and group ceph (bnc#928492) - fixing some .conf/.service suffixes - adding realmd DBUS service (bnc#916766) - update save-content-to-an-array.diff with upstream version - new versioin 1.6 - add script update_git.sh based on qemu's to simplify importing a patch series from git after rebasing. * Patches dropped: 0001-Python-3-compatibility-tweaks.patch (upstream) 0001-Set-Python-3.4-magic-number-to-3310.patch (upstream) add-scoring-support.diff (different upstream solution) check-buildroot-during-install.diff (need to fix no-cleaning-of-buildroot check upstream) fix-versioned-prereq.diff (was disabled, not sure what it's useful for) ignore-non-readable-in-etc.diff (filtered anyways) locale-support.diff (drop) locale-update.diff (different upstream solution now) more-verbose-lsb-check.diff (drop) perl-versioned-rpath-deps.diff (upstream) rpmlint-1.5-disallow-var-run-and-var-lock.diff (upstream) rpmlint-1.5-Fix-setgroups-error-name.diff (upstream) rpmlint-decode-fix.diff (different upstream solution) rpmlint-fix-unexpanded-macros-for-array-values.patch (different upstream solution) stricter-tags-check.diff (merged in weak deps and check-for-self-provides.diff) suppress-for-perl-python.diff (use filter instead) suse-binary-info-compile-opts.diff (drop) suse-changelog.patch (change config instead) suse-mono-deps-checks.diff (useful?) suse-required-lsb-tags.diff (different upstream solution) verify-buildrequires.diff (very build system specific, drop) xdg-check-exception.diff (upstream) * renamed patches: script-interpreter-only-for-exec-scripts.diff -> script-interpreter-only-for-exec-sc.diff confusing-invalid-spec-name.patch -> confusing-invalid-spec-name.diff suse-manpages-for-rc-scripts.patch -> suse-manpages-for-rc-scripts.diff sysv5-init-checks.diff -> suse-sysv-init-checks.diff * added patches: check-for-self-provides.diff save-content-to-an-array.diff - use the correct networkd dbus service names. (bnc#918799) - added systemd network DBUS service (bnc#918799) - added storaged DBUS service (bnc#915769) - add standard users and groups pcp and pcpqa for pcp - whitelist sddm (boo#897788) - added firewalld dbus service (bnc#907625) - added iouyap group (bnc#904060) - added standard user and group davfs2 (bnc#907662, FATE#318116) - Added standard user and group crowbar for crowbar systemmanagement - added standard user and group siproxd for the siproxd proxy - added standard user iodined for the iodine DNS tunnel daemon - FATE#314409. Add libstoragemgmt user/group. - Add sddm user/group - Added standard user/group polipo - Add user/group unbound for unbound caching dns server - adjust initscript check to match new systemctl based %restart_on_update resp %stop_on_removal - Add the groups systemd-journal, systemd-journal-gateway, and tape as required by systemd - Add the user systemd-journal-gateway as required by systemd - updated rpmlint-checks-master.tar.gz to include CheckSystemdInstall.py - allow org.kde.kf5auth.conf after adjustment of race condition (bnc#864716) - added user and group sensu required for sensu server, client - allow user and group ddclient for the ddclient users (bnc#881520) - allow user bitlbee for the bitlbee irc server. - enable oFono DBUS for SLE12 (bnc#862354) - enable org.selinux.service and org.selinux.conf of policycoreutils (pending more review) bnc#878631 - add 0001-Set-Python-3.4-magic-number-to-3310.patch (bnc#876470) - dd filter expections for filesystem package - disallow /var/run and /var/lock (rpmlint-1.5-disallow-var-run-and-var-lock.diff) - adding ovirtagent standard user and standard group names (uid/gid 175) - adding baloo DBUS service file (missing in last request) (bnc#866131) - adding baloo DBUS config, formerly nepomuk (bnc#866131) - allow /run (bnc#870190) - update KMPPolicycheck - added group 'squid' for squid - added user, group 'boinc' for boinc-client - allow org.freedesktop.GeoClue2.Agent.conf (bnc#862216) - add minimal check to verify appdata.xml files are parsable XML - added patches: * rpmlint-fix-unexpanded-macros-for-array-values.patch - fix _unexpanded_macros for array values - rip out all decode in an attempt to make it work - modified patches: * rpmlint-decode-fix.diff - added paches: * rpmlint-decode-fix.diff - Fix decode from UTF-8 string in Python 2 - usr-arch.diff: update usr_arch_share_regex - adapt to new rpm weak dependency tags - added patches: * 0001-Python-3-compatibility-tweaks.patch - Change openstack- related users to non-prefixed variants, as they get renamed with the switch to Icehouse - whitelisting networkmanager-openswan (bnc#808549) - remove suse-rclink-check.diff and implement as separate check for systemd units instead (bnc#860340). - Added group 'ts-shell' for terminal server - Whitelisting NFC neard DBUS service (bnc#837978) - Add user and group 'arangodb' for ArangoDB database server - Whitelisting kwallet DBUS service (bnc#849739) - Whitelisting bluez DBUS service (bnc#768062) - Adding org.selinux DBUS service (bnc#848550) - Add 'elasticsearch' to standard users and groups * package: elasticsearch * Summary: Open Source, Distributed, RESTful Search Engine * URL: http://www.elasticsearch.org * License: Apache-2.0 * systemd elasticsearch.service needs LimitNOFILE=65535 LimitMEMLOCK=infinity for user and group elasticsearch - Whitelisting com.redhat.tuned DBUS service (bnc#787379) - Sync checks with git (FATE#316521) - whitelist second iteration of wicked dbus service names (bnc#783932) - blacklist old systemd/udev directories (bnc#816467) - remove checking for groups (bnc#767551) - ignore icon size mismatches on animated icons (bnc#480664) - update obsolete/invalid suse version check - whitelisted mate DBUS Service (bnc#831404) - add requirement for ErlangCheck.py (pull request #2) - whitelisted GeoClue2 DBUS Service (bnc#838360) - allow pam_mate_keyring (same to gnome keyring) (bnc#831404) - update rpmlint-checks from git - add suse-ignore-specfile-errors.diff: ignore specfile-errors - add xdg-check-exception.diff: handle xdg menu files without exec entry (bnc#833384) - allow pam_snapper after audit (bnc#815383) - follow /usr move for the /bin/ binaries in pie.config. - fix setgroups error name, patch from upstream git: rpmlint-1.5-Fix-setgroups-error-name.diff - allow systemd machined service as-is (bnc#828207) - Allow current wicked DBUS services (bnc#783932) - allow nepomuk helpers temporary without full audit (bnc#825262) - drop outdated Update-alternatives check (bnc#826993) - add basic new update-alternatives check - Add 'chef' to standard users and groups - allowed kcm helper for lightdm-kde-greeter (bnc#794705) - allow fprintd DBUS services (bnc#792095) - Add group 'locate' for mlocate package - update to 1.5: * New Homepage * Plenty of new checks - add compressed-backup-regex.diff - remove python3_magic_number_fix.diff - Add user and group 'svn' for svnserve in package subversion - add new ModemManager interface / service (bnc#798273) - add suse-filter-more-verbose.diff: * make it more obvious which rpmlintrc causes an exception (bnc#801192) - allow nm-iodine-service.conf DBUS service (bnc#781071) - Add user and group 'empd' for erlang - Add user 'fonehome' and group 'fonehome' - Add Kolab users + groups * kolab (Kolab System Account / management) * kolab-n (Kolab System Account (N) / non-privileged) * kolab-r (Kolab System Account (R) / restricted) - fix incorrect branding require warnings - update check for %run_permissions - Add suse-manpages-for-rc-scripts.patch: Don't complain about missing man-pages for rc-scripts - Add colord uid and gid. - Add additional OpenStack users/groups - Added a patch (python3_magic_number_fix.diff) to update the magic number for python 3 (patch taken from upstream). - whitelist org.freedesktop.AutoMount.conf (bnc#782691), that wants to talk to udisks - add libopenal1 to legacy exceptions again. Got lost after the packaging changes apparently. - allow snapper dbus service after audit (bnc#759391) - no longer allow semicolon in licenses - Remove check for /var/lock and /var/run since it's in upstream rpmlint already. - Add README.packaging.txt to explain packaging of file rpmlint-checks-$VERSION.tar.gz - Package all *py files into rpmlint-checks tarball - Add _service file to update rpmlint-checks tarball - Add /etc/systemd.d, /etc/modules-load.d and /etc/tmpfiles.d to the blacklist, only users should write here. - Blacklist the directories used by systemd. - Remove SuSEconfig directories (update patch suse-filesystem.diff) - Add warnings about files on tmpfs in /var/lock or /var/run. - restore LibraryPolicy from git - fix one more case of scripts progs changing types - update to 1.4: * rpmdiff: Teach rpmdiff about pretrans and posttrans * SpecCheck.py: merge patch from #97, using BuildArch with something else than Noarch is likely a error and causing issues. * FilesCheck.py: Add Python 3.3 magic number * FilesCheck.py, InitScriptCheck.py, MenuCheck.py, Pkg.py, PostCheck.py: Prepare for rpm-python possibly returning script progs as arrays. - added icinga users and groups - remove python naming check (bnc#768247) - add libopenal1 to legacy exceptions. It's a special case since the ABI for openal is defined in a standard and there can be multiple imlementations of the standard. Therefore it's necessary to have some kind of prefix or suffix for packages that contain libopenal1 - add bluez dbus autolaunch stub (bnc#768062) - Add several OpenStack users/groups - Cleanup list of SuSEconfig scripts - remove non-existant entries. - remove tdb tools binaries, not needed for PIE (bnc#765476) - add cdemu-deamon to dbus white list (bnc#764063) - add check for pam modules (fate#313077) - add texlive.texlive to whitelist (bnc#762144) - add 'mktex' group as used by texlive - fix false positives for swp matching - better deal with spaces in logrotate config - add colord-sane dbus service to whitelist (bnc#752518) - fix parsing of update-alternatives and clarify info message - block .swp files as well (they are usually vi(m) backup files) - add udisks2 to dbus whitelist (bnc#742751) - add smb4k to dbus whitelist (bnc#749065) - ignore fixed dependencies on config() - add logrotate check (bnc#677335) - NetworkManager.conf was renamed to org.freedesktop.NetworkManager.conf (bnc#747780) - suse-filelist-empty is meant as warning only - add standard group and user znc (server:irc/znc) - added standard user and group "puppet" - reenable libtool wrapper check - unbreak config afer DesktopTranslationCheck was removed - create the valid licenses from list tracked by SUSE legal (dumped into obs-service_format_spec_file, so use that one as buildrequire) - added: standard group 'tor' - added: standard user 'tor' - the untranslated-desktop-file check is obsolete, in factory all .desktop files are trimmed and marked - in all other projects (including devel projects) %suse_update_desktop_file won't touch the files for translation only - fix invalid-suse-version-chec (bnc#732671) - fix devel-package-with-non-devel-group check (bnc#732897) - enable license check - add NetworkManager-openconnect to dbus whitelist (bnc#732915) - add global filter for SuSEfirewall2's sysconfig file as setBadness in the package is not allowed - added: standard group 'citadel' - added: standard user 'citadel' - changed: addDetails('non-standard-uid', ... branch paket ...', 'non-standard-uid', ... branch paket ...') - add vacation/vacation to valid group/user list (needed for PostfixAdmin's vacation.pl script) - avoid warning with shlib policy on libtool - check for versioned dependency on python(abi) (bnc#659068) - fix stripping of unknown polkit suffixes (bnc#711485) - update to 1.3: * Add --rawout option * Warn about non-ghost files in /var/run and /var/lock * Fix setting message type for reasons with badness threshold defined * Use "declare -F" instead of "type" to check if a bash function exists. - add jenkins/jenkins to valid group/user list - Spelling fixes - add org.kde.kalarmrtcwake to dbus whitelist (bnc#707723) - only consider executable ELF files for non-position-independent-executable check - add more users and groups from Factory - add lightdm user and group (bnc#708205) - add org.freedesktop.DisplayManager.conf (bnc#708205) - remove obsolete knotification-requires check - bump obsolete openSUSE version to 11.2 - add more systemd dbus services to whitelist (bnc#705677) - CheckSUIDPermissions: use non-position-independent-executable as accepted upstream - remove some false positives of the no-dependency-on checker - fix library policy check complaining about non-ELF files (bnc#700067) - add colord to dbus whitelist (bnc#698250) - CheckPolkitPrivs.py: use different tag for non-fatal issues - CheckBuildDate.py: print either file-contains-current-date or file-contains-current-date but not both - add check for /var/lock/subsys usage - disable source-or-patch-not-compressed. Not useful anymore. - add synche-connector (bnc#683956) to dbus whitelist - update system-config-printer (bnc#694640) in dbus whiteliste - update legacy filter in shlib policy checker - new version 1.2 * Check outdated or misspelled FSF addresses in text files. - update rpmlint-pie.diff and suse-file-var-run.diff with upstream accepted variant - don't filter non-standard-gid anymore - add dir-or-file-in-var-lock check - remove 'nobody' from standard users - add not-a-position-independent-executable check - add radvd user to known list - add org.freedesktop.hostname1 to dbus whitelist (641924) - add account services (bnc#676638) - another try to fix InitScriptCheck.py (bnc#690961) - implement setFilterException() - rediff noarch-lib64.diff and enable it again (bnc#663885) - make error description more clearn (bnc#686328) - fix abort in BinariesCheck - fix sysv5-init-check.diff for real - fix sysv5-init-check.diff to not throw exception - fix sysv5-init-check.diff to check for preun, not postin - update CheckInitScripts.py: * add check for runlevel 4 * clarify boot.* error * accept $null in start/stop tags - also check for %run_permissions if package doesn't actually need permissions handling - merge suse-binarieschecks.diff and suse-hide-unstripped-outside-build.diff and fix the former - ignore dir-or-file-in-usr-local as it's handled by CheckFilelist.py - non-standard-dir-in-usr dito - add urfkill (bnc#688328)) - update to 1.1: - remove upstreamed patches * FilesCheck.py: Don't crash if a file cannot be opened * FilesCheck.py: Update expected Python 3.2 bytecode magic value * TagsCheck.py: Improve no-description-tag info message * TagsCheck.py: Improve changelog related info messages. * Pkg.py: Treat 'Unspecified' as a valid Group * TagsCheck.py: Add future and overflow checks for changelog * FilesCheck.py: Don't emit spurious executable perm warnings for docs with shebangs * FilesCheck.py: Don't read "head" of files for in each test * SpecCheck.py: Check source and patch file sizes and MD5 hashes * Pkg.py: Fix traceback when stringifying epoch-only versions * TagsCheck.py: Fix TypeError when outputting * Pkg.py: Make file capabilities available in PkgFile - add check for missing rcXXX symlinks (FATE#310641) - add NetworkManager to dbus whitelist (bnc#681128) - add wpa_supplicant to dbus whitelist (bnc#681116) - fix typo (bnc#675329) - add better help message for non-standard-uid - add kde backlight helper to whitelist (bnc#672145) - add webyast to dbus whitelist (bnc#660981) - add hal dbus system activation file too - add mumble-server to dbus white list (bnc#660784) - add NetworkManager-strongswan to dbus white list (bnc#656222) - Fix message for no-changelogname-tag: This is also caused by missing changes file. Original message posed a contradiction, in case the %changelog section header was there. - remove filter for no-url-tag (bnc#642588) - clarify wording for run_ldconfig check (bnc#637187) - skip desktop files in /etc (bnc#604283) - fix exception on postgresql build - also check ghost files for permission violations - add check for %set_permissions - modify match in CheckSUIDPermissions to work with new macros - allow info messages even if badness scoring is used - change Documentation/SuSE to /SUSE (bnc#618716) - whitelist "openSUSE" at start of Summary (bnc#618716) - remove invocations of expandMacro() - fix another exception in branding policy check (bnc#652628) - enable suse-hide-unstripped-outside-build.diff again - check for file system capabilities - check for %verifyscript and %run_permissions - update to 1.0: * add support for PEP 3147 when handling python bytecode * various doc improvements - remove debug logging - fix BrandingPolicy.py - fix supplements parsing (bnc#648404) - add build time check (bnc#635351) - init script check logic - add all currently known dbus services as legacy exception - add configurable whitelist to CheckDBUSServices.py - fix regression in suse-binariescheck.diff - add check for gnome and desktop related macros - Added lxdm as a valid group and user - update to 0.99: * Add Python 2.7 magic number ( https://bugzilla.redhat.com/623607, Nils Philippsen) - update to 0.98: * Pkg.py, test/test.Pkg.py: Fix self-obsoletion bug with Provides containing Epoch. * Pkg.py: Don't stringify None Epoch to 'None' string in compareEVR(). * Pkg.py: Sync rangeCompare() with yum 3.2.27. * TagsCheck.py: Reduce some spell check noise. * rpmlint: Fix handling of arguments containing spaces. * DocFilesCheck.py: Bypass doc file check earlier if package has no doc files. - Add suse-g-ir-chech.diff: *.gir belong in -devel packages. - Update suse-version.diff: last non-obsolete version of openSUSE is 11.1, and latest valid version of openSUSE is 11.4. - fix printWarning error in CheckBashisms - add confusing-invalid-spec-name.patch - add BashismsCheck - add Development/Debug group (bnc#612044) - additionally look at the BUILD_DEBUG variable to determine whether a warning should be printed. Needs an updated 'build' script. - don't print unstripped binary warning when used with build script (bnc#618004) - added "System/GUI/LXDE" as a valid rpmgroup - don't allow perl vendorarch in noarch packages - check for gethostbyname calls (bnc#506945) - fix branding check (bnc#579556) - fix exception in interpreter check - restrict shlib-fixed-dependency to shlib-policy packages - allow files in /tmp to be listed as %ghost - tighten pkg-config check - check for missing xinetd.d (bnc#436326) - check for files in /var/run (fate#303793) - check for live update problems (bnc#477649) - rediff and enable the shared lib dependency check fix - Add some missing rpm groups and sort list. - tighten the interpreter check (bnc#574650) - suppress warnings about cron.d symlinks (bnc#591431) - workaround unicode error exceptions on non-utf8 filenames - rediff some suse specific patches - fix buildroot detection (bnc#584952) - update to 0.95: * Skip ghost files in files checks, https://bugzilla.redhat.com/570086 * Work around Python's ASCII non-TTY stdout and our non-ASCII output. * Omit spell check warnings for capitalized words that do not start a sentence. * Wrap bunch of long lines, tune comments and info messages. * Require rpm-python >= 4.4.2.2 for expandMacro() in r1729. * do not execute check if the network test are marked as disabled, and simplify the logic * do not expand the format of the filename format, (patch from Per Oyvind Karlsten ) - update to 0.94: - rpm 4.8.0 support - better python bytecode checks - improved LSB/taglist - various fixes/patches upstreamed - update and enable CheckPolkitPrivs - update suse version check (add 11.2, drop 10.3) - fix usr-arch.diff - require python-magic as it's needed by some checks - suppress depmod warnings (bnc#456048) - add some missing groups - disable badness for group check until we know the impact - add a config file for standard RPM groups - fixed bnc#566018 - no-ghost-alternative-file check makes no sense - fixed CheckAlternativesGhostFiles test, renamed the warnings to generic-name-not-in-filelist, generic-name-not-marked-as-ghost - enable parallel build - update to 0.92: * various fixes and python 3 compatibility added * new checks for python compiled files - tighten the regex for libraries (bnc#544906) - fix exceptions in BinaryInfo - update to 0.90: * Makefile: 0.90. * rpmdiff: Add missing magic coding comment (https://bugzilla.redhat.com/508683, Michal Nowak). * TagsCheck.py: Fix incorrect info in self-obsoletion message. * FilesCheck.py: Output interpreter in non-executable-script warning, remove quotes from wrong-script-interpreter one. * Pkg.py: Remove stale comments. * TagsCheck.py: Code cleanup, NFC. * TagsCheck.py: improve percent-in-* message details. * TagsCheck.py: Remove obsolete-on-name check (superseded by self-obsoletion). * TagsCheck.py: Add check for self-obsoletion cases, https://bugzilla.redhat.com/461610 * Pkg.py: Borrow various utilities from yum's rpmUtils.miscutils. * Makefile, rpmUtils: Revert previous commit. * Makefile, rpmUtils, rpmUtils/miscutils.py, rpmUtils/transaction.py: Borrow rpmUtils/{miscutils,transaction}.py from yum. * rpmdiff: Improve dependency formatting. * rpmdiff: Take Epoch into account in self-provides filtering. * Pkg.py: Improve legacy prereq tracking with new rpm versions. * BinariesCheck.py: Don't output missing-PT_GNU_STACK-section messages if readelf failed. * FilesCheck.py: Add check for debuginfo packages without sources. * FilesCheck.py: Allow more common files to be non-readable (https://bugzilla.redhat.com/226412). * FilesCheck.py: Revert relative symlink target normalization back to more aggressive. * BinariesCheck.py, Config.py, ConfigCheck.py, FHSCheck.py, FilesCheck.py, I18NCheck.py, MenuCheck.py, Pkg.py, PostCheck.py, TagsCheck.py, rpmdiff: Code cleanups. * FilesCheck.py: Do not check existence of relative link targets on the filesystem for consistency with absolute link target checks, improve dangling-*symlink info messages. * FilesCheck.py, Pkg.py: Be a bit stricter when normalizing link targets, do it earlier. * FilesCheck.py, Pkg.py: Improve link target normalization in symlink checks. - filter cross-directory-hard-link as it is duplicate to a suse check - filter buildroot related checks (bnc#536594) - Added CheckAlternativesGhostFiles.py - see bnc#534451 comment#17 - disable bogus patch to InitScriptCheck.py. Causes failures and needs to be reworked - fix and add weak dependencies patch again to make some suse checks work - fix CheckPkgConfig.py to work with rpmlint 0.87 - refresh some patches to remove fuzz - BuildIgnore rpmlint-mini as it is currently broken - don't import pprint in CheckSUIDPermissions.py - remove /selinux again. No package except 'filesystem' is supposed to include that. - add filter for FHS violation of skelcd type packages - fix some more suse patches - added /selinux to allowed prefixes in CheckFilelist.py - add cups to dbus whitelist (bnc#515977) - fix suse checks for 0.87 - fix syntax error in suse-hide-unstripped-outside-build.diff - update to 0.87: * remove old rpm support * improved performance and compat with python 2.6 * many pylint/pychecker code fixes - fix library policy checker being inactive due to API change - update to 0.85: * various new checks and fixes to existing checks * remove upstreamed patches - use separate error for sysconfig stuff (bnc#470965) - move RCS detection to FilesCheck.py - remove explicit requires on python, already handled by %py_requires - remove check for /usr/share/info/dir from CheckFilelist.py, already in upstream FilesCheck.py - fix exception for texinfo - improve information hint for perl blacklisted paths - fix language list for sr (bnc#471254) - add exception for nfs-utils, texinfo and perl - allow backup files if they are ghost files - add check for DBus Policy problems - CheckFilelist: optimize FHS check to only complain about wrong directories rather than hundreds of individual files - CheckFilelist: add exceptions for kde and pam - CheckPolkitPrivs: use info instead of warning to avoid badness assignment - prefix dbus check with suse- - add filelist check - add whitelist entry for libieee1284 - add a check for PolicyKit privileges (disabled atm) - add check for DBUS services - update suse version check (add 11.1, drop 10.2) - check library packages more strict (bnc#456053) - ignore shared objects in a versioned non-std subdir (bnc#435588) - only test for regular files in ChkPkgConfig check - add check for otherproviders() in branding packages - correct kde4 related dependency checkers to not give false advises - check for wrong-arch references in pkgconfig files (graphviz) - lower false positives of untranslated-desktop files check - support for checking .comment.SUSE.OPTs. real check has been left out for now - generate a different error for directories with setuid/setgid bit - add check for /etc/permissions violations - update to 0.84: * remove upstreamed patches * no significant changes - add description for useless-explicit-requires (bnc#405887) - rediff patch - Fix name of completions file. - be more verbose in the lsb init script checks - change mandatory-lsb-keyword check to be in line with insserv - remove python-base in the warning as it is confusing. the warning itself is still valid though - fix config typo - enable non-conffile-in-etc warning (bnc#409643) - fix shlib policy dependency warnings (bnc#405280) - update cron dependency checker (bnc#400921) - No PT_GNU_STACK on ia64 and ppc64. - also read /etc/rpmlint/factory.config - fix typo in suse-version check - update to 0.83: * removed upstreamed patches * a couple of new checks, bugfixes - fix exception in tags check (bnc#399655) - add a warning for self-conflicts - fix naming policy check for lib64 based archs (bnc#392524) - fix typo in kde4 deps check - fix typo in branding policy check - readd cron check - fix kmp check after the policy change - add checker for correct deps of kde4 packages - add check for mono requirements (BNC#381979) - improve branding policy checks - add support for weak/reverse dependencies - add checks for percent's in weak/reverse dependencies - add checks for incorrect kmp dependencies (bnc384084#) - fix exception on testing for unversioned branding provides - suppress script warnings about /var/adm/fillup-templates (bnc#379601) - add start of a branding policy checker - Fix some regex in BinariesCheck - Add symtab and debuginfo tests for static libs - autogenerate users/groups from autobuild (bnc#374601) - suppress non-devel buildrequire dependency for tcl - fix licenses symlink handling (bnc#370364) - allow /usr/share/locale/be@latin (bnc#370418) - fix some false positives - add check for a really short description - be less restrictive in pkgconfig checks - suppress tag-not-utf8 warnings for now - add check for %run_ldconfig - improve check output - improved tags check - cleanups - reduce package-size-check false positives - add another postscript check - fix typo in sorting routine - updated spec file name-guessing to catch more cases - updated dot-in-identifier check - suppression updates - update to 0.82: * some patches were upstreamed * small bugfixes - rework fix for bnc#354177 to consider python bytecode arch-independent again, but catch it in arch-dependent paths - fix some minor buglets - consider python bytecode to not be arch independent (bnc#354177) - improve postcheck to ignore unexpanded macros in comments (bnc#355306) - check binary rpath for perl version dependency (bnc#355053) - add check for unversioned self-provides - update suse checks from SVN - check for dot's in dependencies - forbidden by autobuild policy - improve documentation - check for libtool wrapper scripts being packaged (#353240) - reapply patch-detection fix - add suppression for libzypp - fix wrong indentation in verify-buildrequires - bugfixes in check-mkdir-buildroot - bugfix in percent-post check - check for buildroot in %post scriptlets - remove abused legacy shared lib policy exceptions - suppression update - fix suppression for internal packages - add suppression for non-remote_fs on boot.* (#340588) - add warning for non-utf8 filenames (#343216) - more prereq checks - suppression update - add more prereq checks - fix prereq parsing code (#336712) - update the obsolete-suse-version check to include 10.0 and 11.0 - fix prereq checks to check for coreutils - reporting format change-back got rejected by upstream, so adopt other changes to deal with it - change back reporting format to list the severity first - add more legacy suppressions found by library policy fix - also check for Library Policy errors in /opt/kde3/lib - update to 0.81: * various new checks, some bugfixes * many patches upstreamed * rediffed all other patches - NOTE: output format has changed from W: package check-id .. to package.<arch>: W: check-id .. - another round of updates - library policy legacy suppression update - added 'mysql' to the list of standard users and groups - removed 'jonas' (dropped package) from that list - update library policy checker for libgcc and libcaca - check for /usr/share/gnome/help in documentation checks (#310134) - add check for non-whitelisted filedependencies (#326803) - fix hardlink check for /bin - Fix last change. - fix off-by-one in hardlink check - fix exception in DuplicatesCheck - fix buildroot false positive - check for hardlinks across partitions (#304167) - improve mkdir-installroot check - fix rpmlint package regarding check above ;) - improved the non-devel-buildrequires check - added some default filters for non-devel-buildrequires and unneccessary-buildrequires - check for wrong cleaning of buildroot in %install (#300232) - check for obscure and unneccessary buildrequires - add an icon size check (#163547) - refine the $remote_fs dependency check - suppression update - improved macro checks - documentation update - detect makefile junk (#217472) - suppression update - fix a couple of false positives - fix package-with-huge-docs check to not complain about documentation-only packages - remove verbosity from the shared library packaging policy check - fix man page check false positives - make package-with-huge-docs check less verbose - accept lua as a builtin shell - fix false positives on filesystem package - add check for init scrips missing $remote_fs - adjust library policy suppressions for opal and pwlib (#290347) - fix readme check (#291150) - its also a devel package if it provides a -devel subpackage (#289735) - suppress %config check for now (#286231) - fix typo in devel-rpmgroup check - another update list of legacy packages - update list of legacy packages - suppressions for mono related packages (#282121) - fix the bzip2/gzip confusion again - update list of legacy packages - add list of legacy package names with non-policy conform package name - check updates from SVN - suppression update - suppress devel-file-in-non-devel package if its just a compat symlink to another .so - avoid unstripped binaries warnings in BETA - fix filesystem lint false positives - suppression update - add descriptions to sysv5 init checks - use readelf for binary info to improve performace - check if source patch/tarballs is not bzip2'ed and bigger than 100k (suse packaging conventions requirement) - check if package contains excessive sized documentation - hide errors related to .packlist files from perl still need to figure out though why they're there - fix build - make the buildroot check work - make the buildroot check factor 10-15 faster - fix the pkgconfig check - fix warning-hide hack (#279865) - description update - hide unstripped-binary-or-object warning outside build (#279865) - fix typo in library policy check - adopt library checks for suse library packaging policy - add check for unnecessarily packaged files - description update - suppression update - suppression update - fix various checks - add checks for init scripts - update LibraryPolicy Checker - suppression update - fix XDG menu checker to also include non-/usr paths - fix ghost-file-creation check to skip missingok files (#278761) - suppression-update - Library Policy Checker crash fixes (#278592) - add description for missing lsb tags check - fix obsolete-not-provided for yast2-provides - fix devel-file check matching module names (e.g. apache2) - avoid spurious executable warnings for docdatadir/examples - add LibraryPolicy checker from Richard (warning only) - suppression update - fix suppression for qa_ packages - fix exceptions caused by DesktopTranslation check - fix crash caused by trailing colons in requires - fix file paths in Duplicate and DesktopTranslation checks - update sourced-dirs list - add some more standard users - add suppression for devel-file-in-non-devel package in java - filter some more noise - add descriptions for obsolete suse version check - suppress some more noise - don't run duplicates check for source rpms - suppress errors for cross-avr-* - suppress devel-packaging-naming errors for gcc41, gcc42 - group output by check and put errors last (#276943) - suppress some more noise (#277308) - suppress %ifarch-applied-patch (#277316) - more suppressions for misnamed devel packages (#277317) - Suppress errors about platform dependent code in /usr/share if its inside a platform-dependant subdirectory - Suppress devel-file-in-non-devel-package for systemtap (#277338) - Make sure that the package fails if there is any syntax error anywhere - typo fix - update config - add three more checks - update Duplicates Check to not crash on ghost files - suppress bzip2 related warnings - no documentation for lib packages - add a check how much space is wasted by duplicated files - remove rpm-devel requirement - add check for filerequires on /usr/bin/env - fix syntax errors in previous change - add a check for /opt/kde3 not in %doc or in %lang - fix files not in %lang check - remove tabs from sources - fix desktop file check (#252482) - allow extensions to LSB starting with "X-" (#271495) - remove check for usedforbuild tag. magic happens and it is created automatically - add spec checks for obsolete suse hacks - update to 0.80: * many more checks - suppression updates - suppressions for OpenOffice and linux-kernel-headers - update suppressions - fix compatibility with rpm-python of sles9 (#216081) - update to 0.77: * updated checks regarding FHS compliance * some python-lint fixlets - update to 0.76 - update to 0.75 - suppress some glibc related errors (#157906) - add km to the list of valid locales - converted neededforbuild to BuildRequires - add check for untranslated desktop files - fix i18n subdir check - filter init-script-name-with-dot /etc/init.d/boot.* and script-without-shellbang /etc/profile.d/* - update to 0.71 - strip "requires-on-release" for now, too much noise - ignore dir-or-file-in-opt - update to 0.70 - upgrade to rpmlint 0.69 - split out the config file from the SUSE patch - remove some MDK specific tests and add some SUSE specific tests - building as non-root - initial version OBS-URL: https://build.opensuse.org/request/show/592876 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=579 |
|||
5434a13f31 |
Accepting request 590417 from home:sleep_walker:branches:devel:openSUSE:Factory:rpmlint
I'd like to push c-toxcore (and then qTox and possibly other) to Factory. Let's resever standard UID and GID for it. - Add tox user and toxcmd group as standard openSUSE GID and UID OBS-URL: https://build.opensuse.org/request/show/590417 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=577 |
|||
f83e585dfa |
Accepting request 585035 from home:mgerstner:branches:devel:openSUSE:Factory:rpmlint
- Corrected tpm2-abrmd (bnc#1049694). The D-Bus activation file is named differently than the configuration file. OBS-URL: https://build.opensuse.org/request/show/585035 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=576 |
|||
ab93dd072b |
- Update to version 84.87+git20180220.6f1f0aa:
* polkit: adjust reference output to match corresponding change in rpmlint-checks OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=573 |
|||
66ddf70341 |
Accepting request 578342 from home:dimstar:Factory
- Add one more deprecated license: + GPL-2.0-with-font-exception. Hopefully the last one to unbreak rings 1 + 2 OBS-URL: https://build.opensuse.org/request/show/578342 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=572 |
|||
0b2848951f |
Accepting request 578225 from home:coolo:branches:openSUSE:Factory
- allow more deprecated licenses to unbreak ring1+2 OBS-URL: https://build.opensuse.org/request/show/578225 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=571 |
|||
fdb8ab6dfe | OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=570 | |||
1411277d1e |
- Update to version 84.87+git20180218.1142fcc:
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=569 |
|||
95afc7bd76 |
- Update to version 84.87+git20180218.9a5c783:
* Update polkit ref tests OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=568 |
|||
fc588f707f |
- add 0001-Always-import-XDG-desktop-files-as-utf8.patch
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=567 |
|||
27e0f946b3 |
Accepting request 576938 from home:coolo:branches:openSUSE:Factory
- Allow some deprecated licenses that we would replace on commit (SPDX 2->SPDX 3 conversion) OBS-URL: https://build.opensuse.org/request/show/576938 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=566 |
|||
f3e40f9a67 | OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=565 | |||
e420fc7839 |
- Update rpmlint-checks to version master:
* polkit: make untracked privileges also an error OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=564 |
|||
6d377a1258 |
- Update to version 84.87+git20180202.3df4ae7:
* Add testcases for MenuXDGCheck.py - Update rpmlint-checks to version master: * Support uppercase tag macros used by RPM 4.14 - Update to version 84.87+git20180202.3df4ae7: * Add testcases for MenuXDGCheck.py OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=563 |
|||
e66338ab64 |
remove xdg-paths-update.diff (merged into other patch)
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=562 |
|||
f6b9684380 | OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=561 | |||
f56c6d624f |
- refresh for 0001-Improve-XDG-Menu-checks-stability.patch
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=560 |
|||
cc9be002a2 | OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=558 | |||
15fc6a460e |
Accepting request 564195 from home:Pharaoh_Atem:branches:devel:openSUSE:Factory:rpmlint
- Add Development/{Languages,Libraries}/Rust groups as noted in wiki OBS-URL: https://build.opensuse.org/request/show/564195 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=557 |
|||
132ccb16ea |
Accepting request 564500 from home:krahmer:branches:devel:openSUSE:Factory:rpmlint
- whitelisting usbauth (bsc#1066877) OBS-URL: https://build.opensuse.org/request/show/564500 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=556 |
|||
90805877a4 |
Accepting request 561793 from home:adamm:branches:devel:openSUSE:Factory:rpmlint
- add missing comma (,) to config file - add user/group _nsd for NSD name server OBS-URL: https://build.opensuse.org/request/show/561793 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=555 |
|||
a40e314d61 |
Accepting request 547583 from home:StefanBruens:branches:devel:openSUSE:Factory:rpmlint_submit
- add 0001-Binariescheck-Check-for-chroot-chdir-on-ARM-PPC.patch OBS-URL: https://build.opensuse.org/request/show/547583 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=554 |
|||
a880f9c696 |
Accepting request 546382 from home:krahmer:branches:devel:openSUSE:Factory:rpmlint
- whitelisting kcmsddm (bsc#1065563) OBS-URL: https://build.opensuse.org/request/show/546382 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=553 |
|||
0520e8267a |
* Rewrite BashismsCheck to actually work
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=552 |
|||
ac9ade0a1e | OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=551 | |||
e42f7f42c0 |
* Open paths within the rpm file itself
* Fix python warning * BashismCheck: Only check regular files OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=550 |
|||
11225a2e61 |
- Update to version master:
* Open paths within the rpm file itself * Fix python warning OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=549 |
|||
b34d205dac |
- Update to version master:
* Fix warnings * Add new rpmlint check for new %{_fillupdir} macro (boo#1069468) OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=548 |
|||
9792c2c48b |
Accepting request 541862 from home:dimstar:Factory
- Add rpmlint-slpp-NUM-NUM.patch: Match libFOO<num>-<num> as a valid dependency on a libary. According the openSUSE packaging policy, if the library name ends on a number, we add a dash between the basename (before the .so) and the version after .so. OBS-URL: https://build.opensuse.org/request/show/541862 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=546 |
|||
cb46d50929 |
- Update rpmlint-tests to version master:
* Add Flake8 travis check * Fix scriptprog invocation * Print the duplicated filenames sorted to be stable accross multiple calls OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=544 |
|||
0b80e184d3 |
- add 0001-Avoid-calling-close-on-undefined-fd-variable.patch
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=543 |
|||
169fb46bec |
Accepting request 536380 from home:jengelh:branches:devel:openSUSE:Factory:rpmlint
- Description updates. Use the %make_install macro. OBS-URL: https://build.opensuse.org/request/show/536380 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=541 |
|||
dbbe8b55cf |
- update suse-whitelist-opensuse.diff to avoid a false positive
OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=540 |
|||
72670212f7 | OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=539 | |||
f60e9325b3 |
Accepting request 536258 from home:krahmer:branches:devel:openSUSE:Factory:rpmlint
- adding connman (bsc#1057697) OBS-URL: https://build.opensuse.org/request/show/536258 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=538 |