suse-edge/Factory
SHA256
13
0
Fork 14
Code Issues Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Reduce the size of the IPA ramfs #147

Merged
nbelouin merged 5 commits from nbelouin/Factory:ipa-explode-rootfs into main 2025-05-13 14:13:01 +02:00
Conversation 7 Commits 5 Files Changed 23 +251 -133
nbelouin commented 2025-05-09 10:51:07 +02:00
Owner
Copy Link

Remove docs and unneeded firmware from IPA ramfs to make it a bit more lightweight.

Also explode the tarball to get better and easier to review PRs against it.

Remove docs and unneeded firmware from IPA ramfs to make it a bit more lightweight. Also explode the tarball to get better and easier to review PRs against it.
nbelouin added 2 commits 2025-05-09 10:51:08 +02:00
Try exploding the tarball 7ea1608a25 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
Try reduce image size
Some checks failed
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after 21m39s
Details
01dcbf17b7 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
steven.hardy commented 2025-05-09 11:48:50 +02:00
Owner
Copy Link

This looks good but we'll need to bump the package version and build a new downloader/chart version

I'm also wondering if now is the time to consider if we can move away from maintaining https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Ironic:2024.2 - e.g could we perhaps add a build target to Factory which we can use to release directly to https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Containers ?

This looks good but we'll need to bump the package version and build a new downloader/chart version I'm also wondering if now is the time to consider if we can move away from maintaining https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Ironic:2024.2 - e.g could we perhaps add a build target to Factory which we can use to release directly to https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Containers ?
nbelouin commented 2025-05-09 13:46:33 +02:00
Author
Owner
Copy Link

Yes, I omitted the package version bump in order to ease the rebase as I expect this one to be merged after #145

We could switch to use isv:SUSE:Edge:Containers and follow the expected workflow of Factory here (publish to ToTest, run SV, publish to Snapshot, and last to Containers for the ones we want to keep) for both images and charts.

It would result in upstream charts using a 999.X.Y version (no +up as there would no longer be another upstream), if that's something that is possible for sylva to use

Yes, I omitted the package version bump in order to ease the rebase as I expect this one to be merged after #145 We could switch to use `isv:SUSE:Edge:Containers` and follow the expected workflow of Factory here (publish to ToTest, run SV, publish to Snapshot, and last to Containers for the ones we want to keep) for both images and charts. It would result in upstream charts using a `999.X.Y` version (no `+up` as there would no longer be another upstream), if that's something that is possible for sylva to use
nbelouin force-pushed ipa-explode-rootfs from 01dcbf17b7 to 15e4de98a7 2025-05-09 16:07:02 +02:00 Compare
nbelouin added 1 commit 2025-05-12 13:52:09 +02:00
Fix get-resource.sh for single arch images
All checks were successful
Build PR in OBS / Build PR in OBS (pull_request_target) Successful in 2m53s
Details
df60bb2ed3 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
nbelouin requested review from mchiappero 2025-05-12 15:30:49 +02:00
nbelouin requested review from steven.hardy 2025-05-12 15:30:49 +02:00
steven.hardy commented 2025-05-12 16:32:00 +02:00
Owner
Copy Link

Yes, I omitted the package version bump in order to ease the rebase as I expect this one to be merged after #145

We could switch to use isv:SUSE:Edge:Containers and follow the expected workflow of Factory here (publish to ToTest, run SV, publish to Snapshot, and last to Containers for the ones we want to keep) for both images and charts.

It would result in upstream charts using a 999.X.Y version (no +up as there would no longer be another upstream), if that's something that is possible for sylva to use

I wonder if we should start with the images as that should have zero impact on existing chart users - we can merge the image updates here then publish and update the GH chart - the main disadvantage is there will be a period of time when the Factory chart is ahead of the upstream chart, but that's probably manageable at least as an interim solution?

> Yes, I omitted the package version bump in order to ease the rebase as I expect this one to be merged after #145 > > We could switch to use `isv:SUSE:Edge:Containers` and follow the expected workflow of Factory here (publish to ToTest, run SV, publish to Snapshot, and last to Containers for the ones we want to keep) for both images and charts. > > It would result in upstream charts using a `999.X.Y` version (no `+up` as there would no longer be another upstream), if that's something that is possible for sylva to use I wonder if we should start with the images as that should have zero impact on existing chart users - we can merge the image updates here then publish and update the GH chart - the main disadvantage is there will be a period of time when the Factory chart is ahead of the upstream chart, but that's probably manageable at least as an interim solution?
steven.hardy approved these changes 2025-05-12 16:33:44 +02:00
steven.hardy left a comment
Owner
Copy Link

lgtm - lets wait for a review from @mchiappero before merging though to make sure this captures all his recent changes

lgtm - lets wait for a review from @mchiappero before merging though to make sure this captures all his recent changes
mchiappero commented 2025-05-13 10:28:48 +02:00
Owner
Copy Link

It looks good to me but there is a file is missing in the rootfs dir: /etc/systemd/system/mnt-ipa.mount.

It looks good to me but there is a file is missing in the rootfs dir: `/etc/systemd/system/mnt-ipa.mount`.
mchiappero commented 2025-05-13 11:12:47 +02:00
Owner
Copy Link

It looks good to me but there is a file is missing in the rootfs dir: /etc/systemd/system/mnt-ipa.mount.

Sorry, my fault. For some reason I ended up pushing a newer/untested version which was meant to be a dev branch for a dev repo. Nicolas will push the correct version with this change as a shortcut, but I'm about to bring the other repo in sync. Sorry for the mistake!

> It looks good to me but there is a file is missing in the rootfs dir: `/etc/systemd/system/mnt-ipa.mount`. Sorry, my fault. For some reason I ended up pushing a newer/untested version which was meant to be a dev branch for a dev repo. Nicolas will push the correct version with this change as a shortcut, but I'm about to bring the other repo in sync. Sorry for the mistake!
nbelouin added 1 commit 2025-05-13 11:13:37 +02:00
Use up to date rootfs
All checks were successful
Build PR in OBS / Build PR in OBS (pull_request_target) Successful in 18s
Details
4e3f1b61fd 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
mchiappero approved these changes 2025-05-13 14:11:00 +02:00
mchiappero left a comment
Owner
Copy Link

Great, thanks for the changes 👍

Great, thanks for the changes 👍
nbelouin merged commit f47b6df822 into main 2025-05-13 14:13:01 +02:00
nbelouin deleted branch ipa-explode-rootfs 2025-05-13 14:13:01 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
steven.hardy
mchiappero
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci ipetrov117 jtomasek kzhelyazkov mchiappero nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#147
No description provided.
Delete Branch "nbelouin/Factory:ipa-explode-rootfs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?