suse-edge/Factory
SHA256
13
0
Fork 14
Code Issues Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Add pre-commit to update release manifest #211

Merged
nbelouin merged 1 commits from nbelouin/Factory:pre-commit-manifest into main 2025-07-29 11:27:57 +02:00
Conversation 2 Commits 1 Files Changed 4 +148 -99
nbelouin commented 2025-07-18 16:39:20 +02:00
Owner
Copy Link

Add pre-commit configuration and local hook to keep release manifest up to date

Add pre-commit configuration and local hook to keep release manifest up to date
nbelouin added 1 commit 2025-07-18 16:39:21 +02:00
Add pre-commit to update release manifest
All checks were successful
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in 14s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Successful in 22s
Details
c4aed7bf4f 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
steven.hardy reviewed 2025-07-25 11:57:15 +02:00
.obs/manifest-check.py Outdated
@@ -6,3 +10,3 @@
def get_chart_version(chart_name: str) -> str:
with open(f"./{chart_name}-chart/Chart.yaml") as f:
chart = yaml.safe_load(f)
chart = yaml.load(f)
steven.hardy commented 2025-07-25 11:57:15 +02:00
Owner
Copy Link

In future I wonder if we could also add validation for k3s/RKE2, e.g parsing https://github.com/k3s-io/k3s/tree/v1.32.4%2Bk3s1/manifests and https://github.com/rancher/rke2/blob/v1.32.4%2Brke2r1/charts/chart_versions.yaml ?

In future I wonder if we could also add validation for k3s/RKE2, e.g parsing https://github.com/k3s-io/k3s/tree/v1.32.4%2Bk3s1/manifests and https://github.com/rancher/rke2/blob/v1.32.4%2Brke2r1/charts/chart_versions.yaml ?
nbelouin commented 2025-07-25 12:00:54 +02:00
Author
Owner
Copy Link

I'd rather see that as a part of the renovate-like process we want, but can be envisioned. I just would not do this as a pre-commit hook as we don't want "random" PRs to contain upgrades to non-related components.
Here we just seek to keep the charts version in sync between the charts definition and release manifest.

I'd rather see that as a part of the renovate-like process we want, but can be envisioned. I just would not do this as a pre-commit hook as we don't want "random" PRs to contain upgrades to non-related components. Here we just seek to keep the charts version in sync between the charts definition and release manifest.
steven.hardy commented 2025-07-25 13:27:18 +02:00
Owner
Copy Link

Sounds good, we can consider other approaches in future, just wanted to mention it :)

Sounds good, we can consider other approaches in future, just wanted to mention it :)
steven.hardy marked this conversation as resolved
nbelouin force-pushed pre-commit-manifest from c4aed7bf4f to 6f586daecf 2025-07-25 15:34:16 +02:00 Compare
nbelouin requested review from dprodanov 2025-07-28 09:44:02 +02:00
nbelouin requested review from steven.hardy 2025-07-28 09:44:02 +02:00
dprodanov approved these changes 2025-07-29 10:59:59 +02:00
nbelouin force-pushed pre-commit-manifest from 6f586daecf to c3f1be5640 2025-07-29 11:26:42 +02:00 Compare
nbelouin merged commit ff1b390d09 into main 2025-07-29 11:27:57 +02:00
nbelouin deleted branch pre-commit-manifest 2025-07-29 11:27:58 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
steven.hardy
dprodanov
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci ipetrov117 jtomasek kzhelyazkov mchiappero nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#211
No description provided.
Delete Branch "nbelouin/Factory:pre-commit-manifest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?