The purpose of this commit is to:
- avoid providing IRONIC_EXTERNAL_HTTP_URL by default, as the Ironic
  startup scripts will be able to derive the value from other variables
- define a new global value under the top values.yaml to generate
  IRONIC_EXTERNAL_HTTP_URL when actually needed
- make sure that the input, which can either be a hostname or an IP
  address, is correctly formatted in case of an IPv6.

This change also allows subsequent cleanups of the whole Configmap
template for Ironic.

Signed-off-by: Marco Chiappero <marco.chiappero@suse.com>

@@ -54,3 +54,3 @@
 if [[ "$(echo "$LISTEN_ALL_INTERFACES" | tr '[:upper:]' '[:lower:]')" == "true" ]]; then
 export IRONIC_HOST_IP="::"
-elif [[ -n env.ENABLE_IPV6 ]]; then
+elif [[ -n "$ENABLE_IPV6" ]]; then

@@ -56,3 +56,3 @@
     local HOSTNAME=$1
 
-    echo "$(nslookup -type=${QUERY} $HOSTNAME | tail -n2 | grep -w "Address:" | cut -d " " -f2)"
+    echo $(nslookup -type=${QUERY} "$HOSTNAME" | tail -n2 | grep -w "Address:" | cut -d " " -f2)

@@ -86,3 +86,3 @@
     IP_ADDR="$(ipcalc "${IP_ADDR}" | grep "^Address:" | awk '{print $2}')"
 
-    echo "$(ip $IP_VERS -br addr show scope global | grep -i " ${IP_ADDR}/" | cut -f 1 -d ' ' | cut -f 1 -d '@')"
+    echo $(ip "$IP_VERS" -br addr show scope global | grep -i " ${IP_ADDR}/" | cut -f 1 -d ' ' | cut -f 1 -d '@')

@@ -112,3 +112,3 @@
     local IFACE=$1
 
-    echo "$(ip $IP_VERS -br addr show scope global up dev $IFACE | awk '{print $3}' | sed -e 's%/.*%%' | head -n 1)"
+    echo $(ip "$IP_VERS" -br addr show scope global up dev $IFACE | awk '{print $3}' | sed -e 's%/.*%%' | head -n 1)

@@ -151,3 +151,3 @@
         until [[ -n "$IFACE_OF_IP" ]]; do
             echo "Waiting for ${PROVISIONING_IP} to be configured on an interface..."
-            IFACE_OF_IP="$(get_interface_of_ip $PROVISIONING_IP)"
+            IFACE_OF_IP="$(get_interface_of_ip "$PROVISIONING_IP")"

@@ -168,3 +168,3 @@
             echo "Waiting for ${PROVISIONING_INTERFACE} interface to be configured..."
 
-            export IRONIC_IPV6="$(get_ip_of_interface $PROVISIONING_INTERFACE 6)"
+            IRONIC_IPV6="$(get_ip_of_interface "$PROVISIONING_INTERFACE" 6)"

@@ -171,3 +171,3 @@
             sleep 1
 
-            export IRONIC_IP="$(get_ip_of_interface $PROVISIONING_INTERFACE 4)"
+            IRONIC_IP="$(get_ip_of_interface "$PROVISIONING_INTERFACE" 4)"

@@ -191,3 +193,2 @@
 
-            IPV6_RECORD="$(get_ip_of_hostname $IRONIC_URL_HOSTNAME 6)"
-            IPV4_RECORD="$(get_ip_of_hostname $IRONIC_URL_HOSTNAME 4)"
+            IPV6_RECORD="$(get_ip_of_hostname "$IRONIC_URL_HOSTNAME" 6)"

@@ -192,2 +194,2 @@
-            IPV6_RECORD="$(get_ip_of_hostname $IRONIC_URL_HOSTNAME 6)"
-            IPV4_RECORD="$(get_ip_of_hostname $IRONIC_URL_HOSTNAME 4)"
+            IPV6_RECORD="$(get_ip_of_hostname "$IRONIC_URL_HOSTNAME" 6)"
+            IPV4_RECORD="$(get_ip_of_hostname "$IRONIC_URL_HOSTNAME" 4)"

@@ -200,3 +202,3 @@
 
             echo "Waiting for ${IPV6_RECORD} to be configured on an interface"
-            IPV6_IFACE="$(get_interface_of_ip $IPV6_RECORD 6)"
+            IPV6_IFACE="$(get_interface_of_ip "$IPV6_RECORD" 6)"

@@ -204,3 +206,3 @@
 
             echo "Waiting for ${IPV4_RECORD} to be configured on an interface"
-            IPV4_IFACE="$(get_interface_of_ip $IPV4_RECORD 4)"
+            IPV4_IFACE="$(get_interface_of_ip "$IPV4_RECORD" 4)"