suse-edge/Factory
SHA256
17
0
Fork 17
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Adding nessie to factory #243

Closed
geoagriogiannis wants to merge 1 commits from geoagriogiannis/Factory:nessie into main
pull from: geoagriogiannis/Factory:nessie
merge into: suse-edge:main
Conversation 3 Commits 1 Files Changed 4 +146
geoagriogiannis commented 2025-08-20 12:03:00 +02:00
Owner
Copy Link

Adding nessie to factory

Adding nessie to factory
geoagriogiannis added 1 commit 2025-08-20 12:03:01 +02:00
Adding nessie to factory
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in 9s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after 3h12m59s
Details
3cfed64cdb
geoagriogiannis requested review from nbelouin 2025-08-20 12:04:54 +02:00
geoagriogiannis requested review from dprodanov 2025-08-20 12:05:19 +02:00
geoagriogiannis commented 2025-08-20 12:06:19 +02:00
Author
Owner
Copy Link

Hi @nbelouin @dprodanov could I please get a review ? It's my first PR and I am trying to make sure I got all needed configuration in place. Thanks!

Hi @nbelouin @dprodanov could I please get a review ? It's my first PR and I am trying to make sure I got all needed configuration in place. Thanks!
nbelouin reviewed 2025-08-20 14:58:12 +02:00
nessie-image/Dockerfile
@@ -0,0 +1,28 @@
# SPDX-License-Identifier: Apache-2.0
#!BuildTag: %%IMG_PREFIX%%nessie:v%%nessie_version%%
nbelouin commented 2025-08-20 14:54:23 +02:00
Owner
Copy Link

we don't prefix tags version with v

we don't prefix tags version with `v`
nessie-image/Dockerfile
@@ -0,0 +4,4 @@
FROM registry.suse.com/bci/bci-base:15.7
LABEL org.opencontainers.image.title="nessie"
nbelouin commented 2025-08-20 14:57:15 +02:00
Owner
Copy Link

You need a # labelprefix=com.suse.application.nessie line before this line and a # endlabelprefix line after the LABELs block to trigger the label helper service

You need a `# labelprefix=com.suse.application.nessie` line before this line and a `# endlabelprefix` line after the `LABEL`s block to trigger the label helper service
geoagriogiannis commented 2025-08-20 15:51:39 +02:00
Author
Owner
Copy Link

added it on #244 thanks!

added it on #244 thanks!
geoagriogiannis marked this conversation as resolved
nessie/_service
@@ -0,0 +6,4 @@
<param name="subdir">nessie</param>
<param name="exclude">.git</param>
<param name="changesgenerate">enable</param>
<param name="versionformat">1.0.0</param>
nbelouin commented 2025-08-20 14:52:57 +02:00
Owner
Copy Link

you want something like this here:

    <param name="versionformat">@PARENT_TAG@</param>
    <param name="versionrewrite-pattern">nessie-v(\d+\.\d+\.\d+)</param>
    <param name="versionrewrite-replacement">\1</param>
you want something like this here: ``` <param name="versionformat">@PARENT_TAG@</param> <param name="versionrewrite-pattern">nessie-v(\d+\.\d+\.\d+)</param> <param name="versionrewrite-replacement">\1</param> ```
geoagriogiannis commented 2025-08-20 15:52:21 +02:00
Author
Owner
Copy Link

uploaded the wrong service file :( fixed on #244

uploaded the wrong service file :( fixed on #244
geoagriogiannis marked this conversation as resolved
nessie/nessie.spec
@@ -0,0 +16,4 @@
#
Name: nessie
# Version will be set automatically by factory's set_version service
nbelouin commented 2025-08-20 14:50:37 +02:00
Owner
Copy Link

For this to be true, you'd need to enable the set_version service in your _service file.

For this to be true, you'd need to enable the `set_version` service in your `_service` file.
geoagriogiannis commented 2025-08-20 15:56:25 +02:00
Author
Owner
Copy Link

same as above, I have the service on #244

same as above, I have the service on #244
geoagriogiannis marked this conversation as resolved
nessie/nessie.spec
@@ -0,0 +38,4 @@
# Optional dependencies for enhanced functionality
Recommends: util-linux
Recommends: kubernetes1.29-client
nbelouin commented 2025-08-20 14:48:04 +02:00
Owner
Copy Link

not sure we want to recommend the 1.29 kubectl

not sure we want to recommend the `1.29` kubectl
geoagriogiannis commented 2025-08-20 15:56:40 +02:00
Author
Owner
Copy Link

removed it!

removed it!
geoagriogiannis marked this conversation as resolved
geoagriogiannis commented 2025-08-20 16:29:46 +02:00
Author
Owner
Copy Link

Closing this as it's conflicting on OBS side when the branch name is the same with the package name.
Rebased on #244 continuing work there.

Closing this as it's conflicting on OBS side when the branch name is the same with the package name. Rebased on #244 continuing work there.
geoagriogiannis closed this pull request 2025-08-20 16:29:46 +02:00
Some checks failed
Check Release Manifest Local Charts Versions / Check Release Manifest Local Charts Versions (pull_request) Successful in 9s
Details
Build PR in OBS / Build PR in OBS (pull_request_target) Failing after 3h12m59s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
dprodanov
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#243
Delete Branch "geoagriogiannis/Factory:nessie"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?