suse-edge/Factory
SHA256
17
0
Fork 17
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Add initial release-manifest image #26

Merged
atanasdinov merged 6 commits from add-release-manifest into main 2024-11-19 14:56:42 +01:00
Conversation 4 Commits 6 Files Changed 4 +146
atanasdinov commented 2024-11-19 12:22:51 +01:00
Owner
Copy Link

Copies over the current release-manifest image used for Edge 3.1.1.

Copies over the [current](https://build.suse.de/package/show/ISV:SUSE:Edge:3.1/release-manifest-310-image) release-manifest image used for Edge 3.1.1.
atanasdinov added 1 commit 2024-11-19 12:22:52 +01:00
Add release-manifest image 8135a73813
atanasdinov requested review from dprodanov 2024-11-19 12:23:08 +01:00
nbelouin reviewed 2024-11-19 13:57:06 +01:00
nbelouin left a comment
Owner
Copy Link

Will need to be updated to current component versions.

Will need to be updated to current component versions.
release-manifest-image/Dockerfile Outdated
@@ -0,0 +13,4 @@
LABEL org.opencontainers.image.vendor="SUSE LLC"
LABEL org.opensuse.reference="%%IMG_REPO%%/%%IMG_PREFIX%%release-manifest:3.1.1"
LABEL org.openbuildservice.disturl="%DISTURL%"
LABEL com.suse.supportlevel="l3"
nbelouin commented 2024-11-19 13:50:23 +01:00
Owner
Copy Link

This should use the template supportlevel

This should use the template supportlevel
release-manifest-image/release_manifest.yaml Outdated
@@ -0,0 +37,4 @@
repository: https://charts.rancher.io
- prettyName: MetalLB
releaseName: metallb
chart: %%CHART_REPO%%/3.1/metallb-chart
nbelouin commented 2024-11-19 13:28:02 +01:00
Owner
Copy Link

Don't we want to use %%IMG_PREFIX%% here as well ?

Don't we want to use `%%IMG_PREFIX%%` here as well ?
atanasdinov added 1 commit 2024-11-19 13:59:30 +01:00
Sync workflow e0da681e5d
atanasdinov added 1 commit 2024-11-19 14:02:25 +01:00
Use macro for support level 06417518f4
atanasdinov added 1 commit 2024-11-19 14:16:52 +01:00
Replace hardcoded version with image prefix macro 59e3b94744
atanasdinov requested review from nbelouin 2024-11-19 14:18:47 +01:00
nbelouin reviewed 2024-11-19 14:22:04 +01:00
release-manifest-image/_service Outdated
@@ -0,0 +2,4 @@
<service mode="buildtime" name="kiwi_metainfo_helper"/>
<service name="replace_using_env" mode="buildtime">
<param name="file">Dockerfile</param>
<param name="eval">IMG_PREFIX=$(rpm --macros=/root/.rpmmacros -E %img_prefix)</param>
nbelouin commented 2024-11-19 14:22:04 +01:00
Owner
Copy Link

You need %{?img_prefix} instead of %img_prefix to allow for empty prefixes

You need `%{?img_prefix}` instead of `%img_prefix` to allow for empty prefixes
atanasdinov added 1 commit 2024-11-19 14:25:23 +01:00
Allow optional value for img prefix b86365d971
atanasdinov added 1 commit 2024-11-19 14:29:52 +01:00
Fix support level templating b6a9d5ff15
nbelouin approved these changes 2024-11-19 14:35:37 +01:00
dprodanov approved these changes 2024-11-19 14:42:22 +01:00
atanasdinov merged commit 5c2204ba3e into main 2024-11-19 14:56:42 +01:00
atanasdinov deleted branch add-release-manifest 2024-11-19 14:56:42 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
nbelouin
dprodanov
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#26
Delete Branch "add-release-manifest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?