suse-edge/Factory
SHA256
17
0
Fork 17
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Release manifest updates in relation to corner case use-cases #60

Merged
ipetrov117 merged 2 commits from ipetrov117/Factory:rm-rancher-migration-workaround into main 2024-12-19 12:27:23 +01:00
Conversation 4 Commits 2 Files Changed 1 +4 -1
ipetrov117 commented 2024-12-19 10:55:50 +01:00
Owner
Copy Link

Changes:

  • Rancher version convention was changed from v2.10.0 to 2.10.0 to better map to the actual version in the upstream helm chart repo which is without the v prefix.

  • Rancher's postDelete hook has been disabled - done to ensure that we will not hit a corner case where:

    1. The Rancher helm chart upgrade fails, because of a core component not yet being ready
    2. The helm-controller schedules a helm uninstall which deletes the Rancher Helm release and triggers the postDelete hook.
    3. The problematic core component is up and running, so helm-controller schedules a helm install with the new version.
    4. Due to insufficient resources, or network connection (or other unforeseen problems), the postDelete hook is still running and it wrongly removes the new Rancher installation resulting in a missing rancher from the cluster after an upgrade.

The postDelete hook ensures that no accidental delete of the Rancher application will happen during an upgrade over a machine with fewer resources.

Changes: - Rancher version convention was changed from `v2.10.0` to `2.10.0` to better map to the actual version in the upstream helm chart repo which is without the `v` prefix. - Rancher's `postDelete` hook has been disabled - done to ensure that we will not hit a corner case where: 1. The Rancher helm chart upgrade fails, because of a core component not yet being ready 2. The `helm-controller` schedules a `helm uninstall` which deletes the Rancher Helm release and triggers the `postDelete` hook. 3. The problematic core component is up and running, so `helm-controller` schedules a `helm install` with the new version. 4. Due to insufficient resources, or network connection (or other unforeseen problems), the `postDelete` hook is still running and it wrongly removes the new Rancher installation resulting in a missing rancher from the cluster after an upgrade. The `postDelete` hook ensures that no accidental delete of the Rancher application will happen during an upgrade over a machine with fewer resources.
ipetrov117 added 2 commits 2024-12-19 10:55:50 +01:00
Use correct rancher version bc36670881
Disable Rancher's postDelete hook
All checks were successful
OBS SCM/CI Workflow Integration started
Details
OBS: autoconf - standard/aarch64
Details
OBS: akri-chart - charts/x86_64
Details
OBS: cdi-chart - charts/x86_64
Details
OBS: akri-dashboard-extension-chart - charts/x86_64
Details
OBS: autoconf - standard/x86_64
Details
OBS: endpoint-copier-operator-chart - charts/x86_64
Details
OBS: crudini - standard/aarch64
Details
OBS: crudini - standard/x86_64
Details
OBS: cri-tools - standard/x86_64
Details
OBS: baremetal-operator - standard/x86_64
Details
OBS: baremetal-operator - standard/aarch64
Details
OBS: cri-tools - standard/aarch64
Details
OBS: cosign - standard/x86_64
Details
OBS: cosign - standard/aarch64
Details
OBS: fakeroot - standard/aarch64
Details
OBS: fakeroot - standard/x86_64
Details
OBS: endpoint-copier-operator - standard/aarch64
Details
OBS: endpoint-copier-operator - standard/x86_64
Details
OBS: kubevirt-chart - charts/x86_64
Details
OBS: ipcalc - standard/x86_64
Details
OBS: kubectl - standard/aarch64
Details
OBS: kubectl - standard/x86_64
Details
OBS: edge-image-builder - standard/x86_64
Details
OBS: edge-image-builder - standard/aarch64
Details
OBS: ipcalc - standard/aarch64
Details
OBS: frr-k8s - standard/x86_64
Details
OBS: frr-image - images/aarch64
Details
OBS: frr-image - images/x86_64
Details
OBS: kubevirt-dashboard-extension-chart - charts/x86_64
Details
OBS: metallb-chart - charts/x86_64
Details
OBS: metal3-chart - charts/x86_64
Details
OBS: obs-service-set_version - standard/aarch64
Details
OBS: release-manifest-image - test_manifest_images/aarch64
Details
OBS: baremetal-operator-image - images/x86_64
Details
OBS: release-manifest-image - images/aarch64
Details
OBS: metallb - standard/aarch64
Details
OBS: obs-service-set_version - standard/x86_64
Details
OBS: frr-k8s - standard/aarch64
Details
OBS: kube-rbac-proxy - standard/x86_64
Details
OBS: rancher-turtles-airgap-resources-chart - charts/x86_64
Details
OBS: baremetal-operator-image - images/aarch64
Details
OBS: kube-rbac-proxy - standard/aarch64
Details
OBS: kiwi-builder-image - images/aarch64
Details
OBS: release-manifest-image - test_manifest_images/x86_64
Details
OBS: kiwi-builder-image - images/x86_64
Details
OBS: rancher-turtles-chart - charts/x86_64
Details
OBS: upgrade-controller-chart - charts/x86_64
Details
OBS: sriov-network-operator-chart - charts/x86_64
Details
OBS: sriov-crd-chart - charts/x86_64
Details
OBS: metallb - standard/x86_64
Details
OBS: release-manifest-image - images/x86_64
Details
OBS: hauler - standard/x86_64
Details
OBS: kubectl-image - images/aarch64
Details
OBS: kubectl-image - images/x86_64
Details
OBS: upgrade-controller - standard/aarch64
Details
OBS: upgrade-controller - standard/x86_64
Details
OBS: hauler - standard/aarch64
Details
OBS: endpoint-copier-operator-image - images/aarch64
Details
OBS: nm-configurator - standard/x86_64
Details
OBS: endpoint-copier-operator-image - images/x86_64
Details
OBS: nm-configurator - standard/aarch64
Details
OBS: kube-rbac-proxy-image - images/x86_64
Details
OBS: kube-rbac-proxy-image - images/aarch64
Details
OBS: akri - standard/x86_64
Details
OBS: metallb-controller-image - images/aarch64
Details
OBS: metallb-speaker-image - images/aarch64
Details
OBS: metallb-controller-image - images/x86_64
Details
OBS: metallb-speaker-image - images/x86_64
Details
OBS: upgrade-controller-image - images/aarch64
Details
OBS: upgrade-controller-image - images/x86_64
Details
OBS: ironic-image - images/x86_64
Details
OBS: akri - standard/aarch64
Details
OBS: edge-image-builder-image - test_manifest_images/x86_64
Details
OBS: edge-image-builder-image - test_manifest_images/aarch64
Details
OBS: edge-image-builder-image - images/aarch64
Details
OBS: edge-image-builder-image - images/x86_64
Details
OBS: akri-controller-image - images/x86_64
Details
OBS: akri-debug-echo-discovery-handler-image - images/x86_64
Details
OBS: akri-opcua-discovery-handler-image - images/x86_64
Details
OBS: akri-webhook-configuration-image - images/x86_64
Details
OBS: ironic-ipa-ramdisk - standard/x86_64
Details
OBS: akri-udev-discovery-handler-image - images/x86_64
Details
OBS: akri-agent-image - images/x86_64
Details
OBS: akri-onvif-discovery-handler-image - images/x86_64
Details
OBS: akri-debug-echo-discovery-handler-image - images/aarch64
Details
OBS: akri-webhook-configuration-image - images/aarch64
Details
OBS: akri-opcua-discovery-handler-image - images/aarch64
Details
OBS: akri-controller-image - images/aarch64
Details
OBS: akri-onvif-discovery-handler-image - images/aarch64
Details
OBS: akri-udev-discovery-handler-image - images/aarch64
Details
OBS: akri-agent-image - images/aarch64
Details
OBS: ironic-ipa-downloader-image - images/x86_64
Details
ee934712f0
ipetrov117 requested review from atanasdinov 2024-12-19 10:55:58 +01:00
ipetrov117 requested review from dprodanov 2024-12-19 10:55:58 +01:00
dprodanov approved these changes 2024-12-19 10:59:44 +01:00
nbelouin approved these changes 2024-12-19 11:02:16 +01:00
ipetrov117 commented 2024-12-19 11:03:05 +01:00
Author
Owner
Copy Link

Currently waiting on some final validations and we will merge.

Currently waiting on some final validations and we will merge.
atanasdinov approved these changes 2024-12-19 12:25:15 +01:00
ipetrov117 merged commit fde506f9ef into main 2024-12-19 12:27:23 +01:00
ipetrov117 deleted branch rm-rancher-migration-workaround 2024-12-19 12:27:23 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
dprodanov
nbelouin
atanasdinov
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amorgante antaloala atanasdinov atrendafilov dbekhit dprodanov eminguez fdegirmenci geoagriogiannis ipetrov117 jarndt jtomasek kzhelyazkov mchiappero mkrutov nbelouin roxenham steven.hardy
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#60
Delete Branch "ipetrov117/Factory:rm-rancher-migration-workaround"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?