Release manifest updates in relation to corner case use-cases #60

Merged

ipetrov117 merged 2 commits from ipetrov117/Factory:rm-rancher-migration-workaround into main 2024-12-19 12:27:23 +01:00

Conversation 1 Commits 2 Files Changed 1 +4 -1

ipetrov117 commented 2024-12-19 10:55:50 +01:00

Owner

Copy Link

Changes:

• Rancher version convention was changed from v2.10.0 to 2.10.0 to better map to the actual version in the upstream helm chart repo which is without the v prefix.

• Rancher's postDelete hook has been disabled - done to ensure that we will not hit a corner case where:

  1. The Rancher helm chart upgrade fails, because of a core component not yet being ready
  2. The helm-controller schedules a helm uninstall which deletes the Rancher Helm release and triggers the postDelete hook.
  3. The problematic core component is up and running, so helm-controller schedules a helm install with the new version.
  4. Due to insufficient resources, or network connection (or other unforeseen problems), the postDelete hook is still running and it wrongly removes the new Rancher installation resulting in a missing rancher from the cluster after an upgrade.

The postDelete hook ensures that no accidental delete of the Rancher application will happen during an upgrade over a machine with fewer resources.

Changes: - Rancher version convention was changed from `v2.10.0` to `2.10.0` to better map to the actual version in the upstream helm chart repo which is without the `v` prefix. - Rancher's `postDelete` hook has been disabled - done to ensure that we will not hit a corner case where: 1. The Rancher helm chart upgrade fails, because of a core component not yet being ready 2. The `helm-controller` schedules a `helm uninstall` which deletes the Rancher Helm release and triggers the `postDelete` hook. 3. The problematic core component is up and running, so `helm-controller` schedules a `helm install` with the new version. 4. Due to insufficient resources, or network connection (or other unforeseen problems), the `postDelete` hook is still running and it wrongly removes the new Rancher installation resulting in a missing rancher from the cluster after an upgrade. The `postDelete` hook ensures that no accidental delete of the Rancher application will happen during an upgrade over a machine with fewer resources.

ipetrov117 added 2 commits 2024-12-19 10:55:50 +01:00

Use correct rancher version bc36670881

Disable Rancher's postDelete hook ee934712f0

ipetrov117 requested review from atanasdinov 2024-12-19 10:55:58 +01:00

ipetrov117 requested review from dprodanov 2024-12-19 10:55:58 +01:00

dprodanov approved these changes 2024-12-19 10:59:44 +01:00

nbelouin approved these changes 2024-12-19 11:02:16 +01:00

ipetrov117 commented 2024-12-19 11:03:05 +01:00

Author

Owner

Copy Link

Currently waiting on some final validations and we will merge.

Currently waiting on some final validations and we will merge.

atanasdinov approved these changes 2024-12-19 12:25:15 +01:00

ipetrov117 merged commit fde506f9ef into main 2024-12-19 12:27:23 +01:00

ipetrov117 deleted branch rm-rancher-migration-workaround 2024-12-19 12:27:23 +01:00

ipetrov117 referenced this issue from a commit 2024-12-19 12:27:25 +01:00

Release manifest updates in relation to corner case use-cases (#60)

ipetrov117 referenced this issue from a commit 2024-12-19 12:29:08 +01:00

Release manifest updates in relation to corner case use-cases (#60)

ipetrov117 referenced this pull request 2024-12-19 12:30:21 +01:00

Backport Release Manifest changes #61

ipetrov117 referenced this issue from a commit 2024-12-19 12:54:58 +01:00

Backport Release Manifest changes (#61)

Sign in to join this conversation.

Reviewers

No reviewers

dprodanov

nbelouin

atanasdinov

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

4 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suse-edge/Factory#60

No description provided.