suse-edge/Factory
SHA256
11
0
Fork 5
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

metal3 - updates for 0.9.1 chart #69

Merged
steven.hardy merged 6 commits from steven.hardy/Factory:metal3_091 into main 2025-02-10 12:48:01 +01:00
Conversation 3 Commits 6 Files Changed 10 +88 -51
steven.hardy commented 2025-02-05 17:09:20 +01:00
Owner
Copy Link

Align with https://github.com/suse-edge/charts/pull/173 which added some fixes to enable deployment on aarch64

This also requires updates to the ironic and IPA images, which are derived from https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Ironic:2024.2

Align with https://github.com/suse-edge/charts/pull/173 which added some fixes to enable deployment on aarch64 This also requires updates to the ironic and IPA images, which are derived from https://build.opensuse.org/project/show/isv:SUSE:Edge:Metal3:Ironic:2024.2
steven.hardy added 4 commits 2025-02-05 17:09:21 +01:00 
Align with latest 26.1.2.1 version from
https://build.opensuse.org/package/show/isv:SUSE:Edge:Metal3:Ironic:2024.2/ironic-image
Update to the latest version from
https://build.opensuse.org/package/show/isv:SUSE:Edge:Metal3:Ironic:2024.2/ironic-ipa-ramdisk
Update to the latest version from
https://build.opensuse.org/package/show/isv:SUSE:Edge:Metal3:Ironic:2024.2/ironic-ipa-downloader-image
metal3-chart: update to 0.9.1
Some checks failed
OBS: endpoint-copier-operator-image - images/x86_64
Details
OBS: frr-k8s-image - images/x86_64
Details
OBS: baremetal-operator-image - images/x86_64
Details
OBS: frr-image - images/x86_64
Details
OBS: akri-controller-image - images/aarch64
Details
OBS: kubectl-image - images/x86_64
Details
OBS: kube-rbac-proxy-image - images/x86_64
Details
OBS: edge-image-builder-image - test_manifest_images/x86_64
Details
OBS: metallb-controller-image - images/x86_64
Details
OBS: upgrade-controller-image - images/x86_64
Details
OBS: metallb-speaker-image - images/x86_64
Details
OBS: edge-image-builder-image - images/x86_64
Details
OBS: ironic-image - images/x86_64
Details
OBS: akri-onvif-discovery-handler-image - images/aarch64
Details
OBS: akri-agent-image - images/aarch64
Details
OBS: akri-webhook-configuration-image - images/aarch64
Details
OBS: akri-udev-discovery-handler-image - images/aarch64
Details
OBS: akri-opcua-discovery-handler-image - images/aarch64
Details
OBS: endpoint-copier-operator-image - images/aarch64
Details
OBS: baremetal-operator-image - images/aarch64
Details
OBS: edge-image-builder-image - images/aarch64
Details
OBS: frr-image - images/aarch64
Details
OBS: kube-rbac-proxy-image - images/aarch64
Details
OBS: frr-k8s-image - images/aarch64
Details
OBS: kubectl-image - images/aarch64
Details
OBS: metallb-controller-image - images/aarch64
Details
OBS: metallb-speaker-image - images/aarch64
Details
OBS: upgrade-controller-image - images/aarch64
Details
OBS: nm-configurator - standard/x86_64
Details
OBS: ironic-ipa-downloader-image - images/x86_64
Details
b0ee84e6e1 
Align with https://github.com/suse-edge/charts/pull/173 which
added some fixes to enable deployment on aarch64
steven.hardy requested review from amorgante 2025-02-05 17:09:38 +01:00
steven.hardy requested review from nbelouin 2025-02-05 17:09:38 +01:00
steven.hardy requested review from dprodanov 2025-02-05 17:09:43 +01:00
nbelouin requested changes 2025-02-06 10:42:02 +01:00
Dismissed
nbelouin left a comment
Owner
Copy Link

The root.tar.bz2 doesn't look like it's using git-lfs for storage.

The root.tar.bz2 doesn't look like it's using git-lfs for storage.
ironic-ipa-downloader-image/Dockerfile Outdated
@ -10,2 +10,3 @@
RUN sed -i -e 's%^# rpm.install.excludedocs = no.*%rpm.install.excludedocs = yes%g' /etc/zypp/zypp.conf
RUN zypper --installroot /installroot --non-interactive install --no-recommends ironic-ipa-ramdisk-x86_64 python311-devel python311 python311-pip tar gawk git curl xz fakeroot shadow sed cpio; zypper -n clean; rm -rf /var/log/*
#!ArchExclusiveLine: x86_64
RUN zypper --installroot /installroot --non-interactive install --no-recommends ironic-ipa-ramdisk-x86_64 python311-devel python311 python311-pip tar gawk git curl xz fakeroot shadow sed cpio; zypper -n clean; rm -rf /var/log/*;
nbelouin commented 2025-02-06 10:40:55 +01:00
Owner
Copy Link

Those ArchExclusiveLine things are OBS specific to tell OBS to not try to parse the line for specific arch, it will still get executed by docker build process. You need to use a construction akin to the one in ironic-image Dockerfile here:

#!ArchExclusiveLine: x86_64
RUN if [ "$(uname -m)" = "x86_64" ];then \
...
Those `ArchExclusiveLine` things are OBS specific to tell OBS to not try to parse the line for specific arch, it will still get executed by docker build process. You need to use a construction akin to the one in `ironic-image` Dockerfile here: ```dockerfile #!ArchExclusiveLine: x86_64 RUN if [ "$(uname -m)" = "x86_64" ];then \ ... ```
steven.hardy commented 2025-02-06 17:39:50 +01:00
Author
Owner
Copy Link

Thanks, fixed - I will also adjust this in the next upstream release of this image

Thanks, fixed - I will also adjust this in the next upstream release of this image
steven.hardy marked this conversation as resolved
ironic-ipa-ramdisk/ironic-ipa-ramdisk.kiwi Outdated
@ -129,3 +130,3 @@
<package name="kernel-default"/>
<package name="NetworkManager"/>
<package name="nm-configurator"/>
<package name="nm-configurator-030"/>
nbelouin commented 2025-02-06 10:24:38 +01:00
Owner
Copy Link

Should not use a package suffix here

Should not use a package suffix here
steven.hardy marked this conversation as resolved
ironic-ipa-ramdisk/ironic-ipa-ramdisk.spec Outdated
@ -88,3 +93,3 @@
BuildRequires: which
BuildRequires: NetworkManager
BuildRequires: nm-configurator
BuildRequires: nm-configurator-030
nbelouin commented 2025-02-06 10:25:32 +01:00
Owner
Copy Link

Same here

Same here
steven.hardy marked this conversation as resolved
steven.hardy force-pushed metal3_091 from b0ee84e6e1 to ac32110ac1 2025-02-06 17:39:08 +01:00 Compare
steven.hardy commented 2025-02-06 17:42:52 +01:00
Author
Owner
Copy Link

The root.tar.bz2 doesn't look like it's using git-lfs for storage.

I locally configured git-lfs and did git rm --cached and re-added the tarball in a new commit - how do I check if it's now using lfs or not?

> The root.tar.bz2 doesn't look like it's using git-lfs for storage. I locally configured git-lfs and did `git rm --cached` and re-added the tarball in a new commit - how do I check if it's now using lfs or not?
nbelouin approved these changes 2025-02-07 10:30:11 +01:00
steven.hardy added 1 commit 2025-02-07 12:26:53 +01:00
ironic-ipa-downloader-image: remove unused _service entry
Some checks failed
OBS: baremetal-operator - standard/aarch64
Details
OBS: upgrade-controller-image - images/x86_64
Details
OBS: metallb-controller-image - images/aarch64
Details
OBS: metallb-speaker-image - images/x86_64
Details
OBS: edge-image-builder - standard/aarch64
Details
OBS: hauler - standard/aarch64
Details
OBS: edge-image-builder-image - images/aarch64
Details
OBS: cosign - standard/aarch64
Details
OBS: baremetal-operator-image - images/x86_64
Details
OBS: hauler - standard/x86_64
Details
OBS: metallb-controller-image - images/x86_64
Details
OBS: upgrade-controller - standard/aarch64
Details
OBS: baremetal-operator-image - images/aarch64
Details
OBS: frr-k8s - standard/aarch64
Details
OBS: edge-image-builder-image - test_manifest_images/x86_64
Details
OBS: frr-image - images/aarch64
Details
OBS: frr-k8s - standard/x86_64
Details
OBS: kube-rbac-proxy-image - images/x86_64
Details
OBS: akri-agent-image - images/x86_64
Details
OBS: metallb-speaker-image - images/aarch64
Details
OBS: akri-agent-image - images/aarch64
Details
OBS: kube-rbac-proxy - standard/aarch64
Details
OBS: frr-k8s-image - images/aarch64
Details
OBS: edge-image-builder-image - images/x86_64
Details
OBS: cosign - standard/x86_64
Details
OBS: frr-k8s-image - images/x86_64
Details
OBS: cri-tools - standard/aarch64
Details
OBS: upgrade-controller-image - images/aarch64
Details
OBS: kube-rbac-proxy-image - images/aarch64
Details
OBS: edge-image-builder-image - test_manifest_images/aarch64
Details
45443d5b5f 
This is hard-coded to x86_64 so won't work for ARM, aligns with:
https://build.opensuse.org/package/rdiff/isv:SUSE:Edge:Metal3:Ironic:2024.2/ironic-ipa-downloader-image?linkrev=base&rev=6
steven.hardy merged commit 45443d5b5f into main 2025-02-10 12:48:01 +01:00
steven.hardy deleted branch metal3_091 2025-02-10 12:48:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
amorgante
dprodanov
nbelouin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: suse-edge/Factory#69
No description provided.
Delete Branch "steven.hardy/Factory:metal3_091"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?