repo_checker: Fix the review loop

The break on openQA failures is a left over from 93ee829260a6abf094cbbc31e26eb21bf45e8f15
where we stopped the loop over subprojects. We don't want to break out of
the review loop on openQA failures
This commit is contained in:
Stephan Kulow 2018-07-19 08:41:16 +02:00
parent d16163483a
commit 44f93dfa7c

View File

@ -164,12 +164,9 @@ class RepoChecker(ReviewBot.ReviewBot):
# Not in a "ready" state.
openQA_only = False # Not relevant so set to False.
if status and str(status['overall_state']) == 'failed':
# Exception to the rule is openQA only in failed state.
openQA_only = True
if len(status['broken_packages']):
# Broken packages so not just openQA.
openQA_only = False
break
# Exception to the rule is openQA only in failed state,
# Broken packages so not just openQA.
openQA_only = (len(status['broken_packages']) == 0)
if not self.force and not openQA_only:
self.logger.debug('{}: {} not ready'.format(request.reqid, group))