yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ReviewBot: provide request_default_return option and use in leaper.

Browse Source
This commit is contained in:
Jimmy Berry 2017-06-20 16:25:46 -05:00
parent 7c6f67979a
commit 7bcf94a35f
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReviewBot.py
View File

@ -79,6 +79,7 @@ class ReviewBot(object):
self.fallback_group = None self.fallback_group = None
self.comment_api = CommentAPI(self.apiurl) self.comment_api = CommentAPI(self.apiurl)
self.bot_name = self.__class__.__name__ self.bot_name = self.__class__.__name__
self.request_default_return = None
self.load_config() self.load_config()
@ -262,7 +263,7 @@ class ReviewBot(object):
def check_action__default(self, req, a): def check_action__default(self, req, a):
self.logger.error("unhandled request type %s"%a.type) self.logger.error("unhandled request type %s"%a.type)
return None return self.request_default_return
def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package): def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
""" default implemention does nothing """ """ default implemention does nothing """

6
leaper.py
View File

@ -46,6 +46,9 @@ class Leaper(ReviewBot.ReviewBot):
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
ReviewBot.ReviewBot.__init__(self, *args, **kwargs) ReviewBot.ReviewBot.__init__(self, *args, **kwargs)
# ReviewBot options.
self.request_default_return = True
self.do_comments = True self.do_comments = True
self.maintbot = MaintenanceChecker(*args, **kwargs) self.maintbot = MaintenanceChecker(*args, **kwargs)
@ -476,9 +479,8 @@ class Leaper(ReviewBot.ReviewBot):
return request_ok return request_ok
def check_action__default(self, req, a): def check_action__default(self, req, a):
super(Leaper, self).check_action__default(req, a)
self.needs_release_manager = True self.needs_release_manager = True
return True return super(Leaper, self).check_action__default(req, a)
class CommandLineInterface(ReviewBot.CommandLineInterface): class CommandLineInterface(ReviewBot.CommandLineInterface):