yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ReviewBot: catch exception for adding devel project review

Browse Source 
if the bot is run on requests it has no role it, adding devel project
review may fail. So just handle that and proceed.
This commit is contained in:
Ludwig Nussel 2019-02-05 08:24:16 +01:00
parent 060b7fed61
commit ee7cdc2a90
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ReviewBot.py
View File

@ -309,7 +309,15 @@ class ReviewBot(object):
self.logger.warning('no devel project found for {}/{}'.format(project, package)) self.logger.warning('no devel project found for {}/{}'.format(project, package))
return False return False
try:
self.add_review(request, by_project=devel_project, by_package=devel_package, msg=message) self.add_review(request, by_project=devel_project, by_package=devel_package, msg=message)
except HTTPError as e:
# could happen when the bot is not actually a reviewer and has no permissions
if e.code != 403:
raise e
self.logger.error('failed to add devel project review for {}/{}'.format(devel_project, devel_package))
return False
return True return True
def devel_project_review_ensure(self, request, project, package, message='submitter not devel maintainer'): def devel_project_review_ensure(self, request, project, package, message='submitter not devel maintainer'):