2888 Commits

Author SHA1 Message Date
Jimmy Berry
06d69e5d5b travis & Makefile: drop old repo checker directory creation. 2017-07-13 17:09:13 -05:00
Jimmy Berry
bd5296d680 Makefile: provide package and package-clean targets. 2017-07-13 17:09:13 -05:00
Jimmy Berry
8603a73971 dist/spec: move into package subdirectory in prepration for travis-ci. 2017-07-13 17:09:13 -05:00
Jimmy Berry
3d640e98fb dist/spec: drop osc-plugin-check_repo now that new repo checker was merged. 2017-07-13 17:09:05 -05:00
Jimmy Berry
5beb6541c3 dist/spec: initial specfile including relevant sub-packages.
Definitely some areas that should be improved, but those can be done in
coordination with Makefile updates once a base spec file exists.
2017-07-12 17:16:36 -05:00
Jimmy Berry
2fb35f930d Merge pull request #964 from jberry-suse/repo_checker-rebuild-final
Complete rewrite of repo_checker based on ReviewBot with a large number of improvements
2017-07-12 17:15:02 -05:00
Jimmy Berry
84a91c94ae repo_checker: utilize sorted(reverse=True) instead of reversed() for target_archs(). 2017-07-12 15:32:58 -05:00
Jimmy Berry
24afac5ede repo_checker: reset mirror cache after corruption. 2017-07-12 15:32:27 -05:00
Jimmy Berry
d16af1845f CreatePackageDescr.pm: delete corrupt rpms. 2017-07-12 15:32:27 -05:00
Jimmy Berry
c7632e44cb repo-checker.pl: handle empty string snippet. 2017-07-12 15:32:20 -05:00
Jimmy Berry
3b85406396 repo_checker: handle corrupted requests referencing non-existent projects. 2017-07-12 15:31:30 -05:00
Jimmy Berry
763cf776a2 repo_checker: remove extra newline from install_check() output. 2017-07-12 15:31:30 -05:00
Jimmy Berry
ec2ce9df69 repo_checker: add ignore_file.flush() to ensure ignore file written. 2017-07-12 15:31:30 -05:00
Jimmy Berry
322e9bc6b5 repo-checker.pl: $dir structure matches $repodir (ie no subdir).
Since repo-checker.pl mirrors both product and staging repo using the
same method the glob() should look the same.
2017-07-12 15:31:30 -05:00
Jimmy Berry
52efff0ce1 repo-checker.pl: redirect stderr to file so problems can be detected.
Previously installcheck could crash due to corrupt $pfile and the script
would report no error. Thus any install problems were ignored.
2017-07-12 15:31:30 -05:00
Jimmy Berry
05af37f740 repo-checker.pl: detect invalid package snippet and error out. 2017-07-12 15:31:30 -05:00
Jimmy Berry
0785f2bcfb repo-checker.pl: only create snippet after ignore check. 2017-07-12 15:31:30 -05:00
Jimmy Berry
5887fcb364 CreatePackageDescr: do not append cache file as it never makes sense. 2017-07-12 15:31:30 -05:00
Jimmy Berry
a30ae36ed4 CreatePackageDescr: detect corrupt cache file and rebuild. 2017-07-12 15:31:30 -05:00
Jimmy Berry
0309dfe0cf repo_checker: remove maintainer check for delete requests.
This appears to be an artifact from before factory-auto/leaper require
maintainer review for requests not created by one.
2017-07-12 15:31:30 -05:00
Jimmy Berry
c87c3b02e2 ReviewBot: update tests s/withhistory/withfullhistory/. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7d51cdd46e repo_checker: add TODO regarding delete groups. 2017-07-12 15:31:30 -05:00
Jimmy Berry
af83befff3 Drop everything related to old osc-check_repo.py. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7c81b5f944 repo_checker: utilize ensure_group() for submit and delete requests. 2017-07-12 15:31:30 -05:00
Jimmy Berry
b629ed6863 repo_checker: provide ensure_group() to handle setup and execution of group checks. 2017-07-12 15:31:30 -05:00
Jimmy Berry
02afe64575 repo_checker: adapt the mess in _check_repo_group.osc-check_repo() as cycle_check(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
b6a1da3d19 repo_checker: adapt the mess in _check_repo_group.osc-check_repo() as install_check(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
9683f71d45 repo_checker: define CheckResult for improved readability. 2017-07-12 15:31:30 -05:00
Jimmy Berry
1f6f275a53 repo_checker: adapt checkrepo._toignore() as ignore_from_package(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
5775d2247d repo_checker: provide ignore_from_repo() to list rpm names from mirrored directory. 2017-07-12 15:31:30 -05:00
Jimmy Berry
10f6bd7a87 repo_checker: adapt osc-check_repo._mirror_full() as mirror().
- properly escape arguments
- handle execution failure
- keep track of already mirrored pairs
2017-07-12 15:31:30 -05:00
Jimmy Berry
1167ddff3b repo_checker: provide whitelisted target_archs().
The config option repo_checker-arch-whitelist allows for configuration and
supports reading from the remote config.
2017-07-12 15:31:30 -05:00
Jimmy Berry
631f15fa9a repo_checker: filter requests during prepare_review().
Only request that are staged in a staging that has completed building are
of interest. Requests are then ordered by staging project and those not
meeting the requirements are ignored.
2017-07-12 15:31:30 -05:00
Jimmy Berry
68b785bc70 repo_checker: set review message instead of comment on safe delete. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4fafc29fa3 cycle: rework to compare two projects instead of a project and request list.
This removes the need to detect sub-packages and significantly simplifies
the code while providing the same result.
2017-07-12 15:31:30 -05:00
Jimmy Berry
620499469c repo-checker.pl: provide required arch option instead of hard-coding x86_64. 2017-07-12 15:31:30 -05:00
Jimmy Berry
13c4d50f1c repo-checker.pl: remove rpmlint.log check as it is redundant with legal review.
Requiring rpmlint.log also requires a large number of additional code to
walk the package tree and extract the log.
2017-07-12 15:31:30 -05:00
Jimmy Berry
03a8666fa4 core: adapt checkrepo.get_package_list_from_repository() as binary_list().
- utilize osc.core.get_binarylist() instead of building query manually
- return a namedtuple for increased readability
2017-07-12 15:31:30 -05:00
Jimmy Berry
c2e950eebd core: provide request_staged() and request_when_staged().
Useful for determining if a request has an open staging project review
which makes it likely that it has been staged and avoids the need to
review each staging project.
2017-07-12 15:31:30 -05:00
Jimmy Berry
d4bea1f28d core: owner_fallback(): rework to be consistent with other functions. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4bc130a927 ReviewBot: comment_write(): provide identical option to allow for stricter matching. 2017-07-12 15:31:30 -05:00
Jimmy Berry
dc7e3659a4 ReviewBot: comment_write(): support writing to project. 2017-07-12 15:31:30 -05:00
Jimmy Berry
3f16de02b3 ReviewBot: include comment in __default handler if comments enabled. 2017-07-12 15:31:30 -05:00
Jimmy Berry
96d51b5ad8 ReviewBot: load requests with withfullhistory to allow for review analysis. 2017-07-12 15:31:30 -05:00
Jimmy Berry
c42f13bd0d repo_checker: trust OBS instead of expensive double checking. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7a0e3f78a6 repo_checker: provide initial version based on ReviewBot (only deletes). 2017-07-12 15:31:30 -05:00
Jimmy Berry
cf1c6f5db3 core: provide depends_on(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
84fc6fdc61 core: maintainers_get() provide option to get project maintainers. 2017-07-12 15:31:30 -05:00
Jimmy Berry
060b50f072 ReviewBot: add comment_handler option and use in leaper. 2017-07-12 15:31:30 -05:00
Jimmy Berry
2c1a21704d ReviewBot: copy default review messages before each review. 2017-07-12 15:31:30 -05:00