96 Commits

Author SHA1 Message Date
Jimmy Berry
536e17cb79 osclib/stagingapi: rename dashboard_content_* methods to pseudometa_file_*.
No need to be confusing and use the deprecated dashboard name.
2018-08-17 23:19:24 -05:00
Jimmy Berry
24b15d6b0b Replace relevant 'dashboard' package references with pseudometa lookup.
Skipping some of the broader once which have no tangible impact, but are
expensive to change.
2018-08-17 23:18:32 -05:00
Jimmy Berry
8cffc2e553 repo_checker: use osclib.conf.str2bool() instead of bool(). 2018-08-17 10:16:47 -05:00
Jimmy Berry
1012b62830 ReviewBots: utilize Config.get() instead of self.staging_config. 2018-08-17 10:16:47 -05:00
Jimmy Berry
2809f3934a repo_checker: drop whitelist_clean sub-command.
No longer needed since the whitelist is no longer managed manually.
2018-08-15 16:43:48 -05:00
Jimmy Berry
9fdea5fbee repo_checker: determine existing problems based on project_only output.
The project level whitelist stored in config is no longer utilized, but
staging level overrides are still available.
2018-08-15 16:43:00 -05:00
Jimmy Berry
eed6ddecbe
Merge pull request #1640 from jberry-suse/repo_checker-layering
repo_checker: properly support multi-layer projects
2018-08-15 16:41:49 -05:00
Jimmy Berry
07bc6c031a repo_checker: whitelist_clean(): correct attribute_value_save().
coolo decided to miss this the first time around then "fix" it without
running even once. Wrong number of arguments.
2018-08-14 18:56:37 -05:00
Jimmy Berry
a1cf089572 repo_checker: support multi-layer projects during project_only run.
Include problems from all the layers instead of just the top layer as this
is effectively what the end-user would see.
2018-08-14 18:45:13 -05:00
Jimmy Berry
9e862efeb7 repo_checker: properly support multi-layer projects during request mode.
Previously, the additional layers supported added by coolo treated them
like staging projects which meant that everything except the bottom
override the bottom. Obviously, for SLE service packs this is not correct.

This rewrorks the underlying perl script to support a stack of directories
where the second directory is assumed the be the target project for the
purposes of the toignore (-f) argument and the top layer is the only
one for which problems are reported.
2018-08-14 18:45:10 -05:00
Stephan Kulow
4f275a5af8 Move expanded_repos into staging api
and make pkglistgen and repo_checker use it. We will have more
cases in the future of tools requiring it :)
2018-07-19 09:14:30 +02:00
Stephan Kulow
94e2127dd8 repo_checker: Expand repositories of target project
For Factory, Leap and SLE15 it doesn't matter as they are self contained.
But for Service Packs we use layering, so we need to mirror and check them
too
2018-07-19 09:04:40 +02:00
Stephan Kulow
44f93dfa7c repo_checker: Fix the review loop
The break on openQA failures is a left over from 93ee829260a6abf094cbbc31e26eb21bf45e8f15
where we stopped the loop over subprojects. We don't want to break out of
the review loop on openQA failures
2018-07-19 08:44:59 +02:00
71763873e3 stagingapi: remove staging_walk() function
DVD subproject has been obsoleted, no need to check :DVD anymore.
2018-07-04 21:27:19 +08:00
93ee829260 stagingapi: remove project_status_walk() function
subprojects method has been removed from dashboard,
project_status_walk() is not needed anymore.
2018-07-04 21:24:24 +08:00
Stephan Kulow
140057cad4 repo_checker: Fix config read/load
Fixes #1587
2018-06-25 14:59:33 +02:00
Jimmy Berry
9f20fc7f73
Merge pull request #1547 from jberry-suse/repo_checker-whitelist_clean-binaries-common-None
repo_checker: whitelist_clean: handle binaries_common being None.
2018-05-16 14:31:47 -05:00
Jimmy Berry
eb5d4223dd repo_checker: sort whitelist before writing to config. 2018-05-15 20:17:04 -05:00
Jimmy Berry
bef3706758 repo_checker: include final newline in dashboard/repo_checker file. 2018-05-15 20:16:59 -05:00
Jimmy Berry
b2b8cd6cbd repo_checker: whitelist_clean: handle binaries_common being None.
Otherwise, if len(binaries_common) causes crash when no arch specific
entries. Of which Leap:15.0 is the only one currently.
2018-05-15 17:54:07 -05:00
Jimmy Berry
1730947869
Merge pull request #1516 from jberry-suse/repo_checker-project_only-hourly
repo_checker: project_only: store build hash and skip when unchanged and increase timer frequency to hourly
2018-04-27 11:16:33 -05:00
Jimmy Berry
4f26b0881a repo_checker: project_only: store build hash and skip when unchanged. 2018-04-26 15:34:35 -05:00
Jimmy Berry
e4ff9c1b0b repo_checker: invoke whitelist_clean() as part of project_only. 2018-04-26 15:09:59 -05:00
Jimmy Berry
81c900d913 repo_checker: whitelist_clean: provide interactive flag. 2018-04-26 15:09:43 -05:00
Jimmy Berry
bfb20af7d1 repo_checker: provide whitelist_clean subcommand.
Removes whitelist entries that are no longer mentioned in repo_checker
output and condenses entries common to all.
2018-04-24 17:45:10 -05:00
c676ba7384
repo-checker: Check delete requests for provided runtime dependencies
So far, repo-checker only validated that a delete request won't cause build
dependency failures, but there was no check that removal of a package won't
break other runtime dependencies.

Fixes issue #277
2018-03-24 13:54:12 +01:00
Jimmy Berry
a7931226b7 repo_checker: format what_depends_on as markdown bulleted list. 2018-03-07 14:11:43 -06:00
Jimmy Berry
cdf70be122 repo_checker: provide comment command to skip-cycle for group.
For example (on staging project):

  @repo-checker skip-cycle
2018-03-06 16:42:12 -06:00
Jimmy Berry
f6869b598b repo_checker: utilize ReviewBot.comment_api instead of new instance. 2018-03-06 16:42:12 -06:00
Jimmy Berry
d38307327e
Merge pull request #1360 from jberry-suse/repo_checker-project_only-post-comments-no-devel
repo_checker: skip packages for which not devel project exits.
2018-01-25 09:20:17 -06:00
Jimmy Berry
2dbe361cd7 repo_checker: skip packages for which not devel project exits.
This can occur when a package is removed from Factory, but still present
in Leap like libtxc_dxtn currently.
2018-01-23 21:23:20 -06:00
Jimmy Berry
b2e4e5b3b6 repo_checker: project_only(): correct not published check.
Incorrectly changed in 456a7c8.
2018-01-23 20:59:20 -06:00
Jimmy Berry
0e41747c4e repo_checker: package_comments(): provide option to post on target package.
For SLE where devel projects are not utilized post on the target packages
directly. Posting on the devel projects might make sense, but would pose
the risk of exposing IBS information on OBS prematurely.
2018-01-19 08:50:32 -06:00
Jimmy Berry
d712e8018f repo_checker: package_comments(): switch to devel_project_fallback().
This allows Leap to post to devel projects based on Factory.
2018-01-19 08:50:32 -06:00
Jimmy Berry
0d9c2d2a6c repo_checker: package_comments(): support mutiple target projects.
This allows both Factory and Leap to make comments to devel projects.
2018-01-19 08:50:32 -06:00
Jimmy Berry
f52b728333 repo_checker: package_comments(): include link to target package. 2018-01-19 08:50:32 -06:00
Jimmy Berry
8c4891bd95 ReviewBot: replace get_devel_project() with osclib.core.devel_project_get(). 2018-01-17 18:09:30 -06:00
Ludwig Nussel
98a659c3fa
Merge pull request #1316 from jberry-suse/repo-checker-info_extra_identical
repo_checker: only update comment if published or message changed.
2018-01-02 11:39:25 +01:00
Ludwig Nussel
7e8675e4f9 reochecker: avoid accessing empty status 2018-01-02 09:33:16 +01:00
Jimmy Berry
456a7c82be repo_checker: only update comment if published or message changed. 2017-12-29 18:32:49 -06:00
Ludwig Nussel
97f7cf381b repochecker: filter out self requirement
When handling delete requests, filter out build requirements on the
package itself. Java for example uses it's previous build to
bootstrap itself.
2017-12-01 09:34:49 +01:00
Ludwig Nussel
b0cb96527a repochecker: add --force and --limit-group options
useful for debugging to limit reviews to a specific group
2017-12-01 09:24:47 +01:00
Jimmy Berry
48fe3836a6 repo_checker: review failed stagings with only openQA failures.
Build failures may cause false negatives in repo_checker results, but
openQA failures are not relevant and should be ignored.
2017-11-08 23:45:37 -06:00
Jimmy Berry
9aeb0a4c8e repo_checker: add newline to cycles comment to format properly. 2017-10-31 18:51:56 -05:00
Jimmy Berry
8767f73eca repo_checker: project_only place dashboard update behind dryrun check. 2017-10-31 18:51:56 -05:00
Jimmy Berry
b9bb3ce224 repo_checker: project_only ensure project repository is published. 2017-10-31 18:51:56 -05:00
Jimmy Berry
31cf49a09e repo_checker: store and compare build hash to skip more aggressively. 2017-10-31 18:51:38 -05:00
1cec490d54 White space / consistent usage of spaces / indentation of 4 fixes 2017-10-20 00:58:05 +02:00
Jimmy Berry
47f5affdb0 repo_checker: filter empty whitelist entries. 2017-10-12 17:46:09 -05:00
Jimmy Berry
d2e6b155ce repo_checker: utilize staging configuration for whitelist additions. 2017-10-12 17:46:09 -05:00