yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,871 Commits 2 Branches 12 Tags
Commit Graph

2871 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jimmy Berry
5887fcb364 CreatePackageDescr: do not append cache file as it never makes sense. 2017-07-12 15:31:30 -05:00
Jimmy Berry
a30ae36ed4 CreatePackageDescr: detect corrupt cache file and rebuild. 2017-07-12 15:31:30 -05:00
Jimmy Berry
0309dfe0cf repo_checker: remove maintainer check for delete requests. 
This appears to be an artifact from before factory-auto/leaper require
maintainer review for requests not created by one.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
c87c3b02e2 ReviewBot: update tests s/withhistory/withfullhistory/. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7d51cdd46e repo_checker: add TODO regarding delete groups. 2017-07-12 15:31:30 -05:00
Jimmy Berry
af83befff3 Drop everything related to old osc-check_repo.py. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7c81b5f944 repo_checker: utilize ensure_group() for submit and delete requests. 2017-07-12 15:31:30 -05:00
Jimmy Berry
b629ed6863 repo_checker: provide ensure_group() to handle setup and execution of group checks. 2017-07-12 15:31:30 -05:00
Jimmy Berry
02afe64575 repo_checker: adapt the mess in _check_repo_group.osc-check_repo() as cycle_check(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
b6a1da3d19 repo_checker: adapt the mess in _check_repo_group.osc-check_repo() as install_check(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
9683f71d45 repo_checker: define CheckResult for improved readability. 2017-07-12 15:31:30 -05:00
Jimmy Berry
1f6f275a53 repo_checker: adapt checkrepo._toignore() as ignore_from_package(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
5775d2247d repo_checker: provide ignore_from_repo() to list rpm names from mirrored directory. 2017-07-12 15:31:30 -05:00
Jimmy Berry
10f6bd7a87 repo_checker: adapt osc-check_repo._mirror_full() as mirror(). 
- properly escape arguments
- handle execution failure
- keep track of already mirrored pairs
 2017-07-12 15:31:30 -05:00
Jimmy Berry
1167ddff3b repo_checker: provide whitelisted target_archs(). 
The config option repo_checker-arch-whitelist allows for configuration and
supports reading from the remote config.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
631f15fa9a repo_checker: filter requests during prepare_review(). 
Only request that are staged in a staging that has completed building are
of interest. Requests are then ordered by staging project and those not
meeting the requirements are ignored.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
68b785bc70 repo_checker: set review message instead of comment on safe delete. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4fafc29fa3 cycle: rework to compare two projects instead of a project and request list. 
This removes the need to detect sub-packages and significantly simplifies
the code while providing the same result.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
620499469c repo-checker.pl: provide required arch option instead of hard-coding x86_64. 2017-07-12 15:31:30 -05:00
Jimmy Berry
13c4d50f1c repo-checker.pl: remove rpmlint.log check as it is redundant with legal review. 
Requiring rpmlint.log also requires a large number of additional code to
walk the package tree and extract the log.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
03a8666fa4 core: adapt checkrepo.get_package_list_from_repository() as binary_list(). 
- utilize osc.core.get_binarylist() instead of building query manually
- return a namedtuple for increased readability
 2017-07-12 15:31:30 -05:00
Jimmy Berry
c2e950eebd core: provide request_staged() and request_when_staged(). 
Useful for determining if a request has an open staging project review
which makes it likely that it has been staged and avoids the need to
review each staging project.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
d4bea1f28d core: owner_fallback(): rework to be consistent with other functions. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4bc130a927 ReviewBot: comment_write(): provide identical option to allow for stricter matching. 2017-07-12 15:31:30 -05:00
Jimmy Berry
dc7e3659a4 ReviewBot: comment_write(): support writing to project. 2017-07-12 15:31:30 -05:00
Jimmy Berry
3f16de02b3 ReviewBot: include comment in __default handler if comments enabled. 2017-07-12 15:31:30 -05:00
Jimmy Berry
96d51b5ad8 ReviewBot: load requests with withfullhistory to allow for review analysis. 2017-07-12 15:31:30 -05:00
Jimmy Berry
c42f13bd0d repo_checker: trust OBS instead of expensive double checking. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7a0e3f78a6 repo_checker: provide initial version based on ReviewBot (only deletes). 2017-07-12 15:31:30 -05:00
Jimmy Berry
cf1c6f5db3 core: provide depends_on(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
84fc6fdc61 core: maintainers_get() provide option to get project maintainers. 2017-07-12 15:31:30 -05:00
Jimmy Berry
060b50f072 ReviewBot: add comment_handler option and use in leaper. 2017-07-12 15:31:30 -05:00
Jimmy Berry
2c1a21704d ReviewBot: copy default review messages before each review. 2017-07-12 15:31:30 -05:00
Jimmy Berry
3b1c11f45c ReviewBot: provide only_one_action option and use in leaper and check_source. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7bcf94a35f ReviewBot: provide request_default_return option and use in leaper. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7c6f67979a core: extract maintainers_get(), owner_fallback() from MaintenanceChecker. 
Allows the code to be properly shared between checkrepo and
check_maintenance_incidents as a todo suggests. Given that the majority of
similar cases for code sharing are extension of osc.core it seems to make
sense to place them in osclib.core.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
ad81ff98f9 checkrepo: wait for accepts for all archs before final review accept. 2017-07-12 15:31:30 -05:00
Jimmy Berry
e434aee1c6 osc-check_repo: rework primary calls to loop over archs. 2017-07-12 15:31:30 -05:00
Jimmy Berry
8feb347022 osc-check_repo: protect staging project checks with arch conditions. 2017-07-12 15:31:30 -05:00
Jimmy Berry
ab226e6007 osc-check_repo: extract is_buildsuccess() check before _check_repo_group(). 
_check_repo_group() will become arch specific and is_buildsuccess() already
checks all applicable archs and does not need to be run multiple times.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
a947a03ab6 osc-check_repo: mirror all archs. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4c6f84d842 checkrepo: convert remaining messages to use target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
64b762956f checkrepo: _whatdependson() and _builddepinfo(): utilize target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
f0a559947c checkrepo: is_buildsuccess(): utilize target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
d4639ea0e2 checkrepo: _toignore(): compress into arch loop. 2017-07-12 15:31:30 -05:00
Jimmy Berry
844cf64b6d checkrepo: repositories_to_check(): utilize target_archs(). 
Drastically simplify the logic while keeping the core the same and
utilizing archs from project instead of hard-coded.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
35e03460bf checkrepo: utilize the devel project for requests from Factory. 
Assuming requests are forwarded to Leap after being accepted into Factory
the devel project can be reviewed just as when the requests were submitted
to Factory.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
e29f7e060b checkrepo: provide target_archs() method to determine relevant archs. 
The default behavior is to return the archs for which the target project
is built against, but can be used to check any project (like stagings).
 2017-07-12 15:31:30 -05:00
Jimmy Berry
13dba97ed7 checkrepo: do not decline for disabled builds. 
This behavior is inconsistent in that no builds is ignored, but builds that
are disabled results in a decline. In order to allow for the request to be
evaluated in staging it should not be declined so early.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
0572d7482c checkrepo: some spelling and grammar fixes. 2017-07-12 15:31:30 -05:00