38 Commits

Author SHA1 Message Date
Stephan Kulow
d0bf73b8cf Staging installcheck: Do not overwrite package variable
Fixing strange looking installcheck reports talking about the wrong
package
2022-03-14 13:22:03 +01:00
Stephan Kulow
34d289d87f installcheck: Report all delete requests
It's just very annoying otherwise
2022-03-07 15:23:14 +01:00
Stephan Kulow
d92dabbbbb Installcheck: Ignore requires to packages with delete requests
Fixes #1009
2022-03-04 16:10:14 +01:00
Stephan Kulow
e52d418036 staging-installcheck: Don't exit 1 if there is a problem found
The installcheck did it's job, so exit 1 is just a wrong red flag on the
botmaster dashboard
2022-03-04 12:44:30 +01:00
Stephan Kulow
529d1dafae Target E302 - add two comment lines before class 2022-02-18 17:15:48 +01:00
Fabian Vogt
f87fa6b890 Fix staging-installcheck.py being ignored if i586 is present
For openSUSE:Factory:Staging:adi:*, i586 is only enabled when necessary and so
the check is not set as required. Currently x86_64 is handled first (due to
target_archs), which means that for oS:F, i586 comes last and so the ugly hack
results in x86_64 getting a fake success and the actual status is set for i586
only, which gets ignored.
2020-12-15 11:19:50 +01:00
Stephan Kulow
b98500af39 Allow to disable the check of delete requests per config
SLE service packs are just too complex to check delete requests sanely,
so better disable it. For next SLE we would enable it though

Fixes #2221 and ##2282
2020-03-24 09:05:51 +01:00
Stephan Kulow
8bbb73613d staging-installcheck: Port to use XML to check delete requests 2019-11-29 11:48:17 +01:00
Stephan Kulow
b91cc995dd Fixes for adi command 2019-11-19 08:04:11 +01:00
Stephan Kulow
83681aee72 fix for staging-installcheck 2019-11-19 08:04:10 +01:00
Stephan Kulow
70625a8302 staging-installcheck: remove unused imports/variables 2019-06-06 11:52:46 +02:00
Stephan Kulow
24e4578005 No longer ignore existing problems in adi projects
This is a too big hammer and doesn't motivate to fix things. This was
required for leaky ring projects, but with that problem gone, we can
require adi projects to fix issues.
2019-06-05 16:08:19 +02:00
Stephan Kulow
f840a6f206 Add maintenance-installcheck next to staging-installcheck
A rather small reviewbot just made for one thing: check maintenance
release requests. They are much easier to handle: they are only created
on locked projects, so there is no waiting required. Just checking
and if it's broken, the request can be declined.
2019-06-05 15:37:43 +02:00
Stephan Kulow
868f3e1d6f Retire repo_checker.pl
Extract the writing of the susetags content into a new script that
also creates a yaml file which package comes from what directory.
This information is used in repochecks.py to run findfileconflicts
and installcheck as repo_checker.pl used to
2019-06-05 06:41:14 +02:00
Stephan Kulow
195bb65b48 Ignore current Factory duplicates 2019-05-29 20:31:28 +02:00
Stephan Kulow
8f6a2a5efb Report duplicated binaries in install check 2019-05-29 14:43:17 +02:00
Stephan Kulow
3828715e46 Run staging-installcheck exclusively on python3
It creates invalid reports with python2 and I see no point in debugging
that
2019-05-13 16:07:27 +02:00
Stephan Kulow
97e7d011b8
Merge pull request #2003 from coolo/fix_si
Fix string/bytes confusion with installcheck
2019-05-11 16:53:12 +02:00
Stephan Kulow
9f9e6b75f3 Fix string/bytes confusion with installcheck 2019-05-11 16:40:27 +02:00
Stephan Kulow
fec762e5a4 Avoid warning on using .warn (python3) 2019-05-11 14:25:02 +02:00
Stephan Kulow
2675121d4f Make the ignore whitelist always a set() 2019-04-04 07:28:17 +02:00
Stephan Kulow
2096ac73f4 Ignore packages listed in comments 2019-04-01 20:15:35 +02:00
Stephan Kulow
a8bf788456 Fix one more newline - not just in print 2019-03-27 09:06:35 +01:00
Stephan Kulow
596f656229 Fix newline in SI report 2019-03-27 07:57:07 +01:00
Stephan Kulow
b3f1624260
Merge pull request #1927 from coolo/include_missing_deps_in_output
Include the delete request analysis in the text file
2019-03-27 07:42:03 +01:00
Stephan Kulow
2f3379467c Include the delete request analysis in the text file 2019-03-27 07:34:20 +01:00
Stephan Kulow
780807ebd7 Don't hardcode build.opensuse.org 2019-03-26 13:47:06 +01:00
Stephan Kulow
2f35ae20ed Remove repository (not set for letter stagings) 2019-03-20 13:15:30 +01:00
Stephan Kulow
9667892ca2 SI: upload the result to OBS and link that on failure
This avoids botmaster access being required
2019-03-20 11:38:08 +01:00
Stephan Kulow
96e5c96e24 SI: continue with other stagings on failures
Turn around the boolean expression
2019-03-20 08:39:27 +01:00
Stephan Kulow
7695528682 Allow project comments to ignore delete requests for listed packages 2019-03-20 08:39:27 +01:00
Stephan Kulow
04fde3b7a1 SI: exit 1 if there was an error 2019-03-20 08:39:27 +01:00
Stephan Kulow
9eb1afc852 Don't throw 404 on disappeared adi project 2019-03-20 08:39:27 +01:00
Stephan Kulow
2fc542b5a2 Do not repeated failed reports either 2019-03-20 08:39:27 +01:00
Stephan Kulow
e873ec05f7 SI: Cache existant problems - they are always the same 2019-03-20 08:39:27 +01:00
Stephan Kulow
3520efaaa8 SI: Go through all staging projects 2019-03-20 08:39:27 +01:00
Stephan Kulow
44990b4742 Refactor a little 2019-03-20 08:39:27 +01:00
Stephan Kulow
44c79cfd76 Repo checker: work on staging projects as a whole
Implement a new command that takes a target project and one of its
staging projects and will run the checks against that project (including
delete requests) and if all is fine approves all reviews selected in
that staging.

This is to be used as part of the staging pipeline (and has been tested
with Factory's staging projects)
2019-03-20 08:39:27 +01:00