5639 Commits

Author SHA1 Message Date
Jimmy Berry
de4ff14a71
Merge pull request #2283 from jberry-suse/origin-manager-assume-devel
origin-manager: full handling of various devel project workflows, addition of significant tests, and many underlying fixes
2019-11-04 14:56:28 -06:00
Jimmy Berry
72409c5432 tests/origin_tests: provide split product origin tests. 2019-11-04 14:18:12 -06:00
Jimmy Berry
ad0d0b28ea tests/origin_tests: provide devel origin tests. 2019-11-04 14:18:12 -06:00
Jimmy Berry
43850242cf tests/origin_tests: provide harness and basic tests. 2019-11-04 14:18:12 -06:00
Jimmy Berry
5a5d60b5f6 tests/OBSLocal: provide randomString() for ensuring tools not name dependent. 2019-11-04 14:18:12 -06:00
Jimmy Berry
e7d8c9857e tests/OBSLocal: provide assertReviewBot() for review script workflows. 2019-11-04 14:18:12 -06:00
Jimmy Berry
8ec2202763 tests/OBSLocal: submit_package(): provide optional project argument.
Generating submit requests beyond only against the target project is
important during testing.
2019-11-04 14:18:12 -06:00
Jimmy Berry
e33716866f tests/OBSLocal: StagingWorkflow: provide and utilize remote_config_set(). 2019-11-04 14:18:12 -06:00
Jimmy Berry
1c216fc13a tests/OBSLocal: Request: extract change_state() from revoke.
Changing request state is an import part of testing beyond just revoking.
2019-11-04 14:18:12 -06:00
Jimmy Berry
3c1b01695e tests/OBSLocal: tearDown(): ensure user is Admin before cleanup.
Without this all cleanup fails which can cause leakage between test runs
that utilize the same entity names.
2019-11-04 14:18:12 -06:00
Jimmy Berry
65e23771b6 tests/OBSLocal: StagingWorkflow: stop hiding valid errors.
Makes for debugging issues quite a pain.
2019-11-04 14:18:12 -06:00
Jimmy Berry
5cc14d1841 tests/OBSLocal: correct python 3 port attempt for subprocess output handling.
Newlines are lost in previous port which makes output nearly useless.
2019-11-04 14:18:12 -06:00
Jimmy Berry
acd552c807 tests/OBSLocal: provide osc_user_pop() to make user switching cleaner. 2019-11-04 14:18:08 -06:00
Jimmy Berry
6e1c37b53d tests/OBSLocal: osc_user(): indicate when switching user. 2019-11-04 14:01:34 -06:00
Jimmy Berry
da2e5ea9a8 tests/OBSLocal: disable request cache during testing. 2019-11-04 14:01:34 -06:00
Jimmy Berry
4e95bf3eee osclib/origin_listener: ultilize origin_updatable_map() include_self option.
Useful for trigger follow-up change_devel requests are suppressed updates.
2019-11-04 14:01:34 -06:00
Jimmy Berry
ea7a454d7e osclib/origin: origin_updatable_map(): provide include_self option. 2019-11-04 14:01:34 -06:00
Jimmy Berry
3b51a7e044 osclib/origin: origin_update() generate change_devel requests.
As a follow-up to new packages accepted from a specific devel generate
a change_devel request automatically. Such requests should be approved
automatically since they are a workaround to not being able to set devel
during source submission.
2019-11-04 14:01:34 -06:00
Jimmy Berry
211af47889 origin-manager: handle change_devel request review. 2019-11-04 14:01:34 -06:00
Jimmy Berry
f8dd9eb057 origin-manager: when appropriate simulate devel project during source change review. 2019-11-04 14:01:34 -06:00
Jimmy Berry
bb99e6b5bc origin-manager: provide devel_project_simulate_check().
Handles decided when and what to simulate the devel project as when
reviewing a source change request.
2019-11-04 14:01:34 -06:00
Jimmy Berry
99f79e4dae origin-manager: provide devel_project_simulate_check_command().
Handles ingest of change_devel commands.
2019-11-04 14:01:34 -06:00
Jimmy Berry
bf12c5e0d7 origin-manager: provide and utilize origin_maintainer_review_ensure().
Instead of ensure devel owner using owner search which is incorrect in
many cases including for new packages add a review for origin maintainers.
2019-11-04 14:01:34 -06:00
Jimmy Berry
aa49b57c8e osclib/origin: policy_input_calculate(): handle change from None origin. 2019-11-04 14:01:34 -06:00
Jimmy Berry
790a46cbfc osclib/origin: allow for identical source if origin changed.
Enables change_devel reviews were the source does not change, but the
effective origin will change changed by the request.
2019-11-04 14:01:34 -06:00
Jimmy Berry
c62fb125ef osclib/origin: provide and utilize origin_devel_projects().
Incorporate meta devel, request devel, and whitelist devel into one
function.
2019-11-04 14:01:34 -06:00
Jimmy Berry
683ead7ad6 osclib/origin: provide origin_devel_project() and utlize.
Handles incorporating simulated devel, pseudo devel from requests, and
meta devel project into one function.
2019-11-04 14:01:34 -06:00
Jimmy Berry
d9cc2131ad osclib/origin: provide origin_devel_project_requests().
Determines psuedo devel projects based on pending requests.
2019-11-04 14:01:34 -06:00
Jimmy Berry
83530ce0f6 osclib/origin: provide devel_project_simulate enterable. 2019-11-04 14:01:34 -06:00
Jimmy Berry
a724dcfa9d osclib/origin: require origin key in origin_annotation_load().
Alternatively, this can validate something like "ok: not handled".
2019-11-04 14:01:34 -06:00
Jimmy Berry
2ecb8ce3d7 osclib/origin: provide origin_workaround_strip(). 2019-11-04 14:01:34 -06:00
Jimmy Berry
251170b77d osclib/core: provide request_state_change() and utilize. 2019-11-04 14:01:34 -06:00
Jimmy Berry
e9eab675ab osclib/core: provide request_create_change_devel() RequestFuture. 2019-11-04 14:01:34 -06:00
Jimmy Berry
0f66879c1d osclib/core: provide package_role_expand() to expand package role to users. 2019-11-04 14:01:34 -06:00
Jimmy Berry
66da92ec80 osclib/core: provide project_role_expand() to expand project role to users. 2019-11-04 14:01:34 -06:00
Jimmy Berry
0ee408a716 osclib/core: provide meta_role_expand() to expand a role to users given meta. 2019-11-04 14:01:34 -06:00
Jimmy Berry
3a444c253e osclib/core: break apart request_age() to provide request_created(). 2019-11-04 14:01:34 -06:00
Jimmy Berry
caabf42f2b osclib/cache: provide osrt.cache.disable config option to disable cache.
Necessary for writing involved tests since the assumptions made by the
cache are violated and thus cause problems.

To keep the tests passing the oscrc intended to be used must be set as
environment variable so when osclib.conf.Config is use the config is not
lost. This would be made simpler without the needless extra config added
by StagingWorkflow.
2019-11-04 14:01:19 -06:00
Jimmy Berry
fe45de0a42 dist/ci/flake-extra: include origin_listener in product check. 2019-11-04 13:22:38 -06:00
Jimmy Berry
a3761c62e5 ReviewBot: include request description in search for comment commands. 2019-11-04 13:22:38 -06:00
Jimmy Berry
701021070c ReviewBot: rework override check to operate on actions.
In multi-action workflows the override check should be performed by
action so that different groups of users can override for different
actions. Additionally, abstracting the request_commands() method provides
a flexible base for additional commands to be added by ReviewBots.
2019-11-04 13:22:38 -06:00
Jimmy Berry
7559153cbf osclib/comments: provide request description as comment.
Useful for operating on request descriptions inline with comments.
2019-11-04 13:22:38 -06:00
Stephan Kulow
75836fec70
Merge pull request #2285 from coolo/fix_ci
Make the CI green again
2019-11-04 19:10:51 +01:00
Stephan Kulow
9b035e3e8c Start searchd in api container
Since https://github.com/openSUSE/open-build-service/pull/8558 OBS Api
now requires a searchd for creating projects, previously it was only
required for searching in the webui
2019-11-04 11:59:33 +01:00
Stephan Kulow
0cb54b8be0 Add a dummy user/password to the openSUSE:Factory section
See https://github.com/openSUSE/osc/issues/667 - we might want to remove
the feature to override settings locally this way and stop mangling with
osc's config file
2019-11-04 11:59:33 +01:00
Stephan Kulow
fe4f121993 Make exceptions easier to debug in OBSLocal
If the init function fails due to exceptions, python still
shows exceptions caught in the __del__ function, which can
be very confusing. So avoid the destructor if the constructor
failed by setting the variables early on and return in the
destructor if self.api is not yet defined
2019-11-04 11:04:53 +01:00
Stephan Kulow
3d0d731212
Merge pull request #2281 from DimStar77/issue2278
build-fail-reminder: Fix indentation of emails
2019-11-04 09:53:43 +01:00
d096e163a9
build-fail-reminder: Fix indentation of emails
Fixes issue #2278
2019-10-30 14:08:45 +01:00
Stephan Kulow
330f0b1b1c
Merge pull request #2280 from openSUSE/scarabeusiv-patch-1
Use python3 in shebang to not pull in python2 dependency
2019-10-29 13:36:28 +01:00
Tomáš Chvátal
7cf86a638f
Use python3 in shebang to not pull in python2 dependency 2019-10-29 13:05:48 +01:00