Why no more panic()?
This one should probably be reviewed as one chunk instead of per-commit. If there are issues, I'll add new commits that fix these issues in review on top and I will not be rewriting history.
Thanks for the review. Quite a bit of functionality for PR processing happens in the /common code which have actual tests there. In the code here we have either a lot of git operations or it's…
This looks like a smoke test that different message formats either do something or return an error. The last test here expects an error if the message format is unknown.
This is LLM comment why prset is unused. It's not used because it's re-created internally from the PR body text. So this prset here is not returned by any of the mocks or used by them.
LLM…
gitea.EXPECT().UpdatePullRequest(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
The UpdatePullRequest() is not called, that's why it has "no action". It…
I agree with you here. But the correct way of handling this would be to start the loop of,
- refactor the code into smaller chunks (smaller interfaces), not breaking the tests, then 2.…
