Fixing PR tests in workflow-pr bot #106

adamm · 2026-01-09T13:07:41+01:00

adamm commented

2026-01-09 13:07:41 +01:00

This is initial set of fixes for the unit tests. Will add additional tests to increase coverage.

adamm added 5 commits 2026-01-09 13:07:42 +01:00

pr: fix unit tests 362e481a09

add PRProcessor tests 37c9cc7a57

pr: repo_check unit tests 09001ce01b

pr: add error handling unit tests b7f5c97de1

pr: move common test helpers to dedicated area 2f18adaa67

adamm requested review from jzerebecki 2026-01-09 13:07:44 +01:00

adamm commented

2026-01-09 13:08:45 +01:00

I think the best to review here is just one commit at a time instead of entire set of changes. They are incremental.

adamm added 9 commits 2026-01-10 00:55:55 +01:00

pr: add tests for RebaseAndSkipSubmoduleCommits e8738c9585

pr: add some tests for UpdatePrjGitPR 5f5e7d98b5

pr: add test cases for PRProcessor corner cases 86a7fd072e

- Add scenarios for closed/merged project PRs that trigger
   submodule checks and downstream PR updates (manual merge vs close).
- Test the "Consistency check" logic where submodules are reset
  if they don't match the PR set.
- Test the "superfluous PR" check (no-op PRs that should be closed).

pr: test verifyRepositoryConfiguration 4f132ec154

pr: test PRProcessor that is triggered by webhook abf8aa58fc

- PullRequestWebhookEvent: Verified that PR events correctly
  trigger processing with all necessary Gitea and Git mocks.
- IssueCommentWebhookEvent: Verified that issue comment events
  (which Gitea often uses for PR comments) are handled correctly.
- Recursion Limit: Verified that the recursion protection logic
  correctly terminates and cleans up when the limit is reached.
- Invalid Data Format: Verified that non-event data types return
  appropriate errors.

pr: revive PRProcessor sync tests e806d6ad0d

- Uncomment and fix the existing tests for `synchronized` actions.
- Ensure it uses the new `PullRequestProcessor` interface and mocked dependencies.

pr: fix PR lists to check packages not just project PRs c866303696

Also,
- Add simple unit tests to verify mapping of `models.StateType`
  to internal event strings.
- Verify it correctly wraps `ProcesPullRequest` and handles panics
  via the deferred recovery block.
- Add tests for scenarios where `GetRecentPullRequests` fails.
- Verify the random sleep interval logic (can be tested by mocking
  `time.Sleep` if refactored, or verifying behavior with interval=0).

pr: Add additional unit tests c05fa236d1

- Add a test case specifically verifying that `Gitea.SetLabels`
  is called with `staging/Auto` when a *new* project PR is created
  for submodules.
- Verify `PrjGitDescription` and `SetSubmodulesToMatchPRSet` behave
  correctly when a single `PRSet` contains 5+ different package
  repositories.

pr: move interfaces and mocks to parent package

go-generate-check / go-generate-check (pull_request) Failing after 22s

Details

18f7ed658a

adamm added 1 commit 2026-01-10 00:57:33 +01:00

pr: interfaces moved to main package

go-generate-check / go-generate-check (pull_request) Successful in 7s

Details

f959684540

go-generate-check / go-generate-check (pull_request) Successful in 7s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin pr-tests:pr-tests

git checkout pr-tests

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: git-workflow/autogits#106