maintainer-update #120

Open

adamm wants to merge 6 commits from maintainer-update into main

pull from: maintainer-update

merge into: git-workflow:main

git-workflow:main

git-workflow:gitea-api-update

git-workflow:new-packages

git-workflow:gitpkgs

git-workflow:git-deadlock-fix

git-workflow:staging

git-workflow:submodulemerge

git-workflow:wip_manual_prjgit_merge

git-workflow:spec

git-workflow:status_service

git-workflow:conflicts

Conversation 1 Commits 6 Files Changed 5 +517 -11

adamm commented 2026-01-26 09:27:03 +01:00

Owner

Copy Link

Update maintainership files inplace

Staggered with the pr-tests #106

Update maintainership files inplace Staggered with the pr-tests https://src.opensuse.org/git-workflow/autogits/pulls/106

adamm added 21 commits 2026-01-26 09:27:04 +01:00

pr: fix unit tests 362e481a09

add PRProcessor tests 37c9cc7a57

pr: repo_check unit tests 09001ce01b

pr: add error handling unit tests b7f5c97de1

pr: move common test helpers to dedicated area 2f18adaa67

pr: add tests for RebaseAndSkipSubmoduleCommits e8738c9585

pr: add some tests for UpdatePrjGitPR 5f5e7d98b5

pr: add test cases for PRProcessor corner cases ... 86a7fd072e

- Add scenarios for closed/merged project PRs that trigger
   submodule checks and downstream PR updates (manual merge vs close).
- Test the "Consistency check" logic where submodules are reset
  if they don't match the PR set.
- Test the "superfluous PR" check (no-op PRs that should be closed).

pr: test verifyRepositoryConfiguration 4f132ec154

pr: test PRProcessor that is triggered by webhook ... abf8aa58fc

- PullRequestWebhookEvent: Verified that PR events correctly
  trigger processing with all necessary Gitea and Git mocks.
- IssueCommentWebhookEvent: Verified that issue comment events
  (which Gitea often uses for PR comments) are handled correctly.
- Recursion Limit: Verified that the recursion protection logic
  correctly terminates and cleans up when the limit is reached.
- Invalid Data Format: Verified that non-event data types return
  appropriate errors.

pr: revive PRProcessor sync tests ... e806d6ad0d

- Uncomment and fix the existing tests for `synchronized` actions.
- Ensure it uses the new `PullRequestProcessor` interface and mocked dependencies.

pr: fix PR lists to check packages not just project PRs ... c866303696

Also,
- Add simple unit tests to verify mapping of `models.StateType`
  to internal event strings.
- Verify it correctly wraps `ProcesPullRequest` and handles panics
  via the deferred recovery block.
- Add tests for scenarios where `GetRecentPullRequests` fails.
- Verify the random sleep interval logic (can be tested by mocking
  `time.Sleep` if refactored, or verifying behavior with interval=0).

pr: Add additional unit tests ... c05fa236d1

- Add a test case specifically verifying that `Gitea.SetLabels`
  is called with `staging/Auto` when a *new* project PR is created
  for submodules.
- Verify `PrjGitDescription` and `SetSubmodulesToMatchPRSet` behave
  correctly when a single `PRSet` contains 5+ different package
  repositories.

pr: move interfaces and mocks to parent package 18f7ed658a

pr: interfaces moved to main package f959684540

common: only change maintainership lines that changed bb9e9a08e5

common: precise key removal 86a176a785

util: add maintainership linter 1220799e57

utils: add unit tests 6ee8fcc597

util: fix 844ec8a87b

utils: add maintainer-update to utils f0b053ca07

adamm requested review from jzerebecki 2026-01-26 09:27:04 +01:00

adamm commented 2026-01-27 13:43:25 +01:00

Author

Owner

Copy Link

This one should probably be reviewed as one chunk instead of per-commit. If there are issues, I'll add new commits that fix these issues in review on top and I will not be rewriting history.

This one should probably be reviewed as one chunk instead of per-commit. If there are issues, I'll add new commits that fix these issues in review on top and I will not be rewriting history.

All checks were successful

Hide all checks

go-generate-check / go-generate-check (pull_request) Successful in 25s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin maintainer-update:maintainer-update

git checkout maintainer-update

Sign in to join this conversation.

Reviewers

No Reviewers

jzerebecki

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

M0ses adamm adamm_super adrianSuSE andriinikitin atartamo bigironman dancermak darix dirkmueller dmach eroca jdsn jzerebecki mstrigl oertel smithfarm

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: git-workflow/autogits#120