git-workflow/autogits
SHA256
22
2
Fork 15
Code Issues 44 Pull Requests 14 Actions 1 Projects 2 Activity

maintainer-update #120

Manually merged
adamm merged 10 commits from maintainer-update into main 2026-02-03 13:11:06 +01:00
Conversation 2 Commits 10 Files Changed 5 +517 -11
adamm commented 2026-01-26 09:27:03 +01:00
Owner
Copy Link

Update maintainership files inplace

Staggered with the pr-tests #106

Update maintainership files inplace Staggered with the pr-tests https://src.opensuse.org/git-workflow/autogits/pulls/106
adamm added 21 commits 2026-01-26 09:27:04 +01:00
pr: fix unit tests 362e481a09
add PRProcessor tests 37c9cc7a57
pr: repo_check unit tests 09001ce01b
pr: add error handling unit tests b7f5c97de1
pr: move common test helpers to dedicated area 2f18adaa67
pr: add tests for RebaseAndSkipSubmoduleCommits e8738c9585
pr: add some tests for UpdatePrjGitPR 5f5e7d98b5
pr: add test cases for PRProcessor corner cases 86a7fd072e 
- Add scenarios for closed/merged project PRs that trigger
   submodule checks and downstream PR updates (manual merge vs close).
- Test the "Consistency check" logic where submodules are reset
  if they don't match the PR set.
- Test the "superfluous PR" check (no-op PRs that should be closed).
pr: test verifyRepositoryConfiguration 4f132ec154
pr: test PRProcessor that is triggered by webhook abf8aa58fc 
- PullRequestWebhookEvent: Verified that PR events correctly
  trigger processing with all necessary Gitea and Git mocks.
- IssueCommentWebhookEvent: Verified that issue comment events
  (which Gitea often uses for PR comments) are handled correctly.
- Recursion Limit: Verified that the recursion protection logic
  correctly terminates and cleans up when the limit is reached.
- Invalid Data Format: Verified that non-event data types return
  appropriate errors.
pr: revive PRProcessor sync tests e806d6ad0d 
- Uncomment and fix the existing tests for `synchronized` actions.
- Ensure it uses the new `PullRequestProcessor` interface and mocked dependencies.
pr: fix PR lists to check packages not just project PRs c866303696 
Also,
- Add simple unit tests to verify mapping of `models.StateType`
  to internal event strings.
- Verify it correctly wraps `ProcesPullRequest` and handles panics
  via the deferred recovery block.
- Add tests for scenarios where `GetRecentPullRequests` fails.
- Verify the random sleep interval logic (can be tested by mocking
  `time.Sleep` if refactored, or verifying behavior with interval=0).
pr: Add additional unit tests c05fa236d1 
- Add a test case specifically verifying that `Gitea.SetLabels`
  is called with `staging/Auto` when a *new* project PR is created
  for submodules.
- Verify `PrjGitDescription` and `SetSubmodulesToMatchPRSet` behave
  correctly when a single `PRSet` contains 5+ different package
  repositories.
pr: move interfaces and mocks to parent package
Some checks failed
go-generate-check / go-generate-check (pull_request) Failing after 22s
Details
18f7ed658a
pr: interfaces moved to main package
All checks were successful
go-generate-check / go-generate-check (pull_request) Successful in 7s
Details
f959684540
common: only change maintainership lines that changed bb9e9a08e5
common: precise key removal 86a176a785
util: add maintainership linter 1220799e57
utils: add unit tests 6ee8fcc597
util: fix 844ec8a87b
utils: add maintainer-update to utils
All checks were successful
go-generate-check / go-generate-check (pull_request) Successful in 25s
Details
f0b053ca07
adamm requested review from jzerebecki 2026-01-26 09:27:04 +01:00
adamm commented 2026-01-27 13:43:25 +01:00
Author
Owner
Copy Link

This one should probably be reviewed as one chunk instead of per-commit. If there are issues, I'll add new commits that fix these issues in review on top and I will not be rewriting history.

This one should probably be reviewed as one chunk instead of per-commit. If there are issues, I'll add new commits that fix these issues in review on top and I will not be rewriting history.
jzerebecki approved these changes 2026-02-03 11:01:41 +01:00
jzerebecki left a comment
Owner
Copy Link

Some problems listed inline, but can be fixed in follow ups.

Some problems listed inline, but can be fixed in follow ups.
autogits.spec
@@ -130,2 +130,4 @@
-C utils/hujson \
-buildmode=pie
go build \
-C utils/maintainer-update \
jzerebecki commented 2026-01-27 13:46:30 +01:00
Owner
Copy Link

Please also add this to %check

Please also add this to %check
👍 1
adamm marked this conversation as resolved
utils/maintainer-update/main.go Outdated
@@ -0,0 +23,4 @@
common.PanicOnError(err)
common.PanicOnError(m.WriteMaintainershipFile(f))
common.PanicOnError(f.Close())
common.PanicOnError(os.Rename(filename+".new", filename))
jzerebecki commented 2026-02-03 10:41:15 +01:00
Owner
Copy Link

fsync() missing before rename, without it risks loosing both files.

fsync() missing before rename, without it risks loosing both files.
adamm commented 2026-02-03 11:25:37 +01:00
Author
Owner
Copy Link

So, f.Sync() after f.Close() results in an error. I would assume that such files are flushed already to disk?

So, f.Sync() after f.Close() results in an error. I would assume that such files are flushed already to disk?
adamm marked this conversation as resolved
utils/maintainer-update/main_test.go
@@ -0,0 +93,4 @@
expectedError: "Failed to parse JSON",
},
{
name: "add and remove",
jzerebecki commented 2026-02-03 07:54:25 +01:00
Owner
Copy Link

Test is somehow not implementing description, there is nothing being removed.

Test is somehow not implementing description, there is nothing being removed.
adamm marked this conversation as resolved
utils/maintainer-update/main_test.go
@@ -0,0 +145,4 @@
pkg = flag.String("package", "", "Package to modify")
rm = flag.Bool("rm", false, "Remove maintainer from package")
add = flag.Bool("add", false, "Add maintainer to package")
lint = flag.Bool("lint-only", false, "Reformat entire _maintainership.json only")
jzerebecki commented 2026-02-03 10:35:49 +01:00
Owner
Copy Link

Move these into run() and remove the global calls, to not duplicate them from main.go and actually test them?

Move these into run() and remove the global calls, to not duplicate them from main.go and actually test them?
👍 1
adamm marked this conversation as resolved
adamm added 3 commits 2026-02-03 12:21:08 +01:00
utils: test naming fix f942909ac7
utils: add test runner to spec build process 9532aa897c
util: move flag parsing under run()
All checks were successful
go-generate-check / go-generate-check (pull_request) Successful in 22s
Details
b19d301d95
adamm added 1 commit 2026-02-03 13:10:39 +01:00
utils: sync data when writing new maintainership file
All checks were successful
go-generate-check / go-generate-check (pull_request) Successful in 8s
Details
478a3a140a
adamm manually merged commit 68b67c6975 into main 2026-02-03 13:11:06 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
jzerebecki
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
M0ses adamm adamm_super adrianSuSE andriinikitin atartamo bigironman dancermak darix dirkmueller dmach eroca jdsn jzerebecki mstrigl oertel smithfarm
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: git-workflow/autogits#120
Delete Branch "maintainer-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?