git-workflow/autogits
SHA256
19
0
Fork 8
Code Issues 43 Pull Requests 6 Projects 2 Activity

wip: skip maintainer review if sub by one #90

Draft
adamm wants to merge 1 commits from no-package-review-for-submitter into main
pull from: no-package-review-for-submitter
merge into: git-workflow:main
Conversation 1 Commits 1 Files Changed 1 +6 -2
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
common/pr.go
View File

@@ -256,13 +256,17 @@ func (rs *PRSet) AssignReviewers(gitea GiteaReviewFetcherAndRequester, maintaine
} }
} else { } else {
pkg := pr.PR.Base.Repo.Name pkg := pr.PR.Base.Repo.Name
reviewers = slices.Concat(configReviewers.Pkg, maintainers.ListProjectMaintainers(nil), maintainers.ListPackageMaintainers(pkg, nil), configReviewers.PkgOptional) pkg_maintainers := maintainers.ListPackageMaintainers(pkg, nil)
if slices.Contains(pkg_maintainers, pr.PR.User.UserName) {
pkg_maintainers = nil
}
reviewers = slices.Concat(configReviewers.Pkg, maintainers.ListProjectMaintainers(nil), pkg_maintainers, configReviewers.PkgOptional)
} }
slices.Sort(reviewers) slices.Sort(reviewers)
reviewers = slices.Compact(reviewers) reviewers = slices.Compact(reviewers)
// submitters do not need to review their own work // submitters cannot review their own work
if idx := slices.Index(reviewers, pr.PR.User.UserName); idx != -1 { if idx := slices.Index(reviewers, pr.PR.User.UserName); idx != -1 {
reviewers = slices.Delete(reviewers, idx, idx+1) reviewers = slices.Delete(reviewers, idx, idx+1)
} }