luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 06:56:14 +01:00
Code Issues Packages Projects Releases Wiki Activity
Low-level core library that forms the basis for projects such as GTK+ and GNOME.
24,967 Commits 297 Branches 581 Tags 111 MiB
C 95.3%
Python 2.4%
Meson 1.3%
Objective-C 0.3%
Shell 0.2%
Other 0.5%
58f54e8303
Go to file
Philip Withnall 58f54e8303 tests: Reduce wakeup interval in gdbus-threading 
When checking that the connection has the expected number of refs, the
test would block on a `GMainContext` iteration for up to 3s before
waking up and failing (if the refcount was still not as expected).

This check was written in the expectation that changing the refcount of
the connection would only happen due to dispatching a source on
`GMainContext` — hence the `GMainContext` would wake up as the refcount
changed.

That’s probably not actually true though. It might be the case that the
connection’s refcount is changed on from the GDBus worker thread, which
would not cause any wakeups on the main thread’s `GMainContext`.

In this case, the `GMainContext` iteration in
`assert_connection_has_one_ref()` would block for the full 3s, and then
wake up and notice the refcount is correct (then the test would
proceed).

That’s fine, apart from the fact that `test_threaded_singleton()` does
this 1000 times. If the slow case is hit on a significant number of
those test runs, the test will take around 3000s to complete, which is
significantly more than meson’s test timeout of 360s. So the test fails
with something like:
```
220/266 glib:gio+slow / gdbus-threading         TIMEOUT 360.07 s

--- command ---
G_TEST_SRCDIR='/builds/GNOME/glib/gio/tests' GIO_MODULE_DIR='' G_TEST_BUILDDIR='/builds/GNOME/glib/_build/gio/tests' /builds/GNOME/glib/_build/gio/tests/gdbus-threading
--- stdout ---
\# random seed: R02S83fe8de22db4d4f376e6d179e2bdd601
1..3
\# Start of gdbus tests
ok 1 /gdbus/delivery-in-thread
ok 2 /gdbus/method-calls-in-thread
\# GLib-GIO-DEBUG: refcount of 0x5602de913660 is not right (3 rather than 1) in test_threaded_singleton(), sleeping
\# GLib-GIO-DEBUG: refcount of 0x5602de913660 is not right (3 rather than 1) in test_threaded_singleton(), sleeping
\# GLib-GIO-DEBUG: refcount of 0x5602de913c60 is not right (3 rather than 1) in test_threaded_singleton(), sleeping
\# GLib-GIO-DEBUG: refcount of 0x5602de913c60 is not right (3 rather than 1) in test_threaded_singleton(), sleeping
\# GLib-GIO-DEBUG: refcount of 0x5602de913260 is not right (3 rather than 1) in test_threaded_singleton(), sleeping
\# GLib-GIO-DEBUG: refcount of 0x5602de913260 is not right (3 rather than 1) in test_threaded_singleton(), sleeping
```

From this log, it can be seen that the sleep is happening on a different
`GMainContext` every other time, so the test *is* making progress.

Assuming this is a correct diagnosis (it’s a lot of guessing), this
commit tries to fix the test by adding a wakeup timeout to the
`GMainContext` in `assert_connection_has_one_ref()`, which will wake it
up every 50ms to re-check the exit condition.

This polling approach has been taken because it doesn’t seem feasible to
make sure that every `g_object_ref()`/`g_object_unref()` call on a
`GDBusConnection` causes the main context to wake up.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
2022-04-12 14:39:43 +01:00
.gitlab-ci gio: Remove fam file monitor support 2022-03-23 15:41:54 +00:00
docs Merge branch 'list-store-equal-full' into 'main' 2022-04-05 18:02:15 +00:00
fuzzing fuzzing: Fix test failure with G_DISABLE_ASSERT 2022-03-08 11:52:30 +00:00
gio tests: Reduce wakeup interval in gdbus-threading 2022-04-12 14:39:43 +01:00
glib Merge branch 'onceinit_test' into 'main' 2022-04-12 12:00:27 +00:00
gmodule docs: mark macros, flags, enums with percent sign 2022-03-04 16:21:55 +00:00
gobject gobject: Add g_signal_group_connect_closure 2022-04-05 15:32:20 +01:00
gthread Meson: Override every dependency glib provides 2020-04-05 00:34:04 -04:00
m4macros m4macros: Increment serial number of glib-2.0.m4 2021-01-27 11:55:37 +00:00
po Update Russian translation 2022-04-09 15:34:12 +00:00
subprojects Update subproject pcre.wrap to last version 2022-02-18 10:19:07 +01:00
tests Move tests/onceinit.c to glib/tests/onceinit.c 2022-04-11 15:26:40 +02:00
.clang-format CI: Code check formating in CI 2019-11-21 14:03:01 -06:00
.dir-locals.el Add .dir-locals.el to tell Emacs users not to use tabs for C 2012-07-30 04:09:08 -04:00
.editorconfig docs: Add .editorconfig file 2021-10-28 14:47:53 +01:00
.gitattributes git: Add .gitattributes file with EOL settings for README.win32 2017-07-10 11:35:31 +01:00
.gitignore build: Drop autotools support 2019-01-15 15:11:43 +00:00
.gitlab-ci.yml ci: Expire CI artifacts after 1 week 2022-04-06 12:54:54 +01:00
AUTHORS docs: Rename README.in to README.md for GitLab 2018-06-15 13:04:59 +01:00
check-abis.sh Correct shellcheck errors (and ignore world splitting when we want it) 2020-11-15 17:34:27 +01:00
clang-format-diff.py py: Reformat all Python files consistently 2020-11-17 15:50:07 +00:00
CONTRIBUTING.md Rename the master branch to main 2021-06-07 14:03:48 +01:00
COPYING Update COPYING file to LGPLv2.1 2017-05-29 19:53:35 +02:00
glib-gettextize.in tree: Fix various typos and outdated terminology 2020-06-12 15:01:08 +01:00
glib.doap docs: Update various external links to use HEAD instead of master 2021-06-07 14:03:48 +01:00
glib.supp glib.supp: Suppress one-time allocation in g_get_home_dir() 2021-11-29 16:57:33 +00:00
HACKING docs: Update HACKING and README to mention Meson rather than autotools 2019-01-15 15:11:43 +00:00
INSTALL.in docs: Update some outdated paths in INSTALL.in 2022-01-17 16:21:22 +00:00
meson_options.txt gio: Remove fam file monitor support 2022-03-23 15:41:54 +00:00
meson.build Merge branch 'version-bump' into 'main' 2022-04-05 14:20:14 +00:00
msvc_recommended_pragmas.h msvc_recommended_pragmas.h: Refine for clang-cl 2021-03-30 16:45:07 +08:00
NEWS 2.72.0 2022-03-17 15:01:31 +00:00
NEWS.pre-1-3 updates. 2001-04-03 19:22:44 +00:00
README docs: Rename README.in to README.md for GitLab 2018-06-15 13:04:59 +01:00
README.md docs: Update the README a little 2021-12-09 13:30:23 +00:00
README.rationale Document the stance on ID-based mainloop APIs 2021-07-27 10:21:43 -04:00
README.win32 README.win32: Update and convert to markdown 2019-08-27 12:57:32 +05:30
README.win32.md README.win32.md: Mention about Window 8+ SDK requirement 2021-02-28 11:04:29 +02:00
SECURITY.md docs: Add a note about git-evtag to SECURITY.md 2021-09-07 11:21:12 +00:00
template-tap.test.in tests: Remove redundant --tap options 2019-05-14 12:42:51 +01:00
template.test.in Meson: Install glib tests 2018-07-16 15:36:20 -04:00

README.md

GLib

GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.

The official download locations are: https://download.gnome.org/sources/glib

The official web site is: https://www.gtk.org/

Installation

See the file 'INSTALL.in'

Supported versions

Only the most recent unstable and stable release series are supported. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.

See SECURITY.md for more details.

Documentation

API documentation is available online for GLib for the:

Discussion

If you have a question about how to use GLib, seek help on GNOME’s Discourse instance. Alternatively, ask a question on StackOverflow and tag it glib.

Reporting bugs

Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.

Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.

In bug reports please include:

  • Information about your system. For instance:
    • What operating system and version
    • For Linux, what version of the C library
    • And anything else you think is relevant.
  • How to reproduce the bug.
    • If you can reproduce it with one of the test programs that are built in the tests/ subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
  • If the bug was a crash, the exact text that was printed out when the crash occurred.
  • Further information such as stack traces may be useful, but is not necessary.

Contributing to GLib

Please follow the contribution guide to know how to start contributing to GLib.

Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):

Closes: #123

Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.

Default branch renamed to main

The default development branch of GLib has been renamed to main. To update your local checkout, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main