76148fc6db
Depending on the operating system, /bin/sh might either be bash (for example on Fedora or Arch) or dash (for example on Debian or Ubuntu) or some other POSIX shell. When bash is asked to run a simple command with no shell keywords or metacharacters, like this one, it replaces itself with the program via execve(), but dash does not have that optimization and treats it like any other program invocation in a larger script: it will fork, exec the program in the child, and wait for the child in the parent. This seems like it conflicts with sleep_and_kill() assuming that it can use the subprocess's process ID as the sleep(1) process ID. Specifically, if it sends SIGKILL, it will go to the sh(1) process and not the sleep(1) child, which could result in the sh(1) process being terminated and its sleep(1) child being leaked. To get the bash-like behaviour portably, explicitly use the exec builtin to instruct the shell to replace itself with sleep(1), so that the process ID previously used for the shell becomes the process ID of the sleep process. This appears to resolve an intermittent hang and test timeout on Debian machines (especially slower ones), although I'm not 100% clear on the mechanics of how it happens. Resolves: https://gitlab.gnome.org/GNOME/glib/-/issues/3157 Signed-off-by: Simon McVittie <smcv@collabora.com> |
||
---|---|---|
.gitlab-ci | ||
.reuse | ||
docs | ||
fuzzing | ||
gio | ||
glib | ||
gmodule | ||
gobject | ||
gthread | ||
LICENSES | ||
m4macros | ||
po | ||
subprojects | ||
tests | ||
tools | ||
.clang-format | ||
.dir-locals.el | ||
.editorconfig | ||
.gitignore | ||
.gitlab-ci.yml | ||
.gitmodules | ||
.lcovrc | ||
CODE_OF_CONDUCT.md | ||
CONTRIBUTING.md | ||
COPYING | ||
glib.doap | ||
INSTALL.md | ||
meson_options.txt | ||
meson.build | ||
NEWS | ||
README.md | ||
SECURITY.md |
GLib
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
Installation
See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.
Supported versions
Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
Documentation
API documentation is available online for GLib for the:
Discussion
If you have a question about how to use GLib, seek help on GNOME’s Discourse
instance. Alternatively, ask a question
on StackOverflow and tag it glib
.
Reporting bugs
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
- Information about your system. For instance:
- What operating system and version
- For Linux, what version of the C library
- And anything else you think is relevant.
- How to reproduce the bug.
- If you can reproduce it with one of the test programs that are built
in the
tests/
subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
- If you can reproduce it with one of the test programs that are built
in the
- If the bug was a crash, the exact text that was printed out when the crash occurred.
- Further information such as stack traces may be useful, but is not necessary.
Contributing to GLib
Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.