suse-edge/Factory
SHA256
17
0
Fork 18
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Bump minor version in ironic-image and metal3-chart #206

Merged
mchiappero merged 1 commits from mchiappero/Factory:ironic_26.1.2.5 into main 2025-07-10 23:41:20 +02:00
Conversation 5 Commits 1 Files Changed 7 +15 -15
7 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ironic-image/Dockerfile
View File

@@ -1,6 +1,6 @@
# SPDX-License-Identifier: Apache-2.0
#!BuildTag: %%IMG_PREFIX%%ironic:26.1.2.4
#!BuildTag: %%IMG_PREFIX%%ironic:26.1.2.4-%RELEASE%
#!BuildTag: %%IMG_PREFIX%%ironic:26.1.2.5
#!BuildTag: %%IMG_PREFIX%%ironic:26.1.2.5-%RELEASE%
#!BuildVersion: 15.6
ARG SLE_VERSION
@@ -42,8 +42,8 @@ LABEL org.opencontainers.image.description="Openstack Ironic based on the SLE Ba
LABEL org.opencontainers.image.url="https://www.suse.com/products/server/"
LABEL org.opencontainers.image.created="%BUILDTIME%"
LABEL org.opencontainers.image.vendor="SUSE LLC"
LABEL org.opencontainers.image.version="26.1.2.4"
LABEL org.opensuse.reference="%%IMG_REPO%%/%%IMG_PREFIX%%ironic:26.1.2.4-%RELEASE%"
LABEL org.opencontainers.image.version="26.1.2.5"
LABEL org.opensuse.reference="%%IMG_REPO%%/%%IMG_PREFIX%%ironic:26.1.2.5-%RELEASE%"
LABEL org.openbuildservice.disturl="%DISTURL%"
LABEL com.suse.supportlevel="%%SUPPORT_LEVEL%%"
LABEL com.suse.eula="SUSE Combined EULA February 2024"

12
metal3-chart/Chart.yaml
View File

@@ -1,7 +1,7 @@
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.8_up0.11.6
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.8_up0.11.6-%RELEASE%
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.9_up0.11.7
#!BuildTag: %%CHART_PREFIX%%metal3:%%CHART_MAJOR%%.0.9_up0.11.7-%RELEASE%
apiVersion: v2
appVersion: 0.11.6
appVersion: 0.11.7
dependencies:
- alias: metal3-baremetal-operator
name: baremetal-operator
@@ -10,7 +10,7 @@ dependencies:
- alias: metal3-ironic
name: ironic
repository: file://./charts/ironic
version: 0.10.5
version: 0.10.6
- alias: metal3-mariadb
condition: global.enable_mariadb
name: mariadb
@@ -20,9 +20,9 @@ dependencies:
condition: global.enable_metal3_media_server
name: media
repository: file://./charts/media
version: 0.6.2
version: 0.6.3
description: A Helm chart that installs all of the dependencies needed for Metal3
icon: https://github.com/cncf/artwork/raw/master/projects/metal3/icon/color/metal3-icon-color.svg
name: metal3
type: application
version: "%%CHART_MAJOR%%.0.8+up0.11.6"
version: "%%CHART_MAJOR%%.0.9+up0.11.7"
mchiappero commented 2025-07-08 14:51:19 +02:00
Outdated
Review
Copy Link

@nbelouin, just to double check: we need to update both major and minor, correct?

@nbelouin, just to double check: we need to update both major and minor, correct?
nbelouin commented 2025-07-08 14:57:13 +02:00
Outdated
Review
Copy Link

we need to update both the chart version comparable version i.e %%CHART_MAJOR%%.0.8 -> %%CHART_MAJOR%%.0.9 and the +up suffix one up0.11.6 -> up0.11.7.
About what component of the version we bump, I think it's fine with just bumping patch here

we need to update both the chart version comparable version i.e `%%CHART_MAJOR%%.0.8 -> %%CHART_MAJOR%%.0.9` and the `+up` suffix one `up0.11.6 -> up0.11.7`. About what component of the version we bump, I think it's fine with just bumping patch here
mchiappero commented 2025-07-08 14:59:52 +02:00
Outdated
Review
Copy Link

Thank you for your comment, initially I thought it was ok just to go with the minor, but then I remembered about a previous comment you made a while ago... I'll revert then.

Thank you for your comment, initially I thought it was ok just to go with the minor, but then I remembered about a previous comment you made a while ago... I'll revert then.
nbelouin commented 2025-07-09 09:09:14 +02:00
Outdated
Review
Copy Link

Okay probably got misunderstood here, you still need to bump %%CHART_MAJOR%%.0.8 (the comparable version).

Simply put, semver tells that everything after the + is basically just some informative stuff that doesn't impact the ordering of versions (i.e some kind of comment).

Okay probably got misunderstood here, you still need to bump `%%CHART_MAJOR%%.0.8` (the comparable version). Simply put, semver tells that everything after the `+` is basically just some informative stuff that doesn't impact the ordering of versions (i.e some kind of comment).
mchiappero commented 2025-07-09 11:05:28 +02:00
Outdated
Review
Copy Link

Sorry, some wrong wording from my side, using the "+up...." token as "minor".
Let me update again.

Sorry, some wrong wording from my side, using the "+up...." token as "minor". Let me update again.

2
metal3-chart/charts/ironic/Chart.yaml
View File

@@ -3,4 +3,4 @@ appVersion: 26.1.2
description: A Helm chart for Ironic, used by Metal3
name: ironic
type: application
version: 0.10.5
version: 0.10.6

2
metal3-chart/charts/ironic/values.yaml
View File

@@ -56,7 +56,7 @@ images:
ironic:
repository: registry.opensuse.org/isv/suse/edge/metal3/containers/images/ironic
pullPolicy: IfNotPresent
tag: 26.1.2.4
tag: 26.1.2.5
ironicIPADownloader:
repository: registry.opensuse.org/isv/suse/edge/metal3/containers/images/ironic-ipa-downloader
pullPolicy: IfNotPresent

2
metal3-chart/charts/media/Chart.yaml
View File

@@ -3,4 +3,4 @@ appVersion: 1.16.0
description: A Helm chart for Media, used by Metal3
name: media
type: application
version: 0.6.2
version: 0.6.3

2
metal3-chart/charts/media/values.yaml
View File

@@ -24,7 +24,7 @@ replicaCount: 1
image:
repository: registry.opensuse.org/isv/suse/edge/metal3/containers/images/ironic
pullPolicy: IfNotPresent
tag: 26.1.2.4
tag: 26.1.2.5
imagePullSecrets: []
nameOverride: ""

2
release-manifest-image/release_manifest.yaml
View File

@@ -171,7 +171,7 @@ spec:
- prettyName: Metal3
releaseName: metal3
chart: "%%CHART_REPO%%/%%CHART_PREFIX%%metal3"
version: "%%CHART_MAJOR%%.0.8+up0.11.6"
version: "%%CHART_MAJOR%%.0.9+up0.11.7"
- prettyName: RancherTurtles
releaseName: rancher-turtles
chart: "%%CHART_REPO%%/%%CHART_PREFIX%%rancher-turtles"