105 Commits

Author SHA1 Message Date
Stephan Kulow
de6a64c464 accept: Catch requests without description
Fixes #2799
2022-04-08 08:06:17 +02:00
Stephan Kulow
66bd39eab5 Accept_command: create set_bugowner requests 2022-04-05 19:00:05 +02:00
Stephan Kulow
ca27641a46 Fix staging accept approving package list changes
The order is important, look at the comments *before* deleting them
2022-03-24 16:33:15 +01:00
Stephan Kulow
92fad0708e Prepare applying pkglistgen diffs on staging accept
We will check if there are approved pkglistgen comments and if so, apply
them to the target. For this we need to parse the generated markdown, so
refactor both in a common class.

There diff is applied, but not yet commited in this commit
2022-03-22 09:28:02 +01:00
dbfe014f0e Staging accept: build-disable the images repository
With the current pipelines, we enable build of the images repository
once everything in /standard is build-succeeded and repo-checker passed.

Let's go the last mile and disable images when we check in the staging.

This should save some OBS build power (not building ISO images before the
stagings are actually ready) and also some openQA (not testing ISO images
before stagings settle)

I can foresee that sometimes an RM would still want to have preliminary
testing done - in which case the images repo can be manually build enabled
(or the pipeline be triggered to go beyond repo-checker, as it likely also
needs a recalculation of the content)
2022-03-19 08:33:54 +01:00
Stephan Kulow
f86579642b Target E501 - Line too long
https://www.flake8rules.com/rules/E501.html - but 79 characters is a
joke
2022-02-18 18:17:27 +01:00
Stephan Kulow
d8f5d0874e Remove E201 - Whitespace after '('
https://www.flake8rules.com/rules/E201.html
2022-02-18 17:23:19 +01:00
Stephan Kulow
54079e949f Target E202 - Whitespace before ')'
https://www.flake8rules.com/rules/E202.html
2022-02-18 17:18:29 +01:00
Stephan Kulow
e52dc6ce2b Harmonize imports on using lxml for XML parsing 2022-02-18 11:16:01 +01:00
8bbf34352c accept_command: use the value of attribute to set ProductVersion if always_set_productversion_to option presents 2021-06-22 15:08:45 +08:00
Stephan Kulow
734af63a1b Accept: Don't crash on actions that aren't submit/delete
If a change_devel request is grouped into a staging, it shouldn't crash
on it - the API will accept it, and we have no specific action for this
type

Fixes #2381
2021-01-19 16:29:06 +01:00
16ae5de148 Update version attribute also in o:F:RISCV 2020-07-06 12:11:15 +02:00
fc77bd123d
Staging accept: No longer set the version in .product files on accept
In the past, we had a dashboard reading the version of the current source from the .product file.
Not immediately updating this version after a checkin would have been confusing as the dashboard would
have shown incorrect/outdated information.

the new dashboard (https://factory-dashboard.opensuse.org) reads the source version directly from the
attribute, so this mis-match is eliminated.

The .product files will be updated by pkglistgen in due time.
2020-01-31 14:49:33 +01:00
Stephan Kulow
1a22a59cb0
Merge pull request #2369 from coolo/fix_2368
Do not return after adi project is accepted
2019-12-10 10:55:42 +01:00
Stephan Kulow
271fa912ed Do not return after adi project is accepted
Fixes #2368
2019-12-10 09:55:10 +01:00
ec88760187 Fix Flake E241
One more step towards white space sanity. Next group is E20x.
2019-12-10 08:46:02 +01:00
Stephan Kulow
a354d6c882 Always force accept into the API after checking for acceptable ourselves
This removes the 2nd line of defense, but there is no API to accept multiple
stagings at once to avoid the underlying problem.

Fixes #2364
2019-12-09 10:08:47 +01:00
Stephan Kulow
a7a7921c94 Have staging accept without argument take all green 2019-12-06 14:32:25 +01:00
Stephan Kulow
00bacac61e
Merge pull request #2361 from coolo/remove_adi
Delete adi projects whenever we'd build disable them
2019-12-06 10:45:01 +01:00
Stephan Kulow
b60333075a Delete adi projects whenever we'd build disable them 2019-12-06 07:35:38 +01:00
Ludwig Nussel
0eb12a53c4 Improve _multibuild on accept 2019-12-05 16:52:05 +01:00
Stephan Kulow
15b6634ca4 No longer close acceptable adi stagings
This is merely an experiment to shorten the time that packages end up
in ready lane
2019-12-04 16:21:27 +01:00
Stephan Kulow
0c6f43f448
Merge pull request #2337 from coolo/add_check
Reuse function of accept to check local links
2019-12-04 13:28:29 +01:00
86651a28f9
Only check for the rebuild project if cbuild has been set
Fixes issue #2349
2019-12-03 15:25:45 +01:00
Stephan Kulow
2bfc87088d Reuse function of accept to check local links 2019-11-24 20:04:42 +01:00
Stephan Kulow
8576f22876 Fix test suite for accept 2019-11-24 19:21:14 +01:00
Stephan Kulow
66c4800520 Fix local links 2019-11-24 17:26:55 +01:00
Stephan Kulow
49bfafb183 Accept all stagings at the same time 2019-11-24 16:21:32 +01:00
Stephan Kulow
d4d9382a9e remove links before accepting staging projects 2019-11-24 13:18:27 +01:00
Stephan Kulow
63bda17769 Collect packages for all stagings and ready before accepting 2019-11-24 11:00:47 +01:00
Stephan Kulow
62f97d15d1 Fix accept command to force accept through API 2019-11-22 13:21:55 +01:00
Stephan Kulow
b01b7d529a Move accept logic into accept_command 2019-11-22 13:21:48 +01:00
Stephan Kulow
529c5623a6 Remove nonfree handling
Prepare NonFree as onlyadi project, so it can have its own staging workflow
2019-11-21 14:49:29 +01:00
Stephan Kulow
4655b6c99b Fix accept: first comment then cleanup (comments)
After accept we want empty comments
2019-11-20 16:10:30 +01:00
Stephan Kulow
82c64003c4 Adopt to the new staging_projects api not revealing all infos 2019-11-19 08:04:11 +01:00
Stephan Kulow
61205d35e3 Some fixes for supersede and unselect
the API changed to /requests
2019-11-19 08:04:11 +01:00
Stephan Kulow
63ccac76d5 Work on accept command - not yet done 2019-11-19 08:04:10 +01:00
Stephan Kulow
9235ab50db Remove config command - the config isn't used any more
The only use case left is displaying 'todo' config on accept - but staging managers
don't use this. So we may need a different solution later
2019-11-19 08:04:10 +01:00
9b7af72891
StagingAPI: complex delete requests are no longer used
* Simplify the 'accept' code

openSUSE:Factory/snapshot is newly setup as a Download on Demand repository
and we can thus safe ourselves the hassle of having to take extra care of
handling delete requests. They no longer bleed directly into the /snapshot
area and can now be accepted like any other request

* Drop vdelreq plugin

Since we no longer do a virtual accept of delete requests, we also don't
have to monitor their state anymore. Drop the plugin that served only
this usecase

* Drop the acheck command

As a consequence, the command 'staging acheck' serves no purpose anymore:
/totest was just there to ensure we have something to copy to /snapshot.
This entire repo will vanish, and it is thus no longer needed to verify
if it is in sync before accepting new data.
2019-10-17 15:37:44 +02:00
678f243b2b virtually accept: fix string type handling in Python3 2019-05-28 16:51:00 +08:00
5d13e07b5a accept_command: fix missing the url for uploading product file change
Regression from acc0ffc3852700cc996109f350f72dcb9ff1b3fe , we still need
url for uploading product file change.
2019-05-24 18:12:26 +08:00
acc0ffc385 osclib: make source_file_load() always return string
Makes sense always return string from source_file_load(), this
preventing potentially TypeError on python3. Also changed product file
loading, now source_file_load() used.
2019-05-15 19:34:05 +08:00
be05e42da8 accept_command: no longer need to triggering product converter service 2019-01-24 17:49:31 +08:00
2ae694a912 accept_command: add additional version number to OSRT:ProductVersion 2019-01-15 19:46:57 +08:00
Jimmy Berry
536e17cb79 osclib/stagingapi: rename dashboard_content_* methods to pseudometa_file_*.
No need to be confusing and use the deprecated dashboard name.
2018-08-17 23:19:24 -05:00
Jimmy Berry
5e6df089a6 osclib/stagingapi: drop {load,save}_file_content() methods.
Since the implementations have been made generic and dropped to osclib.core
there is not point in having wrappers in StagingAPI with the same args.
2018-08-17 22:15:58 -05:00
Stephan Kulow
9b4b0ed15a Begin porting to python3 (osc branch) 2018-05-14 11:04:39 +02:00
Jimmy Berry
bb576ca137 osclib/accept_command: avoid making empty commit to dashboard. 2018-04-24 20:10:34 -05:00
64bd11baf4
Staging accept: run service in ports 000product 2018-03-29 12:01:07 +02:00
Jimmy Berry
e450a1519e osclib/stagingapi: rename main_repo to cmain_repo.
The previous name is inconsistent and did not work with general lazy laod.
2018-03-07 15:50:36 -06:00