Philip Withnall
8ae07a727a
glib.supp: Add some fundamental type suppressions
...
Signed-off-by: Philip Withnall <withnall@endlessm.com >
2019-09-02 14:16:33 +01:00
Philip Withnall
c8c75dc7ad
glib.supp: Fix some indentation
...
Signed-off-by: Philip Withnall <withnall@endlessm.com >
2019-09-02 14:16:33 +01:00
Philip Withnall
adb9264d12
glib.supp: Add leak types
...
Mark all the memcheck leaks as ‘reachable’, so the suppressions will not
apply if that memory is no longer reachable on exit(). This feature was
introduced in Valgrind 3.9, and is documented here:
http://valgrind.org/docs/manual/mc-manual.html#mc-manual.suppfiles
Signed-off-by: Philip Withnall <withnall@endlessm.com >
2019-09-02 14:16:33 +01:00
Philip Withnall
a6ecfeea4c
tests: Don’t run Python tests under Valgrind
...
The Python runtime is not amenable to Valgrind, and leak checking is a
lot less relevant in Python compared to C.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Helps: #487
2019-09-02 14:16:33 +01:00
Philip Withnall
0cc745f6cb
ci: Include stderr output in JUnit XML report
...
When running tests under valgrind, the valgrind summary is printed in
stderr, and the TAP output is printed in stdout. The valgrind summary is
useful to include in the GitLab test report, so append it to the
textual failure information for failed tests.
I can’t find a better XML element in the [JUnit
schema](https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd )
for representing it.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Helps: #487
2019-09-02 14:16:33 +01:00
Philip Withnall
197eff3fc8
ci: Add valgrind memcheck support on Fedora
...
Add a separate CI job which runs memcheck on the unit tests. This is
done as a separate job from the main build, since we don’t want it to
interact with code coverage at all.
Currently, failure of this job is ignored. Issue #333 will eventually
fix that.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Fixes : #487
2019-09-02 14:16:33 +01:00
Philip Withnall
8d19b95bd8
ci: Add valgrind to fedora Docker image
...
It will be used in an upcoming commit.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Helps: #487
2019-09-02 14:16:33 +01:00
Philip Withnall
e8ea2aebe7
gerror: Add a docs paragraph about not displaying errors verbatim in UI
...
It’s confusing and often doesn’t help the user. Match the error code and
come up with a more UI-appropriate error message.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
2019-09-02 14:16:33 +01:00
Nirbheek Chauhan
4387f7b7b6
Merge branch '1803-gio-open-docs' into 'master'
...
docs: Mention environment variables in `gio open` documentation
Closes #1803
See merge request GNOME/glib!1051
2019-08-26 12:22:06 +00:00
Nirbheek Chauhan
1a0ba6410a
Merge branch '1879-leak-suppressions' into 'master'
...
glib.supp: Add some missing suppressions for one-time allocations
Closes #1879
See merge request GNOME/glib!1052
2019-08-26 12:04:08 +00:00
Nirbheek Chauhan
23f405df80
Merge branch '1881-fix-gio-use-volume-monitor' into 'master'
...
gvolumemonitor: Use GIOModule methods for getting default type
Closes #1881
See merge request GNOME/glib!1056
2019-08-26 11:47:08 +00:00
Philip Withnall
0fba8f671c
Merge branch 'meson-printf-cleanup' into 'master'
...
meson: small printf check cleanups
See merge request GNOME/glib!1032
2019-08-26 11:08:07 +00:00
Philip Withnall
0d54f00317
Merge branch 'gbacktrace_dup2_proper_handling' into 'master'
...
glib/gbacktrace.c: Handling properly the dup(stderr) call
Closes #1880
See merge request GNOME/glib!1055
2019-08-26 11:05:28 +00:00
Philip Withnall
833c24f45a
gvolumemonitor: Use GIOModule methods for getting default type
...
This fixes use of `GIO_USE_VOLUME_MONITOR=help`, and simplifies the
code. The reason this wasn’t used already seems to just be because it
was missed when `_g_io_module_get_default_type()` was introduced in
2013. The previous `get_default_native_class()` code in
`gunionvolumemonitor.c` was introduced in 2007.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Closes : #1881
2019-08-26 13:41:26 +03:00
Charles Monzat
1d26d57e1a
Update French translation
2019-08-26 09:21:54 +00:00
Zander Brown
4dfb747b3d
Update British English translation
2019-08-26 09:08:11 +00:00
Emmanuel Fleury
1e3b1eb111
glib/gbacktrace.c: Handling properly the dup(stderr) call
...
If the dup(stderr) returns '-1' (an error occured), then the program
shouldn't call a 'close(stderr); dup(old_err);' after the exec() failed.
Fix issue #1880
2019-08-26 10:49:58 +02:00
Philip Withnall
c21892ee13
Merge branch 'optimize_g_nearest_pow' into 'master'
...
Optimize g_nearest_pow() function in glib/garray.c
Closes #83
See merge request GNOME/glib!1030
2019-08-26 06:21:53 +00:00
Jordi Mas
51c7baddd4
Update Catalan translation
2019-08-26 08:20:39 +02:00
Philip Withnall
12bd86a2ee
Merge branch 'G_SIGNAL_RUN_CLEANUP_do_not_call_accumulate' into 'master'
...
Run the accumulator function for RUN_CLEANUP object handlers too
Closes #512
See merge request GNOME/glib!1053
2019-08-26 06:19:07 +00:00
Sebastian Dröge
153ac4c82a
Run the accumulator function for RUN_CLEANUP object handlers too
...
Closes issue #512
2019-08-25 19:31:48 +02:00
Jeffrey Stedfast
2f8c61314c
Optimize g_nearest_pow() function in glib/garray.c
...
Closes issue #83
2019-08-25 18:37:02 +02:00
Fran Dieguez
36a9b2f923
Update Galician translation
2019-08-25 16:22:45 +00:00
Philip Withnall
26934c6305
glib.supp: Add some missing suppressions for one-time allocations
...
Various memory allocations are still reachable when a process exits, as
they contain type system information which can’t be unloaded. Suppress
those using `glib.supp`.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Closes : #1879
2019-08-25 14:35:27 +03:00
Philip Withnall
d4857047b3
Merge branch 'diagnostic-pragma-fix' into 'master'
...
tests: Fix a pragma warning on FreeBSD
See merge request GNOME/glib!1050
2019-08-25 09:07:48 +00:00
Philip Withnall
73b925ba6a
Merge branch 'typos-doc' into 'master'
...
minor typos in the documentation
See merge request GNOME/glib!1049
2019-08-25 08:08:42 +00:00
Philip Withnall
b2eb0a6f15
docs: Mention environment variables in gio open
documentation
...
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Closes : #1803
2019-08-25 11:05:07 +03:00
Дилян Палаузов
512655aa12
minor typos in the documentation (a/an)
2019-08-24 19:14:05 +00:00
Philip Withnall
c178c9734c
Merge branch 'static_analysis_2_40_patches' into 'master'
...
Static analysis 2 40 patches
Closes #905
See merge request GNOME/glib!1042
2019-08-24 14:22:38 +00:00
Colin Walters
651e3b05d8
glib/goption.c: Replace precondition with assertion
...
A static analysis run noted that we weren't freeing the cmdline in the
error path here. We can just make this an assertion instead; I just
checked the kernel code, and it just usees a seq_printf() here which
will NUL terminate.
2019-08-24 15:55:49 +02:00
Colin Walters
649faee0e6
gio/gnetworkmonitornetlink.c: Add NULL check on dest before using it
2019-08-24 15:55:49 +02:00
Colin Walters
7b0139b9f4
gobject/gobject.c: Tweak conditional to pacify static analysis
...
It can't easily see that value is always non-NULL here;
this equivalent tweak will show that it is.
2019-08-24 15:55:49 +02:00
Colin Walters
f731dd376c
gio/glib-compile-resources.c: Unref objects in error path
2019-08-24 15:44:59 +02:00
Philip Withnall
f9a24ced63
tests: Fix a pragma warning on FreeBSD
...
This fixes the following warning, by making the compiler checks for the
`pop` match those for the `push`:
```
[221/1124] Compiling C object 'glib/tests/d796b50@@mem-overflow@exe/mem-overflow.c.o'.
../glib/tests/mem-overflow.c:204:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas]
#pragma GCC diagnostic pop
```
Signed-off-by: Philip Withnall <withnall@endlessm.com >
2019-08-24 15:49:48 +03:00
Jordi Mas
b46f8ffc60
Update Catalan translation
2019-08-24 05:31:48 +02:00
Philip Withnall
3c9ff2712f
Merge branch 'override' into 'master'
...
Meson: Override glib-compile-resources/schemas
See merge request GNOME/glib!1037
2019-08-23 11:30:46 +00:00
Asier Sarasua Garmendia
3beaadcd77
Update Basque translation
2019-08-23 07:24:59 +00:00
Christian Kirbach
a088baf1d6
Update German translation
2019-08-22 18:51:18 +00:00
Daniel Mustieles
79dd753223
Updated Spanish translation
2019-08-22 15:06:13 +02:00
Kukuh Syafaat
beac955143
Update Indonesian translation
2019-08-22 12:23:57 +00:00
Anders Jonsson
8f5111d790
Update Swedish translation
2019-08-22 09:54:10 +00:00
Philip Withnall
07beaa67b6
Merge branch 'wip/smcv/mips-sigaction' into 'master'
...
cond test: Don't make assumptions about struct sigaction member order
See merge request GNOME/glib!1036
2019-08-22 08:42:45 +00:00
Daniel Șerbănescu
415a665c31
Update Romanian translation
2019-08-21 20:20:47 +00:00
Piotr Drąg
415c0e0619
Update Polish translation
2019-08-21 20:12:21 +02:00
Philip Withnall
13e947d8cf
Merge branch '1867-en-gb-isms' into 'master'
...
glib-compile-schemas: Fix some minor en_GB-isms in translatable strings
Closes #1867
See merge request GNOME/glib!1038
2019-08-21 17:53:43 +00:00
Philip Withnall
84cabe96b8
Merge branch '1620-dbus-proxy-tests' into 'master'
...
Add unit tests for !554 (D-Bus peer to peer usage with bus names)
Closes #1620
See merge request GNOME/glib!1045
2019-08-21 17:25:27 +00:00
Philip Withnall
5f5f98f3d0
Merge branch 'test-bug-base' into 'master'
...
Relax use of g_test_bug() to not require g_test_bug_base() to be called first
See merge request GNOME/glib!1044
2019-08-21 17:21:52 +00:00
Philip Withnall
87a71fe4d3
tests: Add a test for peer-to-peer GDBusProxy usage with a bus name
...
This is a regression test for the fix in !554 .
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Fixes : #1620
2019-08-21 19:49:06 +03:00
Philip Withnall
a01983f94c
tests: Add a test for g_dbus_connection_get_flags()
...
It was added in !554 but never had a unit test.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
Helps: #1620
2019-08-21 19:49:06 +03:00
Philip Withnall
9fc745db07
tests: Drop unnecessary usage of g_test_bug_base("")
...
See the previous commit.
Signed-off-by: Philip Withnall <withnall@endlessm.com >
2019-08-21 19:42:27 +03:00